Linux USB
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Ryan Chen <ryan_chen@aspeedtech.com>
Cc: devicetree@vger.kernel.org,
	Conor Dooley <conor.dooley@microchip.com>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Philipp Zabel <p.zabel@pengutronix.de>,
	linux-usb@vger.kernel.org,  Conor Dooley <conor+dt@kernel.org>,
	linux-kernel@vger.kernel.org,
	 Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH v3 3/4] dt-bindings: usb: uhci: Add Aspeed AST2700 compatible
Date: Thu, 18 Sep 2025 23:32:33 -0500	[thread overview]
Message-ID: <175825635392.3818629.9388010825543490994.robh@kernel.org> (raw)
In-Reply-To: <20250919025712.719246-4-ryan_chen@aspeedtech.com>


On Fri, 19 Sep 2025 10:57:11 +0800, Ryan Chen wrote:
> Add the compatible string for Aspeed AST2700 SoC.
> 
> Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> ---
>  Documentation/devicetree/bindings/usb/usb-uhci.yaml | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/usb/usb-uhci.yaml:57:2: [error] syntax error: expected <block end>, but found '<block sequence start>' (syntax)
./Documentation/devicetree/bindings/usb/usb-uhci.yaml:58:7: [warning] wrong indentation: expected 5 but found 6 (indentation)
./Documentation/devicetree/bindings/usb/usb-uhci.yaml:62:5: [warning] wrong indentation: expected 3 but found 4 (indentation)

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/usb-uhci.yaml: ignoring, error parsing file
./Documentation/devicetree/bindings/usb/usb-uhci.yaml:57:2: expected <block end>, but found '<block sequence start>'
make[2]: *** Deleting file 'Documentation/devicetree/bindings/usb/usb-uhci.example.dts'
Documentation/devicetree/bindings/usb/usb-uhci.yaml:57:2: expected <block end>, but found '<block sequence start>'
make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/usb/usb-uhci.example.dts] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1525: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250919025712.719246-4-ryan_chen@aspeedtech.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2025-09-19  4:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-19  2:57 [PATCH v3 0/4] Add Aspeed AST2700 uhci support Ryan Chen
2025-09-19  2:57 ` [PATCH v3 1/4] dt-bindings: usb: uhci: Add reset property Ryan Chen
2025-09-19  2:57 ` [PATCH v3 2/4] usb: uhci: Add reset control support Ryan Chen
2025-09-19 15:03   ` Alan Stern
2025-09-21  1:45     ` Ryan Chen
2025-09-22  2:03       ` Ryan Chen
2025-09-19  2:57 ` [PATCH v3 3/4] dt-bindings: usb: uhci: Add Aspeed AST2700 compatible Ryan Chen
2025-09-19  4:32   ` Rob Herring (Arm) [this message]
2025-09-19  2:57 ` [PATCH v3 4/4] usb: uhci: Add Aspeed AST2700 support Ryan Chen
2025-09-19 15:08   ` Alan Stern
2025-09-21  1:51     ` Ryan Chen
2025-09-22  2:52       ` Ryan Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175825635392.3818629.9388010825543490994.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=ryan_chen@aspeedtech.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox