From: "Rob Herring (Arm)" <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Wesley Cheng <quic_wcheng@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/5] dt-bindings: usb: qcom,snps-dwc3: Add missing clocks and interrupts constraints
Date: Tue, 24 Mar 2026 20:11:21 -0500 [thread overview]
Message-ID: <177440108099.2346208.7210868672113394229.robh@kernel.org> (raw)
In-Reply-To: <20260323-dt-bindings-snps-qcom-dwc3-cleanup-v2-2-3bcd37c0a5b5@oss.qualcomm.com>
On Mon, 23 Mar 2026 09:54:13 +0100, Krzysztof Kozlowski wrote:
> The top-level part defines variable number of clocks and interrupts, and
> each "if:then:" block narrows them. It however narrows only the
> maxItems leaving minItems undefined, which then takes different values
> depending on dtschema being used.
>
> Recommended style is to avoid ambiguity in such case, thus if top-level
> part has broad constraints, then each "if:then:" must specify both upper
> and lower limits.
>
> Add missing constraints, mostly minItems but also maxItems for one
> variant.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>
> ---
>
> Changes in v2:
> 1. Narrow also interrupts for qcom,ipq5018-dwc3/qcom,ipq5332-dwc3
> ---
> Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
next prev parent reply other threads:[~2026-03-25 1:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 8:54 [PATCH v2 0/5] dt-bindings: USB: qcom,snps-dwc3: cleanup of existing bindings Krzysztof Kozlowski
2026-03-23 8:54 ` [PATCH v2 1/5] dt-bindings: usb: qcom,snps-dwc3: Drop stale child node comment Krzysztof Kozlowski
2026-03-25 1:10 ` Rob Herring (Arm)
2026-03-23 8:54 ` [PATCH v2 2/5] dt-bindings: usb: qcom,snps-dwc3: Add missing clocks and interrupts constraints Krzysztof Kozlowski
2026-03-25 1:11 ` Rob Herring (Arm) [this message]
2026-03-23 8:54 ` [PATCH v2 3/5] dt-bindings: usb: qcom,snps-dwc3: Add constraints for SM6375 Krzysztof Kozlowski
2026-03-23 10:57 ` Konrad Dybcio
2026-03-25 1:13 ` Rob Herring (Arm)
2026-03-23 8:54 ` [PATCH v2 4/5] dt-bindings: usb: qcom,snps-dwc3: Add constraints for SM4250 Krzysztof Kozlowski
2026-03-23 11:01 ` Konrad Dybcio
2026-03-23 11:14 ` Krzysztof Kozlowski
2026-03-23 8:54 ` [PATCH v2 5/5] dt-bindings: usb: qcom,snps-dwc3: Add constraints for IPQ5424 and IPQ9574 Krzysztof Kozlowski
2026-03-25 1:14 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177440108099.2346208.7210868672113394229.robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_wcheng@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox