RE: [PATCH net-next v4 3/3] r8152: add helper functions for PHY OCP registers

Hayes Wang
2026-03-26T13:20:17Z

Chih Kai Hsu <hsu.chih.kai@realtek.com>
> Sent: Thursday, March 26, 2026 3:39 PM
> To: kuba@kernel.org; davem@davemloft.net
> Cc: netdev@vger.kernel.org; nic_swsd <nic_swsd@realtek.com>;
> linux-kernel@vger.kernel.org; linux-usb@vger.kernel.org;
> edumazet@google.com; bjorn@mork.no; pabeni@redhat.com; Chih Kai Hsu
> <hsu.chih.kai@realtek.com>
> Subject: [PATCH net-next v4 3/3] r8152: add helper functions for PHY OCP
> registers
>
> Add the following bitwise operation functions for PHY OCP registers to simplify
> the code.
>
> - ocp_reg_w0w1()
> - ocp_reg_clr_bits()
> - ocp_reg_set_bits()
> - sram_write_w0w1()
> - sram_clr_bits()
> - sram_set_bits()
> - r8152_mdio_clr_bit()
> - r8152_mdio_set_bit()
> - r8152_mdio_test_and_clr_bit()
>
> In addition, remove variable set but not used from r8153_init(),
> r8153b_init() and r8153c_init().
>
> Signed-off-by: Chih Kai Hsu <hsu.chih.kai@realtek.com>

Reviewed-by: Hayes Wang <hayeswang@realtek.com>

Best Regards,
Hayes