From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F918C7EE23 for ; Thu, 18 May 2023 09:57:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230346AbjERJ54 (ORCPT ); Thu, 18 May 2023 05:57:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230344AbjERJ5z (ORCPT ); Thu, 18 May 2023 05:57:55 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 370591A4 for ; Thu, 18 May 2023 02:57:51 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-4f3a7241c0aso348482e87.1 for ; Thu, 18 May 2023 02:57:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684403869; x=1686995869; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+fi2K2ih8ubNNH5ts+siPsdYefNa7Updp+53R5c4EGk=; b=J/vAfma9k1hVBwvI1U0sxejKv2JbtGG6vzM5w4TozX/waKbatEu2l4ZHOoYQsq+rET bBKN/mm46IE8mJiUFA/048Ej/CxgCYxteYHYKTAPzAxwvvxH0nidBtm8Vk4ESkCKxcy1 ZlTQ+kGkuMhlR9ELtLeuIIlBZFpvfZ6FF/vF1pBRJh3cVIg/XS0cXvU1zNZ79MycZyIm 4hLuhVWllZEnAoH7RYg2yKiQp6qq7utgcKHe8n1F1f4DTzz0N4ivd4xWI23X4bfZMyXt DlxQGlvbtwvEJMyprlG8pXVtSLKrFJMcaZvN8GIJllKJ+6zr0FlxJxwpnz83beFiLre4 KrPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684403869; x=1686995869; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+fi2K2ih8ubNNH5ts+siPsdYefNa7Updp+53R5c4EGk=; b=LPRNs9Dpl5STk5FeO4Ia/p6LTCLPZGugy3aGphXfBDurfjhIp4HEzySaIvNhQVFW56 OXXTBykbxDo95ramKL6Ii/bSQ0hvepKyVL82FsFlj2cykCU/gT9YMClxkrWwljd79oLa 6pdOwPtU5HNus5SryuaAmFGq3xqnZORwbP0L3zha83lA7niWHLel6N38JfihGR6VE0gS suFO+4qInfM4DvdpRc/Y/BrIpQOUNinK8cWkY5jTJvwu+37llcsyrLmx6t3WbqKHDm2D JeJGyqdFXXzOLBK1rg4AgZtdVl9yQrLPeMJAGHOuG1cGKZ1FZM36J3RagO/W0mDXr1+q awFw== X-Gm-Message-State: AC+VfDwYYejytGXbf4k2liEunc4GxBX2QTNbLVxNf2r4hDXFgNPrqQyM P6+IwXlVgFUrZq2B9NQ+JjS0Jg== X-Google-Smtp-Source: ACHHUZ7EGCNw+zzJkw+MsrJrijBrAQg2OgAeyFpyRWLczaVQ70GcXbkHlNU1ozBevshl36LBSWeNqQ== X-Received: by 2002:ac2:52b2:0:b0:4ef:ef67:65c9 with SMTP id r18-20020ac252b2000000b004efef6765c9mr1082916lfm.23.1684403869439; Thu, 18 May 2023 02:57:49 -0700 (PDT) Received: from [192.168.1.101] (abxi58.neoplus.adsl.tpnet.pl. [83.9.2.58]) by smtp.gmail.com with ESMTPSA id w26-20020a19c51a000000b004eb3b6da6f5sm189050lfe.228.2023.05.18.02.57.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 May 2023 02:57:49 -0700 (PDT) Message-ID: <17f26ff4-e71f-1469-843d-ee7a5cd566a1@linaro.org> Date: Thu, 18 May 2023 11:57:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 92/97] usb: typec: qcom-pmic-typec: Convert to platform remove callback returning void Content-Language: en-US To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Andy Gross , Bjorn Andersson , Heikki Krogerus , Greg Kroah-Hartman Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, kernel@pengutronix.de References: <20230517230239.187727-1-u.kleine-koenig@pengutronix.de> <20230517230239.187727-93-u.kleine-koenig@pengutronix.de> From: Konrad Dybcio In-Reply-To: <20230517230239.187727-93-u.kleine-koenig@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 18.05.2023 01:02, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart from > emitting a warning) and this typically results in resource leaks. To improve > here there is a quest to make the remove callback return void. In the first > step of this quest all drivers are converted to .remove_new() which already > returns void. Eventually after all drivers are converted, .remove_new() is > renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König > --- Reviewed-by: Konrad Dybcio Konrad > drivers/usb/typec/qcom-pmic-typec.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/typec/qcom-pmic-typec.c b/drivers/usb/typec/qcom-pmic-typec.c > index 432ea62f1bab..924af87fb26d 100644 > --- a/drivers/usb/typec/qcom-pmic-typec.c > +++ b/drivers/usb/typec/qcom-pmic-typec.c > @@ -228,7 +228,7 @@ static int qcom_pmic_typec_probe(struct platform_device *pdev) > return ret; > } > > -static int qcom_pmic_typec_remove(struct platform_device *pdev) > +static void qcom_pmic_typec_remove(struct platform_device *pdev) > { > struct qcom_pmic_typec *qcom_usb = platform_get_drvdata(pdev); > > @@ -237,8 +237,6 @@ static int qcom_pmic_typec_remove(struct platform_device *pdev) > > typec_unregister_port(qcom_usb->port); > usb_role_switch_put(qcom_usb->role_sw); > - > - return 0; > } > > static const struct of_device_id qcom_pmic_typec_table[] = { > @@ -253,7 +251,7 @@ static struct platform_driver qcom_pmic_typec = { > .of_match_table = qcom_pmic_typec_table, > }, > .probe = qcom_pmic_typec_probe, > - .remove = qcom_pmic_typec_remove, > + .remove_new = qcom_pmic_typec_remove, > }; > module_platform_driver(qcom_pmic_typec); >