Linux USB
 help / color / mirror / Atom feed
From: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>, Val Packett <val@packett.cool>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: dwc3: qcom: Add support to skip phy management by USB core
Date: Wed, 9 Sep 2026 08:37:38 +0530	[thread overview]
Message-ID: <188ac6eb-764e-4805-b17d-e46a362adcfc@oss.qualcomm.com> (raw)
In-Reply-To: <aqC5oyqKj6A3y8WK@vbox>



On 9/9/2026 7:16 AM, Thinh Nguyen wrote:
> On Tue, Sep 08, 2026, Val Packett wrote:
>>
>> On 9/8/26 7:33 PM, Val Packett wrote:
>>>
>>> On 7/23/26 7:54 AM, Krishna Kurapati wrote:
>>>> DWC3 driver does manage phys itself sufficiently for Qualcomm platforms.
>>>> If xhci-skip-phy-init is not set, the HCD core does a phy_init and phy_
>>>> exit is done only when roothub is being destroyed. Due to this, during
>>>> system suspend in host mode, although phy_exit is done by DWC3 core, the
>>>> init_count on phy is never down to zero since HCD core also did an init.
>>>> consequently causing phy's exit routine to not be called. Hence, add
>>>> support to skip phy management by USB core.
>>>>
>>>> Some Exynos platforms still do rely on USB core for phy_calibrate calls,
>>>> hence disable USB core management for Qualcomm platforms only.
>>>>
>>>> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>>>> ---
>>>> Link to PHY calibrate handling for Exynos platforms:
>>>> https://urldefense.com/v3/__https://lore.kernel.org/all/20190829053028.32438-1-m.szyprowski@samsung.com/__;!!A4F2R9G_pg!aoY0pB27Tlxo3u1RzNzwPHpGsjuAgJWtPeKMvDrL___6gEQb28ew8Rg-O1877xBHB92Zv2fY3_Zbb2aoEQY$
>>>>
>>>
>>> Hi,
>>>
>>> this was merged into -next a few days ago, and I'm seeing warnings on
>>> boot now:
>>>
>>> [    0.613188] sysfs: cannot create duplicate filename
>>> '/devices/platform/soc@0/a800000.usb/software_node'
>>> [    0.613195] CPU: 10 UID: 0 PID: 93 Comm: kworker/u49:0 Tainted: G
>>>      W           7.3.0-rc2-next-20260907-uwu+ #143 PREEMPT(full)
>>> [    0.613197] Tainted: [W]=WARN
>>> [    0.613198] Hardware name: Dell Inc. Latitude 7455/0FK7MX, BIOS
>>> 2.13.0 09/19/2025
>>> [    0.613199] Workqueue: events_unbound deferred_probe_work_func
>>> [    0.613206] Call trace:
>>> [..]
>>> [    0.613226]  device_create_managed_software_node+0xe8/0x108
>>> [    0.613227]  dwc3_qcom_probe+0x5a4/0x7b0
>>>
>>> There is indeed already a software node being created in the shared dwc3
>>> core code.
>>>
>>> Could there be any other consequences than a duplicate sysfs path?
>>>
>> Answering my own question: even worse messages when the controller switches
>> to gadget mode (which happens even with chargers when DRD is enabled)
>>
> 
> 
> Thanks for the report Val.
> 
> Hi Krishna,
> 
> Can you help send a revert patch until a proper change is in available?
> 
Sure, will send a revert patch.

Regards,
Krishna,

      reply	other threads:[~2026-09-09  3:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-23 10:54 [PATCH] usb: dwc3: qcom: Add support to skip phy management by USB core Krishna Kurapati
2026-08-04 23:38 ` Thinh Nguyen
2026-09-08 22:33 ` Val Packett
2026-09-08 22:43   ` Val Packett
2026-09-09  1:46     ` Thinh Nguyen
2026-09-09  3:07       ` Krishna Kurapati [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=188ac6eb-764e-4805-b17d-e46a362adcfc@oss.qualcomm.com \
    --to=krishna.kurapati@oss.qualcomm.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=val@packett.cool \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox