From: Selvarasu Ganesan <selvarasu.g@samsung.com>
To: mathias.nyman@intel.com, gregkh@linuxfoundation.org,
WeitaoWang-oc@zhaoxin.com, Thinh.Nguyen@synopsys.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: jh0801.jung@samsung.com, dh10.jung@samsung.com,
naushad@samsung.com, akash.m5@samsung.com, h10.kim@samsung.com,
eomji.oh@samsung.com, alim.akhtar@samsung.com,
thiagu.r@samsung.com, muhammed.ali@samsung.com,
pritam.sutar@samsung.com, cpgs@samsung.com,
Selvarasu Ganesan <selvarasu.g@samsung.com>,
stable@vger.kernel.org
Subject: [PATCH] usb: xhci: Initialize unassigned variables to fix possible errors
Date: Mon, 10 Feb 2025 18:41:23 +0530 [thread overview]
Message-ID: <1891546521.01739216582564.JavaMail.epsvc@epcpadp2new> (raw)
In-Reply-To: CGME20250210131144epcas5p4a0599050f5973b495db0371021c21e27@epcas5p4.samsung.com
Fix the following smatch errors:
drivers/usb/host/xhci-mem.c:2060 xhci_add_in_port() error: unassigned variable 'tmp_minor_revision'
drivers/usb/host/xhci-hub.c:71 xhci_create_usb3x_bos_desc() error: unassigned variable 'bcdUSB'
Fixes: d9b0328d0b8b ("xhci: Show ZHAOXIN xHCI root hub speed correctly")
Fixes: eb02aaf21f29 ("usb: xhci: Rewrite xhci_create_usb3_bos_desc()")
Cc: stable@vger.kernel.org
Signed-off-by: Selvarasu Ganesan <selvarasu.g@samsung.com>
---
drivers/usb/host/xhci-hub.c | 2 +-
drivers/usb/host/xhci-mem.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c
index 9693464c0520..5715a8bdda7f 100644
--- a/drivers/usb/host/xhci-hub.c
+++ b/drivers/usb/host/xhci-hub.c
@@ -39,7 +39,7 @@ static int xhci_create_usb3x_bos_desc(struct xhci_hcd *xhci, char *buf,
struct usb_ss_cap_descriptor *ss_cap;
struct usb_ssp_cap_descriptor *ssp_cap;
struct xhci_port_cap *port_cap = NULL;
- u16 bcdUSB;
+ u16 bcdUSB = 0;
u32 reg;
u32 min_rate = 0;
u8 min_ssid;
diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
index 92703efda1f7..8665893df894 100644
--- a/drivers/usb/host/xhci-mem.c
+++ b/drivers/usb/host/xhci-mem.c
@@ -1980,7 +1980,7 @@ static void xhci_add_in_port(struct xhci_hcd *xhci, unsigned int num_ports,
{
u32 temp, port_offset, port_count;
int i;
- u8 major_revision, minor_revision, tmp_minor_revision;
+ u8 major_revision, minor_revision, tmp_minor_revision = 0;
struct xhci_hub *rhub;
struct device *dev = xhci_to_hcd(xhci)->self.sysdev;
struct xhci_port_cap *port_cap;
--
2.17.1
next parent reply other threads:[~2025-02-10 19:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250210131144epcas5p4a0599050f5973b495db0371021c21e27@epcas5p4.samsung.com>
2025-02-10 13:11 ` Selvarasu Ganesan [this message]
2025-02-11 5:58 ` [PATCH] usb: xhci: Initialize unassigned variables to fix possible errors Greg KH
[not found] <CGME20250210131144epcas5p4a0599050f5973b495db0371021c21e27@epcms5p7>
2025-02-11 8:37 ` Selvarasu G
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1891546521.01739216582564.JavaMail.epsvc@epcpadp2new \
--to=selvarasu.g@samsung.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=WeitaoWang-oc@zhaoxin.com \
--cc=akash.m5@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=cpgs@samsung.com \
--cc=dh10.jung@samsung.com \
--cc=eomji.oh@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=h10.kim@samsung.com \
--cc=jh0801.jung@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=muhammed.ali@samsung.com \
--cc=naushad@samsung.com \
--cc=pritam.sutar@samsung.com \
--cc=stable@vger.kernel.org \
--cc=thiagu.r@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox