* [PATCH] usb: xhci: Initialize unassigned variables to fix possible errors
[not found] <CGME20250210131144epcas5p4a0599050f5973b495db0371021c21e27@epcas5p4.samsung.com>
@ 2025-02-10 13:11 ` Selvarasu Ganesan
2025-02-11 5:58 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Selvarasu Ganesan @ 2025-02-10 13:11 UTC (permalink / raw)
To: mathias.nyman, gregkh, WeitaoWang-oc, Thinh.Nguyen, linux-usb,
linux-kernel
Cc: jh0801.jung, dh10.jung, naushad, akash.m5, h10.kim, eomji.oh,
alim.akhtar, thiagu.r, muhammed.ali, pritam.sutar, cpgs,
Selvarasu Ganesan, stable
Fix the following smatch errors:
drivers/usb/host/xhci-mem.c:2060 xhci_add_in_port() error: unassigned variable 'tmp_minor_revision'
drivers/usb/host/xhci-hub.c:71 xhci_create_usb3x_bos_desc() error: unassigned variable 'bcdUSB'
Fixes: d9b0328d0b8b ("xhci: Show ZHAOXIN xHCI root hub speed correctly")
Fixes: eb02aaf21f29 ("usb: xhci: Rewrite xhci_create_usb3_bos_desc()")
Cc: stable@vger.kernel.org
Signed-off-by: Selvarasu Ganesan <selvarasu.g@samsung.com>
---
drivers/usb/host/xhci-hub.c | 2 +-
drivers/usb/host/xhci-mem.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c
index 9693464c0520..5715a8bdda7f 100644
--- a/drivers/usb/host/xhci-hub.c
+++ b/drivers/usb/host/xhci-hub.c
@@ -39,7 +39,7 @@ static int xhci_create_usb3x_bos_desc(struct xhci_hcd *xhci, char *buf,
struct usb_ss_cap_descriptor *ss_cap;
struct usb_ssp_cap_descriptor *ssp_cap;
struct xhci_port_cap *port_cap = NULL;
- u16 bcdUSB;
+ u16 bcdUSB = 0;
u32 reg;
u32 min_rate = 0;
u8 min_ssid;
diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
index 92703efda1f7..8665893df894 100644
--- a/drivers/usb/host/xhci-mem.c
+++ b/drivers/usb/host/xhci-mem.c
@@ -1980,7 +1980,7 @@ static void xhci_add_in_port(struct xhci_hcd *xhci, unsigned int num_ports,
{
u32 temp, port_offset, port_count;
int i;
- u8 major_revision, minor_revision, tmp_minor_revision;
+ u8 major_revision, minor_revision, tmp_minor_revision = 0;
struct xhci_hub *rhub;
struct device *dev = xhci_to_hcd(xhci)->self.sysdev;
struct xhci_port_cap *port_cap;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: xhci: Initialize unassigned variables to fix possible errors
2025-02-10 13:11 ` [PATCH] usb: xhci: Initialize unassigned variables to fix possible errors Selvarasu Ganesan
@ 2025-02-11 5:58 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2025-02-11 5:58 UTC (permalink / raw)
To: Selvarasu Ganesan
Cc: mathias.nyman, WeitaoWang-oc, Thinh.Nguyen, linux-usb,
linux-kernel, jh0801.jung, dh10.jung, naushad, akash.m5, h10.kim,
eomji.oh, alim.akhtar, thiagu.r, muhammed.ali, pritam.sutar, cpgs,
stable
On Mon, Feb 10, 2025 at 06:41:23PM +0530, Selvarasu Ganesan wrote:
> Fix the following smatch errors:
>
> drivers/usb/host/xhci-mem.c:2060 xhci_add_in_port() error: unassigned variable 'tmp_minor_revision'
> drivers/usb/host/xhci-hub.c:71 xhci_create_usb3x_bos_desc() error: unassigned variable 'bcdUSB'
>
> Fixes: d9b0328d0b8b ("xhci: Show ZHAOXIN xHCI root hub speed correctly")
> Fixes: eb02aaf21f29 ("usb: xhci: Rewrite xhci_create_usb3_bos_desc()")
This should be two different changes, right?
Please break it up and send as a patch series.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: xhci: Initialize unassigned variables to fix possible errors
[not found] <CGME20250210131144epcas5p4a0599050f5973b495db0371021c21e27@epcms5p7>
@ 2025-02-11 8:37 ` Selvarasu G
0 siblings, 0 replies; 3+ messages in thread
From: Selvarasu G @ 2025-02-11 8:37 UTC (permalink / raw)
To: Greg KH
Cc: mathias.nyman@intel.com, WeitaoWang-oc@zhaoxin.com,
Thinh.Nguyen@synopsys.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, JaeHun Jung, JUNG Daehwan,
NAUSHAD KOLLIKKARA, Akash M, Hyunsoon Kim, OH Eomji, ALIM AKHTAR,
Thiagu Ramalingam, Muhammed Ali K P, Pritam Manohar Sutar, CPGS,
stable@vger.kernel.org
On 2/11/2025 11:28 AM, Greg KH wrote:
> On Mon, Feb 10, 2025 at 06:41:23PM +0530, Selvarasu Ganesan wrote:
>> Fix the following smatch errors:
>>
>> drivers/usb/host/xhci-mem.c:2060 xhci_add_in_port() error: unassigned variable 'tmp_minor_revision'
>> drivers/usb/host/xhci-hub.c:71 xhci_create_usb3x_bos_desc() error: unassigned variable 'bcdUSB'
>>
>> Fixes: d9b0328d0b8b ("xhci: Show ZHAOXIN xHCI root hub speed correctly")
>> Fixes: eb02aaf21f29 ("usb: xhci: Rewrite xhci_create_usb3_bos_desc()")
> This should be two different changes, right?
>
> Please break it up and send as a patch series.
>
> thanks,
>
> greg k-h
Hi Greg,
Thanks for your comments. Sure i will send as a patch series.
Thanks,
Selva
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-11 10:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20250210131144epcas5p4a0599050f5973b495db0371021c21e27@epcas5p4.samsung.com>
2025-02-10 13:11 ` [PATCH] usb: xhci: Initialize unassigned variables to fix possible errors Selvarasu Ganesan
2025-02-11 5:58 ` Greg KH
[not found] <CGME20250210131144epcas5p4a0599050f5973b495db0371021c21e27@epcms5p7>
2025-02-11 8:37 ` Selvarasu G
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox