From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: linux-usb@vger.kernel.org
Subject: [3/4] usb: dwc3: trace: log ep commands in hex
Date: Mon, 20 Aug 2018 14:25:47 +0300 [thread overview]
Message-ID: <18950561.PQFfYBpCjN@avalon> (raw)
Hi Felipe,
Thank you for the patch.
On Monday, 20 August 2018 13:30:00 EEST Felipe Balbi wrote:
> They are much more useful in hexadecimal than in decimal. Moreover,
> generic commands are already logged in hex.
>
> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
> ---
> drivers/usb/dwc3/trace.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/trace.h b/drivers/usb/dwc3/trace.h
> index f22714cce070..50fb6f2d92dd 100644
> --- a/drivers/usb/dwc3/trace.h
> +++ b/drivers/usb/dwc3/trace.h
> @@ -199,7 +199,7 @@ DECLARE_EVENT_CLASS(dwc3_log_gadget_ep_cmd,
> __entry->param2 = params->param2;
> __entry->cmd_status = cmd_status;
> ),
> - TP_printk("%s: cmd '%s' [%d] params %08x %08x %08x --> status: %s",
> + TP_printk("%s: cmd '%s' [%x] params %08x %08x %08x --> status: %s",
How about 0x%x ? Otherwise one could get confused when the command
representation in hex doesn't contain a letter (especially given that this
patch transitions from decimal to hexadecimal).
> __get_str(name), dwc3_gadget_ep_cmd_string(__entry->cmd),
> __entry->cmd, __entry->param0,
> __entry->param1, __entry->param2,
next reply other threads:[~2018-08-20 11:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-20 11:25 Laurent Pinchart [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-08-23 12:03 [3/4] usb: dwc3: trace: log ep commands in hex Laurent Pinchart
2018-08-23 9:57 Andy Shevchenko
2018-08-20 12:22 Laurent Pinchart
2018-08-20 12:06 Andy Shevchenko
2018-08-20 10:30 Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18950561.PQFfYBpCjN@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=felipe.balbi@linux.intel.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).