From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 426DB226D02 for ; Wed, 8 Oct 2025 11:15:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759922117; cv=none; b=uDgVyLmA+QOXqVQBHBUySjca7WvWKvSnn6NZL09jnzLNDJI4+TkY1C07nqqY/e63BRRAoS2sgiTW/N8JrvPAHDXGXSTts8qvEjHAxetFBFRR9btFOnKGq98J7pqxe7JkByvwB7DhjmtAJzdfUEdmeC0k7hwOYJH38a7U+8xqRaQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759922117; c=relaxed/simple; bh=wWnVyzijTaXYM8xRXWXruZLI0i53tO5UZxS0bwONy4M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WcRdNVPWqe7a/2/GGAQZspFpl9XftS2/Z1YsTuIJ3LW60pmDp7JXzc+H1JH0D742Lh7+9mc6079jr2NIcS2ZV1OOJFuczKuPygRAMUfpf4EzUXzwqBZOofbFSzJOGsBqQWcJKsSvMYtbL5UXREmvNLmuwe40c3I6FWo+bZ07sQs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZSXCnHEA; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZSXCnHEA" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59890R6R028965 for ; Wed, 8 Oct 2025 11:15:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EffddiefyYfOOHaQK61w1botCVru6MZ1eFfoN02Iyrs=; b=ZSXCnHEADqmTBe4U 0ReFXRa/SSZ7GCIiNdfSQhS7xYhfkP3PNgDdIjRoPmexk2TVhP2CoEbCJlL0xOrO zCwqy4mtIV8L3OV49s/dAjY6uAo6xM+XN0ydiMSlZ9nncuZ0gSbooene1sHdy42s 9IbT3CyTOo3HBW5tEXtGuXElst0gSkPZdtvd7pRE71pF/e49qx7R7TY4z4gRFq3f pV92ynk10rpCygUo0j+YWTQGxeH9LHD20DihSuSzPRsK7LaJ3prUKwWPwNbLhbJF 42k0riTdF0apM2lfTx4/38r/CgeTA7V6Pk1ylXApBWqYM9ZDQlbM92JDf+cQOy0z 1sXtpw== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49js9e2cxn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 08 Oct 2025 11:15:13 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-b62f9247dd1so3517893a12.0 for ; Wed, 08 Oct 2025 04:15:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759922112; x=1760526912; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EffddiefyYfOOHaQK61w1botCVru6MZ1eFfoN02Iyrs=; b=NBTOtwxu9Bs9i53tIKTGkxoAbont1RPx4rvdZqrLkeHPnBB8e7LbD2WAH9Sae5Wpp0 xehXFxLTOQsgOD8QO9ZJI68+QqzlreUfLjQL1Np3poloTParccmTJ679hCbQfEql32hm rNB3y/Odg7J6jDc/YcIk4v/cqeB5Iw/wgRNzLCXdi0zFGT0e+QP+ZGKOdz0l+UYKHKxx 1RhDHi3Q/cC9KJMeENqA0tYzqFZi82QSBcx/6AS3vMoXI2mishRokfBtRRSou0xsRDqg zHxmu+vV14HYiBBOBOOgKZxWd0RC9vegm+X4kl2L15h8hzMc/991ooWIfL29mCupT/Kn UzQQ== X-Forwarded-Encrypted: i=1; AJvYcCVvXaqWZDfzckaSmyNEIZYfPt70h2agcrwlVfQjsfa0mjmTblIEMTQCH7FPM4FtsxoEjs2IKRaQE5g=@vger.kernel.org X-Gm-Message-State: AOJu0YystFam7BWE0ULqtMhWSXT9KEqnLsiSqFDZzXqZ00Nlsr8gGZ9s Pgx3HiEK/ZeCm1RZ9EH2ihmgsbuj8K/S4GM45GEanTdju3kysJgelgLTc4Aom7B7b3Fwt+bZoPH Bw39IbOXpuI8sWPecqJBuBjhaO3I+MACMcBBoyLs0X+DzB4pYTYVpWz8cXUEiD2U= X-Gm-Gg: ASbGnctwQuV5vPR3LKzfKYg5m9bm8trKBDHsN/Pn13vMKoLNR9nEojBprpH9LBwhUA0 VsUORSIZLEbi0vQiNx7EIhB0Jo7Zn4EMd69HVIy+TNmz6spFzu7b06aP9rGhO7WXHOep2y4uLXv xy/q5zDaSVY5aF3au8qIr/bfn2PNIxJ48Z6uCWkOYTcXi3ad/Amj2xa9YuiO0lCOPy/wkUdV3iP lWI7Opja1MSEidG6Sb3PtcH/fCL0ZGG7kLlxh2u2gh0DM7V/7zwJzBId/MD7gLNtPUcWiqA9iq/ //Vfl5RhECWdqrC+vefobal0RRtppy5/Fchb2ZjmngouLCs0joWsd5YSRJMnvMksIaYQ5fWMAC8 XzCE= X-Received: by 2002:a05:6a20:72a2:b0:32b:6e33:7cf8 with SMTP id adf61e73a8af0-32da83e0614mr4191372637.42.1759922112407; Wed, 08 Oct 2025 04:15:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHD86ge8saAFK6qXLniY8kj2xnoyg29DHHxFtqkJCu4J95pDu9HmYbmCPGlP2aG0dKTCHvZZA== X-Received: by 2002:a05:6a20:72a2:b0:32b:6e33:7cf8 with SMTP id adf61e73a8af0-32da83e0614mr4191337637.42.1759922111902; Wed, 08 Oct 2025 04:15:11 -0700 (PDT) Received: from [10.218.1.199] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b6099f7ab4fsm17822615a12.44.2025.10.08.04.15.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Oct 2025 04:15:11 -0700 (PDT) Message-ID: <1a428b7f-5d20-4d55-aa3a-e4feb580b82e@oss.qualcomm.com> Date: Wed, 8 Oct 2025 16:45:06 +0530 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] usb: typec: hd3ss3220: Enable VBUS based on ID pin state To: Heikki Krogerus Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Girdwood , Mark Brown , Biju Das , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251002172539.586538-1-krishna.kurapati@oss.qualcomm.com> <20251002172539.586538-3-krishna.kurapati@oss.qualcomm.com> Content-Language: en-US From: Krishna Kurapati PSSNV In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Hrl72kTS c=1 sm=1 tr=0 ts=68e647c1 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=EUspDBNiAAAA:8 a=JreEDKClX95j7y97460A:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-GUID: Ms_LnblM4afXUp9Tc51WHkHdJIUdnVXA X-Proofpoint-ORIG-GUID: Ms_LnblM4afXUp9Tc51WHkHdJIUdnVXA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDA0MDAwNCBTYWx0ZWRfXyz+osioeuZiY a6cRfV6QcCgkGcVjhTqvuLcZAgRVMxiK3KwbEW3fPDE8uonRK1jsNNntOvkbOClPD8ALRxLOtlC H/cyxK646EiAE5OEqkRn9FoDRagSOgDUr5haCDLUjdcxVsjzYPfvh9HJDm1ALgvM3hG4JIsoeoU 01rfB34Yqp0ek3pdVkTTAjCT7Enq2FGReceTZPZej4INv9MxAbJRCH6qLC6/7mcoGi5j4JVc1T+ tHnUOIYwAag7+tvaG9DUC1CJHY3oCxo0WYkjVdWRhocOZJEEw0DVtJPld3W6dm7/MmxgjyTXcaJ ZShN2SfOJDd5zCHyD7TTLQCLwhC6BnPhqhujrQFXgDnXk2UTlfsFCkuZsKoIqAhumQip2BF7hzl dDgd+i/sHVzgTUN/70cA6Id1iEad3g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-08_03,2025-10-06_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2509150000 definitions=main-2510040004 On 10/8/2025 4:39 PM, Heikki Krogerus wrote: > On Thu, Oct 02, 2025 at 10:55:39PM +0530, Krishna Kurapati wrote: >> Enable VBUS on HD3SS3220 when the ID pin is low, as required by the Type-C >> specification. > > There is not ID pin on Type-C connector. There is an ID pin coming out from HD3SS3220 controller to SoC that is being referred to here. > >> The ID pin stays high when VBUS is not at VSafe0V, and goes >> low when VBUS is at VSafe0V. >> >> Add support to read the ID pin state and enable VBUS accordingly. > > I'm a bit confused about this... Why can't you just check the attached > state, and if it's DFP, then you drive VBUS? > We could, but checking for DFP doesn't ensure VBUS is at VSafe0V as per the datasheet. So using the ID pin to enable vbus. Regards, Krishna, > thanks, > >> Signed-off-by: Krishna Kurapati >> --- >> drivers/usb/typec/hd3ss3220.c | 58 +++++++++++++++++++++++++++++++++++ >> 1 file changed, 58 insertions(+) >> >> diff --git a/drivers/usb/typec/hd3ss3220.c b/drivers/usb/typec/hd3ss3220.c >> index 3ecc688dda82..44ee0be27644 100644 >> --- a/drivers/usb/typec/hd3ss3220.c >> +++ b/drivers/usb/typec/hd3ss3220.c >> @@ -54,6 +54,11 @@ struct hd3ss3220 { >> struct delayed_work output_poll_work; >> enum usb_role role_state; >> bool poll; >> + >> + struct gpio_desc *id_gpiod; >> + int id_irq; >> + >> + struct regulator *vbus; >> }; >> >> static int hd3ss3220_set_power_opmode(struct hd3ss3220 *hd3ss3220, int power_opmode) >> @@ -319,6 +324,28 @@ static const struct regmap_config config = { >> .max_register = 0x0A, >> }; >> >> +static irqreturn_t hd3ss3220_id_isr(int irq, void *dev_id) >> +{ >> + struct hd3ss3220 *hd3ss3220 = dev_id; >> + int ret; >> + int id; >> + >> + if (IS_ERR_OR_NULL(hd3ss3220->vbus)) >> + return IRQ_HANDLED; >> + >> + id = hd3ss3220->id_gpiod ? gpiod_get_value_cansleep(hd3ss3220->id_gpiod) : 1; >> + >> + if (!id) { >> + ret = regulator_enable(hd3ss3220->vbus); >> + if (ret) >> + dev_err(hd3ss3220->dev, "enable vbus regulator failed\n"); >> + } else { >> + regulator_disable(hd3ss3220->vbus); >> + } >> + >> + return IRQ_HANDLED; >> +} >> + >> static int hd3ss3220_probe(struct i2c_client *client) >> { >> struct typec_capability typec_cap = { }; >> @@ -354,6 +381,37 @@ static int hd3ss3220_probe(struct i2c_client *client) >> hd3ss3220->role_sw = usb_role_switch_get(hd3ss3220->dev); >> } >> >> + hd3ss3220->id_gpiod = devm_gpiod_get_optional(hd3ss3220->dev, "id", GPIOD_IN); >> + if (IS_ERR(hd3ss3220->id_gpiod)) >> + return PTR_ERR(hd3ss3220->id_gpiod); >> + >> + if (hd3ss3220->id_gpiod) { >> + hd3ss3220->id_irq = gpiod_to_irq(hd3ss3220->id_gpiod); >> + if (hd3ss3220->id_irq < 0) { >> + dev_err(hd3ss3220->dev, "failed to get ID IRQ\n"); >> + return hd3ss3220->id_irq; >> + } >> + >> + ret = devm_request_threaded_irq(hd3ss3220->dev, >> + hd3ss3220->id_irq, NULL, >> + hd3ss3220_id_isr, >> + IRQF_TRIGGER_RISING | >> + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, >> + dev_name(hd3ss3220->dev), hd3ss3220); >> + if (ret < 0) { >> + dev_err(hd3ss3220->dev, "failed to get id irq\n"); >> + return ret; >> + } >> + } >> + >> + hd3ss3220->vbus = devm_regulator_get_optional(hd3ss3220->dev, "vbus"); >> + if (PTR_ERR(hd3ss3220->vbus) == -ENODEV) >> + hd3ss3220->vbus = NULL; >> + >> + if (IS_ERR(hd3ss3220->vbus)) >> + return dev_err_probe(hd3ss3220->dev, >> + PTR_ERR(hd3ss3220->vbus), "failed to get vbus\n"); >> + >> if (IS_ERR(hd3ss3220->role_sw)) { >> ret = PTR_ERR(hd3ss3220->role_sw); >> goto err_put_fwnode; >> -- >> 2.34.1 >