From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D2CC38DC76 for ; Thu, 30 Jul 2026 16:46:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785429987; cv=none; b=O5wKP/yEVg8XSvqlrDRon/gnVzHSDdTa70aciSvqwe7dLcFGaODH5PhvztMCcsz0jFL+jBwgAxZm8r6azHkjMA33nKQAlQ5/hlY+70pH0y5fPcCkYL3AAYlqhL/Gsfu4FlXCoa0MgyvDmxBexbPtWUKs7IPPXtpBQ7s+2PFk7Ew= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785429987; c=relaxed/simple; bh=IAI5fPC8kUOmVOXpbjJOoXS/9005rgomTstYB1sbH1Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=b7EIsI0F1+AvbNSfUeFO+DS9qpJuUGv326Kodku0fmm7RUOM356eEglLOGLnzSryWLYRRX2bvboIvCcbkq+/erc9/t1Q/VbjzKl3bQL4AQhNEt1LSCySb/l7pXlFQy99a8ltzIOef2D3BHmSGISFu371bX4zDTOei9aD+nQrvmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ipmUR5tl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SE2OUat7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ipmUR5tl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SE2OUat7" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66UGWoxD1379730 for ; Thu, 30 Jul 2026 16:46:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 41bv1bQPLiy8a8DyzT5YhAkpHkoFIBS2fv2LzdT9CjM=; b=ipmUR5tld1IyruPP gLTAvhy5UXbBEOd/bHHBUvy61Ek7rWw+V3LY4Tf3rWescP7bFORUy41PS7fj5Kep jtTqQOvktgowmxUHVdIF8PsuO+bLpk6EVfk5LQ++oVw/iWOGACKvRrvwM/tK89eS C8C4WVMXWyfjwh2vQ7rYxPXv1104hLdjN63CVIh+Z06zJrnKJSlQ+NJB09/PhNSm pe30Z9avESrmQzHn6rRTkohbdv/1VIr11gxjzmdeb9RW6W3oiKEwCsRFhwYyOym2 mkRNmta4Jspk0/Rm/I7P8D3UPUFL9PSMVY9FS9xqqPH7DkkNFwKU9UGQ0Fvo8NiK SHUyYg== Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fr8kn0q2y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 30 Jul 2026 16:46:24 +0000 (GMT) Received: by mail-ua1-f69.google.com with SMTP id a1e0cc1a2514c-9775a8105d6so25258241.0 for ; Thu, 30 Jul 2026 09:46:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785429983; x=1786034783; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=41bv1bQPLiy8a8DyzT5YhAkpHkoFIBS2fv2LzdT9CjM=; b=SE2OUat7QMj6vC66qAEkRVBqThKcQ3/66WzYmUqxTUJqGr0y9Wei3zolWRUv4XMN+q sJyJMdxlO8T71zonZflLotl8La7BHx3gFJaACJ7mqdsf17oi1yeOrgDNcfIhRRmVkP7i TEgYTjeqQxjiPl2E7O3mramKD+cWP5MQbMgZh+Mqguhy/YwW0mxULKcSM/HuJC8nK1Et a/X9ZCUH46d3CtxI7NMYWMCW6RQFPM8IR43wmqxhWt2lDwVzM9zzjwhcyJePqxKZfjFL k6k5/QPXF/XDvGjbv1nk2G3xF8PmUgSewikVRXdOm9mryJfn9hNXEe4FJ97dn2eu7pHA mSeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785429983; x=1786034783; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=41bv1bQPLiy8a8DyzT5YhAkpHkoFIBS2fv2LzdT9CjM=; b=UH+ec92ukWgYBP78QEu3zjH69pKvXEfFZaaK2p7sGmRUqlSsDIDMDjI8sb4YrclhOS c4w1sKbexAs/VTeF7pUhLvNQI+mXl6il26KRTfsfjku6M8QjObl8c9iCbesXaEodPXML r5Hv9tyaGUw7wFNPdk6wYCSwaCkivRvQNe/gNSsy1axONkwK/JedsbXQy0LigEFh22ol a5x46/67MUoSnjiRnJ440zROmo/AKa0hj2SbEGgO3Gvr9zmS+wF1bwGNLtkOGh0qsp4G WmMioIkYmI946g53VYhGe7EhZNEJfy9CtW4105zIuJ8oHm39ArZH7UdQy8XgawizmcRw 0MHQ== X-Gm-Message-State: AOJu0YwDt6i2cVdiCe94YsUUXGOj7FPPl2KHIrrZ9MsoEVw/nWpRmK+1 3YCYUbXs1aHBPiTRvxQPXznkclRDIgb4Y5UY+o0Yv+V+9CDBxHN2z9jBVCE8SXbGt8djpwOGn5A mauXJK8a7aaFTKuB5CRbrz51W496fRe+KU2+TIL2JLrks58Qb7FJHEgEFJ5sZIV8= X-Gm-Gg: AR+sD11FLdi+ip8K2DMST4RqqFJZgem/Wdhgj2f5IWBlZ3Mrk+VXQ6rZmiTrPIMMz6l GQlevlSU9DMKFo5h5GJYTGz5OnB+dnCx3S3SjVeILo4ViAzG6F6a8wsd5830U4lzinDtx4xUbcm FrdKq3Mislp+qTMOhvSxU5XltFVQPYRZ+e/5G8nwEsAd02jZFiIIry/YFqmM/hAeezYxlZxZfkN 3S2LI9owx+CaXExGYX530v+zpQEedlVkwaOTeEwZop32G4Btqe9U8eJyi3nmUHLmcpXl2oO/+r3 x3fOKGDY84SzXPWaFx76Qik+LepAS/mOgCvFAnCHk5HbqjKx8VzJw1PFgfEbyBk5M6zP+jYYEED q0V1VH0m/xSaWQnKDHvfDUl3E X-Received: by 2002:a05:6102:8090:b0:756:32ba:1a83 with SMTP id ada2fe7eead31-758407c7a45mr602062137.2.1785429983607; Thu, 30 Jul 2026 09:46:23 -0700 (PDT) X-Received: by 2002:a05:6102:8090:b0:756:32ba:1a83 with SMTP id ada2fe7eead31-758407c7a45mr602044137.2.1785429983191; Thu, 30 Jul 2026 09:46:23 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fa851b322sm91019666b.7.2026.07.30.09.46.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jul 2026 09:46:22 -0700 (PDT) Message-ID: <1bcd1a68-a1b8-4604-8a2d-ece01ccabc00@oss.qualcomm.com> Date: Thu, 30 Jul 2026 18:46:19 +0200 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] usb: typec: mux: ps883x: refactor DP altmode handling and support TYPEC_DP_STATE_F To: jens.glathe@oldschoolsolutions.biz, Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Abel Vesa , Heikki Krogerus , Bjorn Andersson , Konrad Dybcio Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, stable@vger.kernel.org, "Dr. David Alan Gilbert" References: <20260718-ps883x-disable-usb4-v1-0-cec86d0b909e@oldschoolsolutions.biz> <20260718-ps883x-disable-usb4-v1-3-cec86d0b909e@oldschoolsolutions.biz> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260718-ps883x-disable-usb4-v1-3-cec86d0b909e@oldschoolsolutions.biz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMwMDEyNiBTYWx0ZWRfX86xlP70qCLAl 1g/3Wm1w5dGM9oHfcAwOC54rHL1U3hvVc1alESP3ldm0oKMr7+YHQNdPAzl9fKqmW/ndQZ1NMxN UdDeq+ULKtnvocRHv4/7aH/taiP5mIM= X-Proofpoint-GUID: VTWUZwwzg9UxIlE350AT2cy-NBUrycum X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMwMDEyNiBTYWx0ZWRfX7ceZy7MorkjQ f9KyYrSD5KeH++Fb/86B00dmbeCkRNXXHJ1sCe+FolxYEj9Ks2Xg34jwGJBQG/p6rmWZ2B5cKoR jzAU0rd7PBKwT2/zUbrU+aBWtC1j+kYPcZ+qDvNEED+f8WHum76qAZvnLjVzTJN/45yeZ9uGoBm ljcqqHbZgkqmxVsOPajSKTXq9j878c2RDcoAm+9Djxc+Gf2HVqXIMH9VmrJOMwdrrg88oHeFrjx 04U282RV3aLzusiPbUKqieruCuCk2xLy44zmj1yJkExJ3cI7IZoB/ri2a03EF500dWe8AZvvCNs HLox3GgmCaOlgstMDYwbYDwO8ISszZtMLgAg+zFXqZTenNMx+hE2h8RUCyAOJ1SMKl96BSoHZAj miAyFJ1lof8Eh7uYg/iMhG4Xmw+orgRaBMGL3/UJp00QO88K48DkdLOt+zhT/vQL6kLPo8QDvv/ hHRd4I3N1X3tm91Hq/Q== X-Authority-Analysis: v=2.4 cv=V7NNF+ni c=1 sm=1 tr=0 ts=6a6b7fe0 cx=c_pps a=UbhLPJ621ZpgOD2l3yZY1w==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=gxl3bz0cAAAA:8 a=Xqxl2qIfDM1Vn1vrR_wA:9 a=QEXdDO2ut3YA:10 a=TOPH6uDL9cOC6tEoww4z:22 a=kiRiLd-pWN9FGgpmzFdl:22 X-Proofpoint-ORIG-GUID: VTWUZwwzg9UxIlE350AT2cy-NBUrycum X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-30_05,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 phishscore=0 suspectscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607300126 On 7/18/26 7:06 PM, Jens Glathe via B4 Relay wrote: > From: Jens Glathe > > Several docks, including the Lenovo 40B0 and SSK SC220, still send the > legacy TYPEC_DP_STATE_F mode request (deprecated since DisplayPort Alt > Mode spec version 1.0b). Treat it as USB3 + DP altmode (same as > TYPEC_DP_STATE_D) so that DP altmode works correctly, especially on > the 40B0 in Type-C fallback mode. > > Extract the state handling into ps883x_apply_dp_altmode() (modelled > after qmp-combo-phy) for consistency. > > Assisted-by: Grok(xAI):4.3 > Signed-off-by: Jens Glathe > --- I'd say just add a oneliner `case STATE_F` here instead Konrad