From: Sergey Shtylyov <sergei.shtylyov@gmail.com>
To: Xinyu Liu <1171169449@qq.com>, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
katieeliu@tencent.com, security@tencent.com
Subject: Re: [PATCH] usb: gadget: configfs: Fix OOB read on empty string write
Date: Wed, 9 Jul 2025 22:02:28 +0300 [thread overview]
Message-ID: <1f827061-d2f1-451b-952d-3d1631d7c9a9@gmail.com> (raw)
In-Reply-To: <tencent_7181918110AAD331E6775691326AD1000408@qq.com>
On 7/9/25 1:22 PM, Xinyu Liu wrote:
[...]
> You are right, removing the blank line is inappropriate.
Empty lines separating declarations from the other statements should be kept...
> I’ve double-checked the original code and confirmed there are no invisible spaces or tabs,
I'm not seeing them as well in your patch...
> yet checkpatch.pl still reports "ERROR: trailing whitespace" on these lines. I removed the empty line here, and it resolved the error.
Hm... something wrong with your setup, I guess...
> Thanks for pointing this out!
[...]
MBR, Sergey
prev parent reply other threads:[~2025-07-09 19:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 3:55 [PATCH] usb: gadget: configfs: Fix OOB read on empty string write Xinyu Liu
2025-07-09 8:48 ` Sergey Shtylyov
2025-07-09 10:22 ` Xinyu Liu
2025-07-09 19:02 ` Sergey Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f827061-d2f1-451b-952d-3d1631d7c9a9@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=1171169449@qq.com \
--cc=gregkh@linuxfoundation.org \
--cc=katieeliu@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=security@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox