linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Michael Drake <michael.drake@codethink.co.uk>
Cc: linux-usb@vger.kernel.org
Subject: [v2,0/8] lsusb: Add initial support for USB Audio Class 3
Date: Fri, 8 Dec 2017 15:57:30 +0100	[thread overview]
Message-ID: <20171208145730.GB11135@kroah.com> (raw)

On Fri, Dec 08, 2017 at 02:44:12PM +0000, Michael Drake wrote:
> On 08/12/17 14:27, Greg KH wrote:
> > On Fri, Dec 08, 2017 at 10:30:43AM +0000, Michael Drake wrote:
> > > On 07/12/17 20:04, Greg KH wrote:
> 
> > > > --- lsusb-v.orig	2017-12-07 21:01:26.153185002 +0100
> > > > +++ lsusb-v.new	2017-12-07 21:01:32.806517978 +0100
> > > > @@ -1110,9 +1110,9 @@
> > > >            bDescriptorType        36
> > > >            bDescriptorSubtype      1 (HEADER)
> > > >            bcdADC               1.00
> > > > -        wTotalLength       0x0028
> > > > +        wTotalLength           40
> 
> [snip]
> 
> > > Anyway, since it's a 2 byte field the hex representation
> > > is expected here, and the actual value is the same.
> > 
> > Yes, the value is the same, but all other wTotalLength fields exported
> > by lsusb are in decimal.  Changing just this one feels odd to me.
> 
> Yes, that's a good reason for wanting to change the other ones.
> 
> [snip]
> 
> > I'll look at moving those other wFields to be also in 0x0000 mode to
> > match up here.
> 
> If you like I can work up a patch for that.  I'd just be tweaking
> the old printfs to dump wFields with "0x%04x".
> 
> I'm also thinking of porting more of the existing lsusb dumping
> to use the desc_dump() function, but that would have to be piece
> by piece, as I get time.

I think moving more over to use desc_dump() is a better idea, let me see
if I can do one now to see how hard/easy it is...

thanks,

greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2017-12-08 14:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-08 14:57 Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-12-08 15:29 [v2,0/8] lsusb: Add initial support for USB Audio Class 3 Greg KH
2017-12-08 14:44 Michael Drake
2017-12-08 14:27 Greg KH
2017-12-08 10:30 Michael Drake
2017-12-07 20:04 Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171208145730.GB11135@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=michael.drake@codethink.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).