* [2/2] usb: quirks: Add reset-resume quirk for Dell DW1820 QCA Rome Bluetooth
@ 2017-12-27 12:52 Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2017-12-27 12:52 UTC (permalink / raw)
To: Marcel Holtmann
Cc: Kai-Heng Feng, linux-usb, open list:BLUETOOTH DRIVERS,
Linux Kernel Mailing List, stable, Leif Liddy, Matthias Kaehlcke,
Brian Norris, Daniel Drake
On Tue, Dec 26, 2017 at 10:01:46PM +0100, Marcel Holtmann wrote:
> Hi Greg,
>
> > Commit ("fd865802c66bc451dc515ed89360f84376ce1a56 Bluetooth: btusb: fix
> > QCA Rome suspend/resume") enables reset_resume in btusb_probe(). This
> > makes the device resets during btusb_open(), firmware loading gets
> > interrupted as a result.
> >
> > We still want to reset the device to solve the original issue, but we
> > should do it before btusb_open().
> >
> > Hence, add reset-resume quirk in usb core intead of btusb.
> >
> > Cc: stable@vger.kernel.org
> > Cc: Leif Liddy <leif.linux@gmail.com>
> > Cc: Matthias Kaehlcke <mka@chromium.org>
> > Cc: Brian Norris <briannorris@chromium.org>
> > Cc: Daniel Drake <drake@endlessm.com>
> > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> >
> > ---
> > drivers/usb/core/quirks.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> > index a10b346b9777..96951104c45b 100644
> > --- a/drivers/usb/core/quirks.c
> > +++ b/drivers/usb/core/quirks.c
> > @@ -197,6 +197,9 @@ static const struct usb_device_id usb_quirk_list[] = {
> > { USB_DEVICE(0x0b05, 0x17e0), .driver_info =
> > USB_QUIRK_IGNORE_REMOTE_WAKEUP },
> >
> > + /* QCA Rome Bluetooth in Dell DW1820 wireless module */
> > + { USB_DEVICE(0x0cf3, 0xe007), .driver_info = USB_QUIRK_RESET_RESUME },
> > +
>
> can I get an ACK from you to take this patch through bluetooth-next tree? Or are you planning to take it?
It's not in my queue at all, so I didn't even have the chance to take it
:)
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread* [2/2] usb: quirks: Add reset-resume quirk for Dell DW1820 QCA Rome Bluetooth
@ 2017-12-28 20:15 Marcel Holtmann
0 siblings, 0 replies; 5+ messages in thread
From: Marcel Holtmann @ 2017-12-28 20:15 UTC (permalink / raw)
To: Kai-Heng Feng
Cc: Greg Kroah-Hartman, linux-usb, open list:BLUETOOTH DRIVERS,
Linux Kernel Mailing List, stable, Leif Liddy, Matthias Kaehlcke,
Brian Norris, Daniel Drake
Hi Kai-Heng,
> Commit ("fd865802c66bc451dc515ed89360f84376ce1a56 Bluetooth: btusb: fix
> QCA Rome suspend/resume") enables reset_resume in btusb_probe(). This
> makes the device resets during btusb_open(), firmware loading gets
> interrupted as a result.
>
> We still want to reset the device to solve the original issue, but we
> should do it before btusb_open().
>
> Hence, add reset-resume quirk in usb core intead of btusb.
>
> Cc: stable@vger.kernel.org
> Cc: Leif Liddy <leif.linux@gmail.com>
> Cc: Matthias Kaehlcke <mka@chromium.org>
> Cc: Brian Norris <briannorris@chromium.org>
> Cc: Daniel Drake <drake@endlessm.com>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>
> ---
> drivers/usb/core/quirks.c | 3 +++
> 1 file changed, 3 insertions(+)
patch has been applied to bluetooth-next tree.
Regards
Marcel
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread* [2/2] usb: quirks: Add reset-resume quirk for Dell DW1820 QCA Rome Bluetooth
@ 2017-12-28 11:59 Leif Liddy
0 siblings, 0 replies; 5+ messages in thread
From: Leif Liddy @ 2017-12-28 11:59 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Marcel Holtmann, Kai-Heng Feng, linux-usb,
open list:BLUETOOTH DRIVERS, Linux Kernel Mailing List, stable,
Matthias Kaehlcke, Brian Norris, Daniel Drake
Perhaps targeting all QCA Rome chipsets in the original patch was a
bit overkill.
I'll try adding the quirk USB_QUIRK_RESET_RESUME for my device
(0cf3:e300) in usb core and will report back.
-Leif Liddy
https://bugzilla.kernel.org/show_bug.cgi?id=193571
On Wed, Dec 27, 2017 at 1:52 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Tue, Dec 26, 2017 at 10:01:46PM +0100, Marcel Holtmann wrote:
>> Hi Greg,
>>
>> > Commit ("fd865802c66bc451dc515ed89360f84376ce1a56 Bluetooth: btusb: fix
>> > QCA Rome suspend/resume") enables reset_resume in btusb_probe(). This
>> > makes the device resets during btusb_open(), firmware loading gets
>> > interrupted as a result.
>> >
>> > We still want to reset the device to solve the original issue, but we
>> > should do it before btusb_open().
>> >
>> > Hence, add reset-resume quirk in usb core intead of btusb.
>> >
>> > Cc: stable@vger.kernel.org
>> > Cc: Leif Liddy <leif.linux@gmail.com>
>> > Cc: Matthias Kaehlcke <mka@chromium.org>
>> > Cc: Brian Norris <briannorris@chromium.org>
>> > Cc: Daniel Drake <drake@endlessm.com>
>> > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>> >
>> > ---
>> > drivers/usb/core/quirks.c | 3 +++
>> > 1 file changed, 3 insertions(+)
>> >
>> > diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
>> > index a10b346b9777..96951104c45b 100644
>> > --- a/drivers/usb/core/quirks.c
>> > +++ b/drivers/usb/core/quirks.c
>> > @@ -197,6 +197,9 @@ static const struct usb_device_id usb_quirk_list[] = {
>> > { USB_DEVICE(0x0b05, 0x17e0), .driver_info =
>> > USB_QUIRK_IGNORE_REMOTE_WAKEUP },
>> >
>> > + /* QCA Rome Bluetooth in Dell DW1820 wireless module */
>> > + { USB_DEVICE(0x0cf3, 0xe007), .driver_info = USB_QUIRK_RESET_RESUME },
>> > +
>>
>> can I get an ACK from you to take this patch through bluetooth-next tree? Or are you planning to take it?
>
> It's not in my queue at all, so I didn't even have the chance to take it
> :)
>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread* [2/2] usb: quirks: Add reset-resume quirk for Dell DW1820 QCA Rome Bluetooth
@ 2017-12-26 21:01 Marcel Holtmann
0 siblings, 0 replies; 5+ messages in thread
From: Marcel Holtmann @ 2017-12-26 21:01 UTC (permalink / raw)
To: Kai-Heng Feng, Greg Kroah-Hartman
Cc: linux-usb, open list:BLUETOOTH DRIVERS, Linux Kernel Mailing List,
stable, Leif Liddy, Matthias Kaehlcke, Brian Norris, Daniel Drake
Hi Greg,
> Commit ("fd865802c66bc451dc515ed89360f84376ce1a56 Bluetooth: btusb: fix
> QCA Rome suspend/resume") enables reset_resume in btusb_probe(). This
> makes the device resets during btusb_open(), firmware loading gets
> interrupted as a result.
>
> We still want to reset the device to solve the original issue, but we
> should do it before btusb_open().
>
> Hence, add reset-resume quirk in usb core intead of btusb.
>
> Cc: stable@vger.kernel.org
> Cc: Leif Liddy <leif.linux@gmail.com>
> Cc: Matthias Kaehlcke <mka@chromium.org>
> Cc: Brian Norris <briannorris@chromium.org>
> Cc: Daniel Drake <drake@endlessm.com>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>
> ---
> drivers/usb/core/quirks.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index a10b346b9777..96951104c45b 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -197,6 +197,9 @@ static const struct usb_device_id usb_quirk_list[] = {
> { USB_DEVICE(0x0b05, 0x17e0), .driver_info =
> USB_QUIRK_IGNORE_REMOTE_WAKEUP },
>
> + /* QCA Rome Bluetooth in Dell DW1820 wireless module */
> + { USB_DEVICE(0x0cf3, 0xe007), .driver_info = USB_QUIRK_RESET_RESUME },
> +
can I get an ACK from you to take this patch through bluetooth-next tree? Or are you planning to take it?
Regards
Marcel
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread* [2/2] usb: quirks: Add reset-resume quirk for Dell DW1820 QCA Rome Bluetooth
@ 2017-12-20 11:00 Kai-Heng Feng
0 siblings, 0 replies; 5+ messages in thread
From: Kai-Heng Feng @ 2017-12-20 11:00 UTC (permalink / raw)
To: gregkh, marcel
Cc: linux-usb, linux-bluetooth, linux-kernel, Kai-Heng Feng, stable,
Leif Liddy, Matthias Kaehlcke, Brian Norris, Daniel Drake
Commit ("fd865802c66bc451dc515ed89360f84376ce1a56 Bluetooth: btusb: fix
QCA Rome suspend/resume") enables reset_resume in btusb_probe(). This
makes the device resets during btusb_open(), firmware loading gets
interrupted as a result.
We still want to reset the device to solve the original issue, but we
should do it before btusb_open().
Hence, add reset-resume quirk in usb core intead of btusb.
Cc: stable@vger.kernel.org
Cc: Leif Liddy <leif.linux@gmail.com>
Cc: Matthias Kaehlcke <mka@chromium.org>
Cc: Brian Norris <briannorris@chromium.org>
Cc: Daniel Drake <drake@endlessm.com>
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
drivers/usb/core/quirks.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index a10b346b9777..96951104c45b 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -197,6 +197,9 @@ static const struct usb_device_id usb_quirk_list[] = {
{ USB_DEVICE(0x0b05, 0x17e0), .driver_info =
USB_QUIRK_IGNORE_REMOTE_WAKEUP },
+ /* QCA Rome Bluetooth in Dell DW1820 wireless module */
+ { USB_DEVICE(0x0cf3, 0xe007), .driver_info = USB_QUIRK_RESET_RESUME },
+
/* Action Semiconductor flash disk */
{ USB_DEVICE(0x10d6, 0x2200), .driver_info =
USB_QUIRK_STRING_FETCH_255 },
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-12-28 20:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-27 12:52 [2/2] usb: quirks: Add reset-resume quirk for Dell DW1820 QCA Rome Bluetooth Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2017-12-28 20:15 Marcel Holtmann
2017-12-28 11:59 Leif Liddy
2017-12-26 21:01 Marcel Holtmann
2017-12-20 11:00 Kai-Heng Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).