From: Johan Hovold <johan@kernel.org>
To: Mikhail Zaytsev <flashed@mail.ru>
Cc: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [v2,2/2] USB: serial: ark3116: Move TIOCGSERIAL ioctl case to function.
Date: Tue, 9 Jan 2018 12:57:48 +0100 [thread overview]
Message-ID: <20180109115748.GT11344@localhost> (raw)
On Sat, Jan 06, 2018 at 08:15:22PM +0300, Mikhail Zaytsev wrote:
> The patch moves TIOCGSERIAL ioctl case to get_serial_info function.
>
> Signed-off-by: Mikhail Zaytsev <flashed@mail.ru>
> static int ark3116_ioctl(struct tty_struct *tty,
> unsigned int cmd, unsigned long arg)
> {
> struct usb_serial_port *port = tty->driver_data;
> - struct serial_struct serstruct;
> - void __user *user_arg = (void __user *)arg;
I prefer keeping this pointer here to avoid adding casts to every helper
function call, so I added it back before applying.
>
> switch (cmd) {
> case TIOCGSERIAL:
> + return ark3116_get_serial_info(port,
> + (struct serial_struct __user *)arg);
Thanks,
Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2018-01-09 11:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 11:57 Johan Hovold [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-01-06 17:15 [v2,2/2] USB: serial: ark3116: Move TIOCGSERIAL ioctl case to function Mikhail Zaytsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180109115748.GT11344@localhost \
--to=johan@kernel.org \
--cc=flashed@mail.ru \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).