Help needed debugging Motorola Solutions TETRA PEI interface

[Johan Hovold <johan@kernel.org>]

Please keep linux-usb on CC.

On Wed, Jan 10, 2018 at 10:01:40AM +0100, Max Schulze wrote:
> 
> > Yeah, that's not a CDC device so usb-serial is the right subsystem for
> > this one.
> >
> >>> Yeah, this is expected since you will not be able to do modem control
> >>> when using the generic driver.
> >>>
> >> Strange enough - after said "sudo modprobe usbserial vendor=0x0cad
> >> product=0x9011"
> >> I can connect to the ttyUSB0 and ttyUSB1 with minicom instead of
> >> miniterm.py (which indeed sems broken) - and it works! I get the AT
> >> command set I expect.
> > That's good to hear. Are both ports usable?
> Yes, both working fine.
> >
> >> So I guess for the time being leave it here - unsupported but somehow
> >> working with the usbserial generic driver?
> > We should still add your device's id to some driver, so you don't have
> > to manually add it every time you want to use it.

> Any idea to which? I have no clue.

I'd say the option (modem) driver appears to be the best fit (for now)
if the device is indeed using standard CDC requests, even though it's a
bit of an overkill for these data rates.

Can you verify that the device works with the below patch, including
changing the modem control signals like your python script did?

> > What kind of device is this?
> >
> It is a Radio Terminal. Via the text-based AT commands you can get
> Information about current calls, or send sms-like text messages.
> (
> http://www.etsi.org/deliver/etsi_en/300300_300399/30039205/02.02.00_40/en_30039205v020200o.pdf
> )

Thanks for the pointer.

Johan


>From 452b750ef1d5b0ec171f65da75309b634a9cb2e7 Mon Sep 17 00:00:00 2001
From: Johan Hovold <johan@kernel.org>
Date: Wed, 10 Jan 2018 12:53:09 +0100
Subject: [PATCH] USB: serial: option: add id for Motorola Solutions TETRA PEI

Add device id for Motorola Solutions TETRA PEI.

D:  Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
P:  Vendor=0cad ProdID=9011 Rev=24.16
S:  Manufacturer=Motorola Solutions Inc.
S:  Product=Motorola Solutions TETRA PEI interface
C:  #Ifs= 2 Cfg#= 1 Atr=80 MxPwr=500mA
I:  If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none)
I:  If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none)

Reported-by: Max Schulze <max.schulze@posteo.de>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/usb/serial/option.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index b6320e3be429..b1e2533d19ce 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -2054,6 +2054,7 @@ static const struct usb_device_id option_ids[] = {
 	{ USB_DEVICE_AND_INTERFACE_INFO(WETELECOM_VENDOR_ID, WETELECOM_PRODUCT_6802, 0xff, 0xff, 0xff) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(WETELECOM_VENDOR_ID, WETELECOM_PRODUCT_WMD300, 0xff, 0xff, 0xff) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(0x03f0, 0x421d, 0xff, 0xff, 0xff) }, /* HP lt2523 (Novatel E371) */
+	{ USB_DEVICE(0x0cad, 0x9011) },	/* Motorola Solutions TETRA PEI */
 	{ } /* Terminating entry */
 };
 MODULE_DEVICE_TABLE(usb, option_ids);