* [RFC,1/3] usb: chipidea: usbmisc: evdo is only specific to OTG port
@ 2018-01-13 15:41 Michael Trimarchi
0 siblings, 0 replies; 2+ messages in thread
From: Michael Trimarchi @ 2018-01-13 15:41 UTC (permalink / raw)
To: Peter Chen; +Cc: linux-usb, Greg Kroah-Hartman, michael
The USB_PHY_CTRL_FUNC is used specific for OTG port as described
in user manual. EVDO need to be set only for index 0 that
corrispond to OTG port
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
---
drivers/usb/chipidea/usbmisc_imx.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c
index 8cdf0af1..a52f5a8 100644
--- a/drivers/usb/chipidea/usbmisc_imx.c
+++ b/drivers/usb/chipidea/usbmisc_imx.c
@@ -148,6 +148,9 @@ static int usbmisc_imx25_post(struct imx_usbmisc_data *data)
if (data->index > 2)
return -EINVAL;
+ if (data->index)
+ return 0;
+
if (data->evdo) {
spin_lock_irqsave(&usbmisc->lock, flags);
reg = usbmisc->base + MX25_USB_PHY_CTRL_OFFSET;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [RFC,1/3] usb: chipidea: usbmisc: evdo is only specific to OTG port
@ 2018-01-15 3:05 Peter Chen
0 siblings, 0 replies; 2+ messages in thread
From: Peter Chen @ 2018-01-15 3:05 UTC (permalink / raw)
To: Michael Trimarchi; +Cc: Peter Chen, linux-usb, Greg Kroah-Hartman
On Sat, Jan 13, 2018 at 04:41:46PM +0100, Michael Trimarchi wrote:
> The USB_PHY_CTRL_FUNC is used specific for OTG port as described
> in user manual. EVDO need to be set only for index 0 that
> corrispond to OTG port
%s/corrispond/correspond/
>
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> ---
> drivers/usb/chipidea/usbmisc_imx.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c
> index 8cdf0af1..a52f5a8 100644
> --- a/drivers/usb/chipidea/usbmisc_imx.c
> +++ b/drivers/usb/chipidea/usbmisc_imx.c
> @@ -148,6 +148,9 @@ static int usbmisc_imx25_post(struct imx_usbmisc_data *data)
> if (data->index > 2)
> return -EINVAL;
>
> + if (data->index)
> + return 0;
> +
> if (data->evdo) {
> spin_lock_irqsave(&usbmisc->lock, flags);
> reg = usbmisc->base + MX25_USB_PHY_CTRL_OFFSET;
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-15 3:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-15 3:05 [RFC,1/3] usb: chipidea: usbmisc: evdo is only specific to OTG port Peter Chen
-- strict thread matches above, loose matches on Subject: below --
2018-01-13 15:41 Michael Trimarchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).