* [v2] usb: ehci-omap: don't complain on -EPROBE_DEFER when no PHY found
@ 2018-01-17 10:08 Ladislav Michl
0 siblings, 0 replies; 3+ messages in thread
From: Ladislav Michl @ 2018-01-17 10:08 UTC (permalink / raw)
To: linux-usb, linux-omap; +Cc: Alan Stern, Greg Kroah-Hartman
Don't complain on -EPROBE_DEFER when when no PHY found, the driver
probe will be retried later.
Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
Acked-by: Tony Lindgren <tony@atomide.com>
---
Changes:
- v2: None, just added Tony's ack
drivers/usb/host/ehci-omap.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
index 854b146a457d..fd6170962a1a 100644
--- a/drivers/usb/host/ehci-omap.c
+++ b/drivers/usb/host/ehci-omap.c
@@ -167,8 +167,9 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
continue;
ret = PTR_ERR(phy);
- dev_err(dev, "Can't get PHY device for port %d: %d\n",
- i, ret);
+ if (ret != -EPROBE_DEFER)
+ dev_err(dev, "Can't get PHY device for port "
+ "%d: %d\n", i, ret);
goto err_phy;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [v2] usb: ehci-omap: don't complain on -EPROBE_DEFER when no PHY found
@ 2018-01-17 13:41 Roger Quadros
0 siblings, 0 replies; 3+ messages in thread
From: Roger Quadros @ 2018-01-17 13:41 UTC (permalink / raw)
To: Ladislav Michl, linux-usb, linux-omap; +Cc: Alan Stern, Greg Kroah-Hartman
On 17/01/18 12:08, Ladislav Michl wrote:
> Don't complain on -EPROBE_DEFER when when no PHY found, the driver
> probe will be retried later.
>
> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> Acked-by: Tony Lindgren <tony@atomide.com>
Acked-by: Roger Quadros <rogerq@ti.com>
> ---
> Changes:
> - v2: None, just added Tony's ack
>
> drivers/usb/host/ehci-omap.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
> index 854b146a457d..fd6170962a1a 100644
> --- a/drivers/usb/host/ehci-omap.c
> +++ b/drivers/usb/host/ehci-omap.c
> @@ -167,8 +167,9 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
> continue;
>
> ret = PTR_ERR(phy);
> - dev_err(dev, "Can't get PHY device for port %d: %d\n",
> - i, ret);
> + if (ret != -EPROBE_DEFER)
> + dev_err(dev, "Can't get PHY device for port "
> + "%d: %d\n", i, ret);
> goto err_phy;
> }
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [v2] usb: ehci-omap: don't complain on -EPROBE_DEFER when no PHY found
@ 2018-01-18 0:44 Jaejoong Kim
0 siblings, 0 replies; 3+ messages in thread
From: Jaejoong Kim @ 2018-01-18 0:44 UTC (permalink / raw)
To: Roger Quadros
Cc: Ladislav Michl, USB list, linux-omap, Alan Stern,
Greg Kroah-Hartman
In you commit message, there is a typo "when when"
2018-01-17 22:41 GMT+09:00 Roger Quadros <rogerq@ti.com>:
> On 17/01/18 12:08, Ladislav Michl wrote:
>> Don't complain on -EPROBE_DEFER when when no PHY found, the driver
^^^^^^^^^^^^
thanks,
jaejoong
>> probe will be retried later.
>>
>> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
>> Acked-by: Tony Lindgren <tony@atomide.com>
>
> Acked-by: Roger Quadros <rogerq@ti.com>
>
>> ---
>> Changes:
>> - v2: None, just added Tony's ack
>>
>> drivers/usb/host/ehci-omap.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
>> index 854b146a457d..fd6170962a1a 100644
>> --- a/drivers/usb/host/ehci-omap.c
>> +++ b/drivers/usb/host/ehci-omap.c
>> @@ -167,8 +167,9 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
>> continue;
>>
>> ret = PTR_ERR(phy);
>> - dev_err(dev, "Can't get PHY device for port %d: %d\n",
>> - i, ret);
>> + if (ret != -EPROBE_DEFER)
>> + dev_err(dev, "Can't get PHY device for port "
>> + "%d: %d\n", i, ret);
>> goto err_phy;
>> }
>>
>>
>
> --
> cheers,
> -roger
>
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-18 0:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-17 10:08 [v2] usb: ehci-omap: don't complain on -EPROBE_DEFER when no PHY found Ladislav Michl
-- strict thread matches above, loose matches on Subject: below --
2018-01-17 13:41 Roger Quadros
2018-01-18 0:44 Jaejoong Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).