From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "David R. Bild" <david.bild@xaptum.com>
Cc: linux-usb@vger.kernel.org
Subject: [1/2] usb: misc: xapea00x: add driver for Xaptum ENF Access Card
Date: Mon, 22 Jan 2018 15:28:53 +0100 [thread overview]
Message-ID: <20180122142853.GA13132@kroah.com> (raw)
On Wed, Jan 10, 2018 at 10:58:29AM -0600, David R. Bild wrote:
> +/**
> + * xapea00x_spi_cleanup
> + *
> + * Context: !in_interrupt()
> + */
No need to have kerneldoc formatting for static functions, nor the whole
Context thing, but it's your code to maintain over time, not mine :)
> +static void xapea00x_spi_cleanup(struct spi_device *spi)
> +{
> + dev_dbg(&spi->dev, "%s\n", __func__);
> +}
Why? Why is this function here at all?
And don't use dev_dbg() for function calls, that's what ftrace is for.
Shouldn't you be actually cleaning up some memory or reference count
here?
thanks,
greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2018-01-22 14:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 14:28 Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-01-25 16:43 [1/2] usb: misc: xapea00x: add driver for Xaptum ENF Access Card David R. Bild
2018-01-25 16:34 David R. Bild
2018-01-22 15:15 Greg Kroah-Hartman
2018-01-22 15:07 David R. Bild
2018-01-11 10:27 Oliver Neukum
2018-01-10 16:58 David R. Bild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180122142853.GA13132@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=david.bild@xaptum.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).