linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Kristian Evensen <kristian.evensen@gmail.com>
Cc: linux-usb@vger.kernel.org
Subject: option: Add support for Quectel EP06
Date: Wed, 31 Jan 2018 17:38:15 +1100	[thread overview]
Message-ID: <20180131063815.GG3434@localhost> (raw)

On Tue, Jan 30, 2018 at 03:06:38PM +0100, Kristian Evensen wrote:
> The Quectel EP06 is a Cat. 6 LTE modem, and the interface mapping is as
> follows:
> 
> 0: Diag
> 1: NMEA
> 2: AT
> 3: Modem
> 
> Interface 4 is QMI and interface 5 is ADB, so they are blacklisted.
> 
> Signed-off-by: Kristian Evensen <kristian.evensen@gmail.com>
> ---
>  drivers/usb/serial/option.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index b6320e3be429..2d53e14ff93b 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -241,6 +241,7 @@ static void option_instat_callback(struct urb *urb);
>  #define QUECTEL_PRODUCT_EC21			0x0121
>  #define QUECTEL_PRODUCT_EC25			0x0125
>  #define QUECTEL_PRODUCT_BG96			0x0296
> +#define QUECTEL_PRODUCT_EP06			0x0306
>  
>  #define CMOTECH_VENDOR_ID			0x16d8
>  #define CMOTECH_PRODUCT_6001			0x6001
> @@ -686,6 +687,10 @@ static const struct option_blacklist_info yuga_clm920_nc5_blacklist = {
>  	.reserved = BIT(1) | BIT(4),
>  };
>  
> +static const struct option_blacklist_info quectel_ep06_blacklist = {
> +	.reserved = BIT(4) | BIT(5),
> +};

This will probably have to do for now, but we already have another
blacklist struct with the same content which we could rename and
reuse.

Can you please just fix up the commit-summary prefix (use "USB: serial:
option: ...") and resend as a v2?

Thanks,
Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2018-01-31  6:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-31  6:38 Johan Hovold [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-02-09  5:56 option: Add support for Quectel EP06 Johan Hovold
2018-02-04 18:24 Bjørn Mork
2018-02-04  1:42 Johan Hovold
2018-01-31 22:35 Dan Williams
2018-01-31 22:32 Dan Williams
2018-01-31 22:17 Johan Hovold
2018-01-31  8:56 Kristian Evensen
2018-01-30 14:06 Kristian Evensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180131063815.GG3434@localhost \
    --to=johan@kernel.org \
    --cc=kristian.evensen@gmail.com \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).