From: Johan Hovold <johan@kernel.org>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: Johan Hovold <johan@kernel.org>, Dan Williams <dcbw@redhat.com>,
Kristian Evensen <kristian.evensen@gmail.com>,
linux-usb@vger.kernel.org
Subject: option: Add support for Quectel EP06
Date: Fri, 9 Feb 2018 16:56:08 +1100 [thread overview]
Message-ID: <20180209055608.GH28684@localhost> (raw)
On Sun, Feb 04, 2018 at 07:24:22PM +0100, Bjørn Mork wrote:
> Johan Hovold <johan@kernel.org> writes:
> >> IIRC I considered just dumping the BIT(x) into the .driver_info but
> >> then we'd only have 16 bits for each of send_setup and reserved on 32-
> >> bit arches and I wasn't sure that was enough. I've seen some devices
> >> with lots of interfaces. But doing it this way might have been clearer
> >> than a sidecar struct like option_blacklist_info.
> >
> > Yeah, we should probably consider moving over to something like that.
> > 16 bits would at least be enough for the devices we currently have
> > blacklists for.
>
> Yes, I think the current driver documents pretty well that we don't need
> backlists for high interface numbers.
>
> Checking the devices I have ever used, the only ones I found with
> interface numbers higher than 16 were the Sierra Wireless modems of the
> MDM9200/MDM9600 generation. THe used 19 and 20 for two of their
> QMI/RMNET functions. But they are handled by the qcserial driver, so
> that's not an issue wrt option.
>
> I say go for the simple bitmasks!
Great, thanks for the feedback.
> You might also consider a general blacklist for stuff like ADB which
> always need blacklisting. By now, Google owns ff/42/xx whether you like
> it or not.
Good point.
I won't be able to look at this for another few weeks myself, but will
try to come with some fairly compact notation for this unless someone
beats me to it.
Thanks,
Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2018-02-09 5:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 5:56 Johan Hovold [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-02-04 18:24 option: Add support for Quectel EP06 Bjørn Mork
2018-02-04 1:42 Johan Hovold
2018-01-31 22:35 Dan Williams
2018-01-31 22:32 Dan Williams
2018-01-31 22:17 Johan Hovold
2018-01-31 8:56 Kristian Evensen
2018-01-31 6:38 Johan Hovold
2018-01-30 14:06 Kristian Evensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180209055608.GH28684@localhost \
--to=johan@kernel.org \
--cc=bjorn@mork.no \
--cc=dcbw@redhat.com \
--cc=kristian.evensen@gmail.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).