* [1/2] usb: Move USB_UHCI_BIG_ENDIAN_* out of USB_SUPPORT
@ 2018-01-31 22:24 James Hogan
0 siblings, 0 replies; 5+ messages in thread
From: James Hogan @ 2018-01-31 22:24 UTC (permalink / raw)
To: Greg Kroah-Hartman, David S. Miller
Cc: linux-mips, Paul Burton, Ralf Baechle, James Hogan,
Corentin Labbe, linux-usb
Move the Kconfig symbols USB_UHCI_BIG_ENDIAN_MMIO and
USB_UHCI_BIG_ENDIAN_DESC out of drivers/usb/host/Kconfig, which is
conditional upon USB && USB_SUPPORT, so that it can be freely selected
by platform Kconfig symbols in architecture code.
For example once the MIPS_GENERIC platform selects are fixed in the
patch "MIPS: Fix typo BIG_ENDIAN to CPU_BIG_ENDIAN", the MIPS
32r6_defconfig warns like so:
warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies (USB_SUPPORT && USB)
warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_DESC which has unmet direct dependencies (USB_SUPPORT && USB)
Signed-off-by: James Hogan <jhogan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: linux-usb@vger.kernel.org
---
drivers/usb/Kconfig | 8 ++++++++
drivers/usb/host/Kconfig | 8 --------
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
index f699abab1787..65812a2f60b4 100644
--- a/drivers/usb/Kconfig
+++ b/drivers/usb/Kconfig
@@ -19,6 +19,14 @@ config USB_EHCI_BIG_ENDIAN_MMIO
config USB_EHCI_BIG_ENDIAN_DESC
bool
+config USB_UHCI_BIG_ENDIAN_MMIO
+ bool
+ default y if SPARC_LEON
+
+config USB_UHCI_BIG_ENDIAN_DESC
+ bool
+ default y if SPARC_LEON
+
menuconfig USB_SUPPORT
bool "USB support"
depends on HAS_IOMEM
diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index b80a94e632af..2763a640359f 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -625,14 +625,6 @@ config USB_UHCI_ASPEED
bool
default y if ARCH_ASPEED
-config USB_UHCI_BIG_ENDIAN_MMIO
- bool
- default y if SPARC_LEON
-
-config USB_UHCI_BIG_ENDIAN_DESC
- bool
- default y if SPARC_LEON
-
config USB_FHCI_HCD
tristate "Freescale QE USB Host Controller support"
depends on OF_GPIO && QE_GPIO && QUICC_ENGINE
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [1/2] usb: Move USB_UHCI_BIG_ENDIAN_* out of USB_SUPPORT
@ 2018-02-15 17:42 Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2018-02-15 17:42 UTC (permalink / raw)
To: James Hogan
Cc: David S. Miller, linux-mips, Paul Burton, Ralf Baechle,
Corentin Labbe, linux-usb
On Wed, Jan 31, 2018 at 10:24:45PM +0000, James Hogan wrote:
> Move the Kconfig symbols USB_UHCI_BIG_ENDIAN_MMIO and
> USB_UHCI_BIG_ENDIAN_DESC out of drivers/usb/host/Kconfig, which is
> conditional upon USB && USB_SUPPORT, so that it can be freely selected
> by platform Kconfig symbols in architecture code.
>
> For example once the MIPS_GENERIC platform selects are fixed in the
> patch "MIPS: Fix typo BIG_ENDIAN to CPU_BIG_ENDIAN", the MIPS
> 32r6_defconfig warns like so:
>
> warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies (USB_SUPPORT && USB)
> warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_DESC which has unmet direct dependencies (USB_SUPPORT && USB)
>
> Signed-off-by: James Hogan <jhogan@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Corentin Labbe <clabbe.montjoie@gmail.com>
> Cc: linux-usb@vger.kernel.org
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* [1/2] usb: Move USB_UHCI_BIG_ENDIAN_* out of USB_SUPPORT
@ 2018-02-15 21:38 James Hogan
0 siblings, 0 replies; 5+ messages in thread
From: James Hogan @ 2018-02-15 21:38 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: David S. Miller, linux-mips, Paul Burton, Ralf Baechle,
Corentin Labbe, linux-usb
On Thu, Feb 15, 2018 at 06:42:03PM +0100, Greg Kroah-Hartman wrote:
> On Wed, Jan 31, 2018 at 10:24:45PM +0000, James Hogan wrote:
> > Move the Kconfig symbols USB_UHCI_BIG_ENDIAN_MMIO and
> > USB_UHCI_BIG_ENDIAN_DESC out of drivers/usb/host/Kconfig, which is
> > conditional upon USB && USB_SUPPORT, so that it can be freely selected
> > by platform Kconfig symbols in architecture code.
> >
> > For example once the MIPS_GENERIC platform selects are fixed in the
> > patch "MIPS: Fix typo BIG_ENDIAN to CPU_BIG_ENDIAN", the MIPS
> > 32r6_defconfig warns like so:
> >
> > warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies (USB_SUPPORT && USB)
> > warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_DESC which has unmet direct dependencies (USB_SUPPORT && USB)
> >
> > Signed-off-by: James Hogan <jhogan@kernel.org>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Corentin Labbe <clabbe.montjoie@gmail.com>
> > Cc: linux-usb@vger.kernel.org
>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Thanks, I'll apply this as a MIPS fix for 4.16.
Okay to leave patch 2 for you to deal with Greg since it doesn't really
directly affect MIPS nor is it important for 4.16?
Cheers
James
^ permalink raw reply [flat|nested] 5+ messages in thread
* [1/2] usb: Move USB_UHCI_BIG_ENDIAN_* out of USB_SUPPORT
@ 2018-02-15 21:41 Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2018-02-15 21:41 UTC (permalink / raw)
To: James Hogan
Cc: David S. Miller, linux-mips, Paul Burton, Ralf Baechle,
Corentin Labbe, linux-usb
On Thu, Feb 15, 2018 at 09:38:48PM +0000, James Hogan wrote:
> On Thu, Feb 15, 2018 at 06:42:03PM +0100, Greg Kroah-Hartman wrote:
> > On Wed, Jan 31, 2018 at 10:24:45PM +0000, James Hogan wrote:
> > > Move the Kconfig symbols USB_UHCI_BIG_ENDIAN_MMIO and
> > > USB_UHCI_BIG_ENDIAN_DESC out of drivers/usb/host/Kconfig, which is
> > > conditional upon USB && USB_SUPPORT, so that it can be freely selected
> > > by platform Kconfig symbols in architecture code.
> > >
> > > For example once the MIPS_GENERIC platform selects are fixed in the
> > > patch "MIPS: Fix typo BIG_ENDIAN to CPU_BIG_ENDIAN", the MIPS
> > > 32r6_defconfig warns like so:
> > >
> > > warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies (USB_SUPPORT && USB)
> > > warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_DESC which has unmet direct dependencies (USB_SUPPORT && USB)
> > >
> > > Signed-off-by: James Hogan <jhogan@kernel.org>
> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Cc: Corentin Labbe <clabbe.montjoie@gmail.com>
> > > Cc: linux-usb@vger.kernel.org
> >
> > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Thanks, I'll apply this as a MIPS fix for 4.16.
>
> Okay to leave patch 2 for you to deal with Greg since it doesn't really
> directly affect MIPS nor is it important for 4.16?
Just take both of them and be done with it :)
thanks,
greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* [1/2] usb: Move USB_UHCI_BIG_ENDIAN_* out of USB_SUPPORT
@ 2018-02-15 21:42 James Hogan
0 siblings, 0 replies; 5+ messages in thread
From: James Hogan @ 2018-02-15 21:42 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: David S. Miller, linux-mips, Paul Burton, Ralf Baechle,
Corentin Labbe, linux-usb
On Thu, Feb 15, 2018 at 10:41:42PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Feb 15, 2018 at 09:38:48PM +0000, James Hogan wrote:
> > On Thu, Feb 15, 2018 at 06:42:03PM +0100, Greg Kroah-Hartman wrote:
> > > On Wed, Jan 31, 2018 at 10:24:45PM +0000, James Hogan wrote:
> > > > Move the Kconfig symbols USB_UHCI_BIG_ENDIAN_MMIO and
> > > > USB_UHCI_BIG_ENDIAN_DESC out of drivers/usb/host/Kconfig, which is
> > > > conditional upon USB && USB_SUPPORT, so that it can be freely selected
> > > > by platform Kconfig symbols in architecture code.
> > > >
> > > > For example once the MIPS_GENERIC platform selects are fixed in the
> > > > patch "MIPS: Fix typo BIG_ENDIAN to CPU_BIG_ENDIAN", the MIPS
> > > > 32r6_defconfig warns like so:
> > > >
> > > > warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies (USB_SUPPORT && USB)
> > > > warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_DESC which has unmet direct dependencies (USB_SUPPORT && USB)
> > > >
> > > > Signed-off-by: James Hogan <jhogan@kernel.org>
> > > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > > Cc: Corentin Labbe <clabbe.montjoie@gmail.com>
> > > > Cc: linux-usb@vger.kernel.org
> > >
> > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> > Thanks, I'll apply this as a MIPS fix for 4.16.
> >
> > Okay to leave patch 2 for you to deal with Greg since it doesn't really
> > directly affect MIPS nor is it important for 4.16?
>
> Just take both of them and be done with it :)
Okay,
Thanks
James
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-02-15 21:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-15 21:42 [1/2] usb: Move USB_UHCI_BIG_ENDIAN_* out of USB_SUPPORT James Hogan
-- strict thread matches above, loose matches on Subject: below --
2018-02-15 21:41 Greg Kroah-Hartman
2018-02-15 21:38 James Hogan
2018-02-15 17:42 Greg Kroah-Hartman
2018-01-31 22:24 James Hogan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).