From: Andreas Kemnade <andreas@kemnade.info>
To: Bin Liu <b-liu@ti.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
Discussions about the Letux Kernel <letux-kernel@openphoenux.org>
Subject: usb: musb: fix enumeration after resume
Date: Fri, 16 Feb 2018 08:10:19 +0100 [thread overview]
Message-ID: <20180216081019.2358584f@aktux> (raw)
On Wed, 7 Feb 2018 14:37:00 -0600
Bin Liu <b-liu@ti.com> wrote:
> On Tue, Feb 06, 2018 at 08:00:24PM +0100, Andreas Kemnade wrote:
> > Hi,
> >
> > On Tue, 6 Feb 2018 12:46:05 -0600
> > Bin Liu <b-liu@ti.com> wrote:
> >
> > > Hi,
> > >
> > > On Sat, Jan 27, 2018 at 09:34:03AM +0100, Andreas Kemnade wrote:
> > > > On dm3730 there are enumeration problems after resume.
> > > > Investigation led to the cause that the MUSB_POWER_SOFTCONN
> > > > bit is not set. If it was set before suspend (because it
> > > > was enabled via musb_pullup()), it is set in
> > > > musb_restore_context() so the pullup is enabled. But then
> > > > musb_start() is called which overwrites MUSB_POWER and
> > > > therefore disables MUSB_POWER_SOFTCONN, so no pullup is
> > > > enabled and the device is not enumerated.
> > >
> > > Do you see the issue with the v4.15?
> > >
> > Yes. Tested without other patches.
> > It was also there in earlier kernels but I had not had motivation enough
> > to debug.
>
> Applied to my tree. Thanks.
>
> > So maybe it deserves a CC: Stable
>
> I would prefer it is first tested on each stable tree.
>
Tested with 4.16-rc1 with and without that patch
The problem still exists and can be fixed by that patch.
Regards,
Andreas
next reply other threads:[~2018-02-16 7:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 7:10 Andreas Kemnade [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-02-07 20:37 usb: musb: fix enumeration after resume Bin Liu
2018-02-07 20:32 Bin Liu
2018-02-06 19:09 Andreas Kemnade
2018-02-06 19:00 Andreas Kemnade
2018-02-06 18:47 Tony Lindgren
2018-02-06 18:46 Bin Liu
2018-01-27 8:34 Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180216081019.2358584f@aktux \
--to=andreas@kemnade.info \
--cc=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).