From: Bin Liu <b-liu@ti.com>
To: Merlijn Wajer <merlijn@wizzup.org>
Cc: ivo.g.dimitrov.75@gmail.com, linux-omap@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: usb: musb: Fix external abort in musb_remove
Date: Fri, 9 Mar 2018 07:39:53 -0600 [thread overview]
Message-ID: <20180309133953.GL14921@uda0271908> (raw)
On Thu, Mar 08, 2018 at 11:17:48PM +0100, Merlijn Wajer wrote:
> Hi,
>
> On 08/03/18 22:15, Bin Liu wrote:
>
> > please add patch version numbers in the subject when necessary. This
> > helps cross-referencing.
>
> Will do. I naively assumed that the first patch would implicitly be
> number 1. Will send out v2 now.
Sorry, my bad, I forgot the first patch was a RFC. You are doing it
right.
>
> >>
> >> + musb_writeb(musb->mregs, MUSB_DEVCTL, 0);
> >
> > Does it solve the issue if not moving this line? I'd like to have
> > minimum change if possible.
>
> Yes, it does. The only reason I moved musb_writeb is because I
> understood you wanted me to move both (per previous message: "This can
> be move down to out side of holding the spinlock").
Typically the comments would only applies to the modified code.
Otherwise the comments have to be explicit to avoid confusion.
No worries here anyway, confusion does happen sometimes ;)
Regards,
-Bin.
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2018-03-09 13:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 13:39 Bin Liu [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-03-08 22:17 usb: musb: Fix external abort in musb_remove Merlijn Wajer
2018-03-08 21:18 Bin Liu
2018-03-08 21:15 Bin Liu
2018-03-08 20:40 Merlijn Wajer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180309133953.GL14921@uda0271908 \
--to=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=merlijn@wizzup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).