From: Johan Hovold <johan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Johan Hovold" <johan@kernel.org>,
linux-usb@vger.kernel.org, "Dan Williams" <dcbw@redhat.com>,
"Bjørn Mork" <bjorn@mork.no>
Subject: USB: serial: option: reimplement interface masking
Date: Mon, 12 Mar 2018 11:32:19 +0100 [thread overview]
Message-ID: <20180312103219.GH10477@localhost> (raw)
On Wed, Mar 07, 2018 at 11:54:47AM -0800, Greg Kroah-Hartman wrote:
> On Wed, Mar 07, 2018 at 05:40:48PM +0100, Johan Hovold wrote:
> > Reimplement interface masking using device flags stored directly in the
> > device-id table. This will make it easier to add and maintain device-id
> > entries by using a more compact and readable notation compared to the
> > current implementation (which manages pairs of masks in separate
> > blacklist structs).
> >
> > Two convenience macros are used to flag an interface as either reserved
> > or as not supporting modem-control requests:
> >
> > { USB_DEVICE(TELIT_VENDOR_ID, TELIT_PRODUCT_ME910_DUAL_MODEM),
> > .driver_info = NCTRL(0) | RSVD(3) },
> >
> > For now, we limit the highest maskable interface number to seven, which
> > allows for (up to 16) additional device flags to be added later should
> > need arise.
> >
> > Note that this will likely need to be backported to stable in order to
> > make future device-id backports more manageable.
> >
> > Signed-off-by: Johan Hovold <johan@kernel.org>
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Thanks for the review. Now applied for -next.
Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2018-03-12 10:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 10:32 Johan Hovold [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-03-07 19:54 USB: serial: option: reimplement interface masking Greg Kroah-Hartman
2018-03-07 16:40 Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180312103219.GH10477@localhost \
--to=johan@kernel.org \
--cc=bjorn@mork.no \
--cc=dcbw@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).