From: Greg KH <greg@kroah.com>
To: Daniel Gimpelevich <daniel@gimpelevich.san-francisco.ca.us>
Cc: linux-usb@vger.kernel.org, Rab <reboots@g-cipher.net>
Subject: USB: misc: uss720: more vendor/product ID's
Date: Tue, 20 Mar 2018 09:36:45 +0100 [thread overview]
Message-ID: <20180320083645.GB24206@kroah.com> (raw)
On Wed, Mar 14, 2018 at 03:20:04PM -0700, Daniel Gimpelevich wrote:
> Reporting two more VID/PID pairs that work with this driver, having used
> an informational webpage <http://reboots.g-cipher.net/lcd/> as a buying
> guide now. The page listed additional working VID/PID pairs but did not
> include these two. None were upstreamed. Also taking this opportunity to
> sort the pairs numerically.
>
> Of the two such cables now in my possession, one is white, bearing the
> In-System Design ISD-103 label on one side, sold as an Epson CAEUL0002
> "USB to Parallel Smart Cable For Apple Macintosh Computers" (04b8:0002),
> and the other is black, bearing the In-System Design ISD-101 label on one
> side, sold as an early Belkin F5U002 (05ab:0002).
>
> Signed-off-by: Daniel Gimpelevich <daniel@gimpelevich.san-francisco.ca.us>
> Cc: stable <stable@vger.kernel.org>
> ---
> drivers/usb/misc/uss720.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c
> index 263c97f..a208e4b 100644
> --- a/drivers/usb/misc/uss720.c
> +++ b/drivers/usb/misc/uss720.c
> @@ -769,10 +769,15 @@ static void uss720_disconnect(struct usb_interface *intf)
> /* table of cables that work through this driver */
> static const struct usb_device_id uss720_table[] = {
> { USB_DEVICE(0x047e, 0x1001) },
> + { USB_DEVICE(0x04b8, 0x0002) }, /* Daniel Gimpelevich */
> + { USB_DEVICE(0x04b8, 0x0003) }, /* Added by Rab */
Who is "Rab" and why do you need to name who added what id to the patch?
> + { USB_DEVICE(0x050d, 0x0002) }, /* Fabio Battaglia */
It doesn't say that Fabio added this one below, are you sure?
> + { USB_DEVICE(0x050d, 0x1202) }, /* Added by Rab */
> { USB_DEVICE(0x0557, 0x2001) },
> + { USB_DEVICE(0x05ab, 0x0002) }, /* Daniel Gimpelevich */
> + { USB_DEVICE(0x06c6, 0x0100) }, /* Added by Rab */
> { USB_DEVICE(0x0729, 0x1284) },
> { USB_DEVICE(0x1293, 0x0002) },
> - { USB_DEVICE(0x050d, 0x0002) },
What is more useful is a description of the device types, not who added
the new id, can you do that instead?
thanks,
greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2018-03-20 8:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 8:36 Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-03-20 9:37 USB: misc: uss720: more vendor/product ID's Greg KH
2018-03-20 9:23 Daniel Gimpelevich
2018-03-20 9:21 Greg KH
2018-03-20 9:13 Daniel Gimpelevich
2018-03-20 9:08 Greg KH
2018-03-20 9:03 Daniel Gimpelevich
2018-03-20 8:35 Greg Kroah-Hartman
2018-03-14 22:20 Daniel Gimpelevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180320083645.GB24206@kroah.com \
--to=greg@kroah.com \
--cc=daniel@gimpelevich.san-francisco.ca.us \
--cc=linux-usb@vger.kernel.org \
--cc=reboots@g-cipher.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).