From: Johan Hovold <johan@kernel.org>
To: "Teichmann, Martin" <martin.teichmann@xfel.eu>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Johan Hovold <johan@kernel.org>,
stable@vger.kernel.org, linux-usb <linux-usb@vger.kernel.org>
Subject: Sorry, Patch wrong (was: patch "USB: serial: ftdi_sio: add Id for Physik Instrumente E-870" added to usb-testing)
Date: Thu, 29 Mar 2018 14:39:37 +0200 [thread overview]
Message-ID: <20180329123937.GB16578@localhost> (raw)
On Thu, Mar 29, 2018 at 01:49:02PM +0200, Teichmann, Martin wrote:
> Dear Greg, dear Johan, dear list,
>
> I'm very sorry I was a bit quick in sending you a patch for the PI
> E-870 device, because it's actually wrong. Everything seemed to work
> fine, until I realized that once in a while two characters were
> missing. Checking dmesg I realized error messages had piled up. It
> turns out, the device is not compatible with the ftdi_sio driver in
> the end. I hope this can be undone...
No worries, I just sent a revert patch to Greg.
> The device, however works with a usb-serial-simple driver.
> Unfortunately, it is not as easy as for the E-870 to supply a patch,
> as usb-serial-simple does not just contain a list of VID and PIDs, but
> actually creates a new entry somewhere in /sys/bus for each vendor. I
> would like to send in patch for this later, but this time properly
> tested...
Try first to determine what chip this really is (e.g. by opening the
device). Chances are there's already a driver for it. Full "lsusb -v"
might also give some clues.
Thanks,
Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2018-03-29 12:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 12:39 Johan Hovold [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-03-29 11:49 Sorry, Patch wrong (was: patch "USB: serial: ftdi_sio: add Id for Physik Instrumente E-870" added to usb-testing) Teichmann, Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180329123937.GB16578@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.teichmann@xfel.eu \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).