From: Christoph Hellwig <hch@lst.de>
To: stern@rowland.harvard.edu
Cc: linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net,
linux-scsi@vger.kernel.org
Subject: usb-storage: stop using block layer bounce buffers
Date: Sun, 15 Apr 2018 16:53:29 +0200 [thread overview]
Message-ID: <20180415145329.855-1-hch@lst.de> (raw)
USB host controllers now must handle highmem, so we can get rid of bounce
buffering highmem pages in the block layer.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/usb/storage/scsiglue.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/usb/storage/scsiglue.c b/drivers/usb/storage/scsiglue.c
index c267f2812a04..4e453d9d45d5 100644
--- a/drivers/usb/storage/scsiglue.c
+++ b/drivers/usb/storage/scsiglue.c
@@ -130,15 +130,6 @@ static int slave_configure(struct scsi_device *sdev)
blk_queue_max_hw_sectors(sdev->request_queue, 2048);
}
- /*
- * Some USB host controllers can't do DMA; they have to use PIO.
- * They indicate this by setting their dma_mask to NULL. For
- * such controllers we need to make sure the block layer sets
- * up bounce buffers in addressable memory.
- */
- if (!us->pusb_dev->bus->controller->dma_mask)
- blk_queue_bounce_limit(sdev->request_queue, BLK_BOUNCE_HIGH);
-
/*
* We can't put these settings in slave_alloc() because that gets
* called before the device type is known. Consequently these
next reply other threads:[~2018-04-15 14:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-15 14:53 Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-04-15 15:24 usb-storage: stop using block layer bounce buffers Alan Stern
2018-04-27 5:27 Christoph Hellwig
2018-04-27 14:09 Alan Stern
2018-05-02 12:47 Christoph Hellwig
2018-05-02 14:48 Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180415145329.855-1-hch@lst.de \
--to=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).