From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [09/11] usb: musb: break the huge isr musb_stage0_irq() into small functions From: Dan Carpenter Message-Id: <20180418072534.s7ahaglrkwmviqn3@mwanda> Date: Wed, 18 Apr 2018 10:25:34 +0300 To: kbuild@01.org, Bin Liu Cc: kbuild-all@01.org, linux-usb@vger.kernel.org List-ID: SGkgQmluLAoKSSBsb3ZlIHlvdXIgcGF0Y2ghIFBlcmhhcHMgc29tZXRoaW5nIHRvIGltcHJvdmU6 CgpbYXV0byBidWlsZCB0ZXN0IFdBUk5JTkcgb24gYmFsYmktdXNiL25leHRdClthbHNvIGJ1aWxk IHRlc3QgV0FSTklORyBvbiB2NC4xNy1yYzEgbmV4dC0yMDE4MDQxN10KW2lmIHlvdXIgcGF0Y2gg aXMgYXBwbGllZCB0byB0aGUgd3JvbmcgZ2l0IHRyZWUsIHBsZWFzZSBkcm9wIHVzIGEgbm90ZSB0 byBoZWxwIGltcHJvdmUgdGhlIHN5c3RlbV0KCnVybDogICAgaHR0cHM6Ly9naXRodWIuY29tLzBk YXktY2kvbGludXgvY29tbWl0cy9CaW4tTGl1L3VzYi1tdXNiLWNsZWFudXAvMjAxODA0MTctMTMz NjMzCmJhc2U6ICAgaHR0cHM6Ly9naXQua2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9n aXQvYmFsYmkvdXNiLmdpdCBuZXh0CgpzbWF0Y2ggd2FybmluZ3M6CmRyaXZlcnMvdXNiL211c2Iv bXVzYl9jb3JlLmM6Nzk3IG11c2JfaGFuZGxlX2ludHJfY29ubmVjdCgpIGVycm9yOiB3ZSBwcmV2 aW91c2x5IGFzc3VtZWQgJ211c2ItPmhjZCcgY291bGQgYmUgbnVsbCAoc2VlIGxpbmUgNzgzKQoK IyBodHRwczovL2dpdGh1Yi5jb20vMGRheS1jaS9saW51eC9jb21taXQvOTJiZTc1YjRmYjc5MTcz NzU5YWY0MmU1MGE4MWQwMDIwZTk0NWMxZQpnaXQgcmVtb3RlIGFkZCBsaW51eC1yZXZpZXcgaHR0 cHM6Ly9naXRodWIuY29tLzBkYXktY2kvbGludXgKZ2l0IHJlbW90ZSB1cGRhdGUgbGludXgtcmV2 aWV3CmdpdCBjaGVja291dCA5MmJlNzViNGZiNzkxNzM3NTlhZjQyZTUwYTgxZDAwMjBlOTQ1YzFl CnZpbSArNzk3IGRyaXZlcnMvdXNiL211c2IvbXVzYl9jb3JlLmMKCjFjMjVmZGE0YSBBcm5hdWQg TWFuZHkgICAgICAgICAgICAgIDIwMDktMTItMjggIDc0NSAgCjkyYmU3NWI0ZiBCaW4gTGl1ICAg ICAgICAgICAgICAgICAgIDIwMTgtMDQtMTYgIDc0NiAgc3RhdGljIHZvaWQgbXVzYl9oYW5kbGVf aW50cl9jb25uZWN0KHN0cnVjdCBtdXNiICptdXNiLCB1OCBkZXZjdGwsIHU4IGludF91c2IpCjky YmU3NWI0ZiBCaW4gTGl1ICAgICAgICAgICAgICAgICAgIDIwMTgtMDQtMTYgIDc0NyAgewo4YjEy NWRmNWIgRGFuaWVsIE1hY2sgICAgICAgICAgICAgICAyMDEzLTA0LTEwICA3NDggIAlzdHJ1Y3Qg dXNiX2hjZCAqaGNkID0gbXVzYi0+aGNkOwo1NTBhNzM3NWYgRmVsaXBlIEJhbGJpICAgICAgICAg ICAgICAyMDA4LTA3LTI0ICA3NDkgIAo1NTBhNzM3NWYgRmVsaXBlIEJhbGJpICAgICAgICAgICAg ICAyMDA4LTA3LTI0ICA3NTAgIAltdXNiLT5pc19hY3RpdmUgPSAxOwo1NTBhNzM3NWYgRmVsaXBl IEJhbGJpICAgICAgICAgICAgICAyMDA4LTA3LTI0ICA3NTEgIAltdXNiLT5lcDBfc3RhZ2UgPSBN VVNCX0VQMF9TVEFSVDsKNTUwYTczNzVmIEZlbGlwZSBCYWxiaSAgICAgICAgICAgICAgMjAwOC0w Ny0yNCAgNzUyICAKYjE4ZDI2ZjZhIFNlYmFzdGlhbiBBbmRyemVqIFNpZXdpb3IgMjAxMi0xMC0z MCAgNzUzICAJbXVzYi0+aW50cnR4ZSA9IG11c2ItPmVwbWFzazsKYjE4ZDI2ZjZhIFNlYmFzdGlh biBBbmRyemVqIFNpZXdpb3IgMjAxMi0xMC0zMCAgNzU0ICAJbXVzYl93cml0ZXcobXVzYi0+bXJl Z3MsIE1VU0JfSU5UUlRYRSwgbXVzYi0+aW50cnR4ZSk7CmFmNWVjMTRkNCBTZWJhc3RpYW4gQW5k cnplaiBTaWV3aW9yIDIwMTItMTAtMzAgIDc1NSAgCW11c2ItPmludHJyeGUgPSBtdXNiLT5lcG1h c2sgJiAweGZmZmU7CmFmNWVjMTRkNCBTZWJhc3RpYW4gQW5kcnplaiBTaWV3aW9yIDIwMTItMTAt MzAgIDc1NiAgCW11c2Jfd3JpdGV3KG11c2ItPm1yZWdzLCBNVVNCX0lOVFJSWEUsIG11c2ItPmlu dHJyeGUpOwpkNzA5ZDIyZWUgQWpheSBLdW1hciBHdXB0YSAgICAgICAgICAyMDEwLTA3LTA4ICA3 NTcgIAltdXNiX3dyaXRlYihtdXNiLT5tcmVncywgTVVTQl9JTlRSVVNCRSwgMHhmNyk7CjU1MGE3 Mzc1ZiBGZWxpcGUgQmFsYmkgICAgICAgICAgICAgIDIwMDgtMDctMjQgIDc1OCAgCW11c2ItPnBv cnQxX3N0YXR1cyAmPSB+KFVTQl9QT1JUX1NUQVRfTE9XX1NQRUVECjU1MGE3Mzc1ZiBGZWxpcGUg QmFsYmkgICAgICAgICAgICAgIDIwMDgtMDctMjQgIDc1OSAgCQkJCXxVU0JfUE9SVF9TVEFUX0hJ R0hfU1BFRUQKNTUwYTczNzVmIEZlbGlwZSBCYWxiaSAgICAgICAgICAgICAgMjAwOC0wNy0yNCAg NzYwICAJCQkJfFVTQl9QT1JUX1NUQVRfRU5BQkxFCjU1MGE3Mzc1ZiBGZWxpcGUgQmFsYmkgICAg ICAgICAgICAgIDIwMDgtMDctMjQgIDc2MSAgCQkJCSk7CjU1MGE3Mzc1ZiBGZWxpcGUgQmFsYmkg ICAgICAgICAgICAgIDIwMDgtMDctMjQgIDc2MiAgCW11c2ItPnBvcnQxX3N0YXR1cyB8PSBVU0Jf UE9SVF9TVEFUX0NPTk5FQ1RJT04KNTUwYTczNzVmIEZlbGlwZSBCYWxiaSAgICAgICAgICAgICAg MjAwOC0wNy0yNCAgNzYzICAJCQkJfChVU0JfUE9SVF9TVEFUX0NfQ09OTkVDVElPTiA8PCAxNik7 CjU1MGE3Mzc1ZiBGZWxpcGUgQmFsYmkgICAgICAgICAgICAgIDIwMDgtMDctMjQgIDc2NCAgCjU1 MGE3Mzc1ZiBGZWxpcGUgQmFsYmkgICAgICAgICAgICAgIDIwMDgtMDctMjQgIDc2NSAgCS8qIGhp Z2ggdnMgZnVsbCBzcGVlZCBpcyBqdXN0IGEgZ3Vlc3MgdW50aWwgYWZ0ZXIgcmVzZXQgKi8KNTUw YTczNzVmIEZlbGlwZSBCYWxiaSAgICAgICAgICAgICAgMjAwOC0wNy0yNCAgNzY2ICAJaWYgKGRl dmN0bCAmIE1VU0JfREVWQ1RMX0xTREVWKQo1NTBhNzM3NWYgRmVsaXBlIEJhbGJpICAgICAgICAg ICAgICAyMDA4LTA3LTI0ICA3NjcgIAkJbXVzYi0+cG9ydDFfc3RhdHVzIHw9IFVTQl9QT1JUX1NU QVRfTE9XX1NQRUVEOwo1NTBhNzM3NWYgRmVsaXBlIEJhbGJpICAgICAgICAgICAgICAyMDA4LTA3 LTI0ICA3NjggIAo1NTBhNzM3NWYgRmVsaXBlIEJhbGJpICAgICAgICAgICAgICAyMDA4LTA3LTI0 ICA3NjkgIAkvKiBpbmRpY2F0ZSBuZXcgY29ubmVjdGlvbiB0byBPVEcgbWFjaGluZSAqLwplNDdk OTI1NDUgQW50b2luZSBUZW5hcnQgICAgICAgICAgICAyMDE0LTEwLTMwICA3NzAgIAlzd2l0Y2gg KG11c2ItPnhjZWl2LT5vdGctPnN0YXRlKSB7CjU1MGE3Mzc1ZiBGZWxpcGUgQmFsYmkgICAgICAg ICAgICAgIDIwMDgtMDctMjQgIDc3MSAgCWNhc2UgT1RHX1NUQVRFX0JfUEVSSVBIRVJBTDoKNTUw YTczNzVmIEZlbGlwZSBCYWxiaSAgICAgICAgICAgICAgMjAwOC0wNy0yNCAgNzcyICAJCWlmIChp bnRfdXNiICYgTVVTQl9JTlRSX1NVU1BFTkQpIHsKYjk5ZDM2NTliIEJpbiBMaXUgICAgICAgICAg ICAgICAgICAgMjAxNi0wNi0zMCAgNzczICAJCQltdXNiX2RiZyhtdXNiLCAiSE5QOiBTVVNQRU5E K0NPTk5FQ1QsIG5vdyBiX2hvc3QiKTsKNTUwYTczNzVmIEZlbGlwZSBCYWxiaSAgICAgICAgICAg ICAgMjAwOC0wNy0yNCAgNzc0ICAJCQlpbnRfdXNiICY9IH5NVVNCX0lOVFJfU1VTUEVORDsKMWRl MDBkYWU4IERhdmlkIEJyb3duZWxsICAgICAgICAgICAgMjAwOS0wNC0wMiAgNzc1ICAJCQlnb3Rv IGJfaG9zdDsKNTUwYTczNzVmIEZlbGlwZSBCYWxiaSAgICAgICAgICAgICAgMjAwOC0wNy0yNCAg Nzc2ICAJCX0gZWxzZQpiOTlkMzY1OWIgQmluIExpdSAgICAgICAgICAgICAgICAgICAyMDE2LTA2 LTMwICA3NzcgIAkJCW11c2JfZGJnKG11c2IsICJDT05ORUNUIGFzIGJfcGVyaXBoZXJhbD8/PyIp Owo1NTBhNzM3NWYgRmVsaXBlIEJhbGJpICAgICAgICAgICAgICAyMDA4LTA3LTI0ICA3NzggIAkJ YnJlYWs7CjU1MGE3Mzc1ZiBGZWxpcGUgQmFsYmkgICAgICAgICAgICAgIDIwMDgtMDctMjQgIDc3 OSAgCWNhc2UgT1RHX1NUQVRFX0JfV0FJVF9BQ09OOgpiOTlkMzY1OWIgQmluIExpdSAgICAgICAg ICAgICAgICAgICAyMDE2LTA2LTMwICA3ODAgIAkJbXVzYl9kYmcobXVzYiwgIkhOUDogQ09OTkVD VCwgbm93IGJfaG9zdCIpOwoxZGUwMGRhZTggRGF2aWQgQnJvd25lbGwgICAgICAgICAgICAyMDA5 LTA0LTAyICA3ODEgIGJfaG9zdDoKZTQ3ZDkyNTQ1IEFudG9pbmUgVGVuYXJ0ICAgICAgICAgICAg MjAxNC0xMC0zMCAgNzgyICAJCW11c2ItPnhjZWl2LT5vdGctPnN0YXRlID0gT1RHX1NUQVRFX0Jf SE9TVDsKNzRjMmU5MzYwIERhbmllbCBNYWNrICAgICAgICAgICAgICAgMjAxMy0wNC0xMCBANzgz ICAJCWlmIChtdXNiLT5oY2QpCjc0YzJlOTM2MCBEYW5pZWwgTWFjayAgICAgICAgICAgICAgIDIw MTMtMDQtMTAgIDc4NCAgCQkJbXVzYi0+aGNkLT5zZWxmLmlzX2JfaG9zdCA9IDE7CjFkZTAwZGFl OCBEYXZpZCBCcm93bmVsbCAgICAgICAgICAgIDIwMDktMDQtMDIgIDc4NSAgCQlkZWxfdGltZXIo Jm11c2ItPm90Z190aW1lcik7CjU1MGE3Mzc1ZiBGZWxpcGUgQmFsYmkgICAgICAgICAgICAgIDIw MDgtMDctMjQgIDc4NiAgCQlicmVhazsKNTUwYTczNzVmIEZlbGlwZSBCYWxiaSAgICAgICAgICAg ICAgMjAwOC0wNy0yNCAgNzg3ICAJZGVmYXVsdDoKNTUwYTczNzVmIEZlbGlwZSBCYWxiaSAgICAg ICAgICAgICAgMjAwOC0wNy0yNCAgNzg4ICAJCWlmICgoZGV2Y3RsICYgTVVTQl9ERVZDVExfVkJV UykKNTUwYTczNzVmIEZlbGlwZSBCYWxiaSAgICAgICAgICAgICAgMjAwOC0wNy0yNCAgNzg5ICAJ CQkJPT0gKDMgPDwgTVVTQl9ERVZDVExfVkJVU19TSElGVCkpIHsKZTQ3ZDkyNTQ1IEFudG9pbmUg VGVuYXJ0ICAgICAgICAgICAgMjAxNC0xMC0zMCAgNzkwICAJCQltdXNiLT54Y2Vpdi0+b3RnLT5z dGF0ZSA9IE9UR19TVEFURV9BX0hPU1Q7CjBiM2ViYTQ0MiBEYW5pZWwgTWFjayAgICAgICAgICAg ICAgIDIwMTMtMDQtMTAgIDc5MSAgCQkJaWYgKGhjZCkKNTUwYTczNzVmIEZlbGlwZSBCYWxiaSAg ICAgICAgICAgICAgMjAwOC0wNy0yNCAgNzkyICAJCQkJaGNkLT5zZWxmLmlzX2JfaG9zdCA9IDA7 CjU1MGE3Mzc1ZiBGZWxpcGUgQmFsYmkgICAgICAgICAgICAgIDIwMDgtMDctMjQgIDc5MyAgCQl9 CjU1MGE3Mzc1ZiBGZWxpcGUgQmFsYmkgICAgICAgICAgICAgIDIwMDgtMDctMjQgIDc5NCAgCQli cmVhazsKNTUwYTczNzVmIEZlbGlwZSBCYWxiaSAgICAgICAgICAgICAgMjAwOC0wNy0yNCAgNzk1 ICAJfQoxZGUwMGRhZTggRGF2aWQgQnJvd25lbGwgICAgICAgICAgICAyMDA5LTA0LTAyICA3OTYg IAowYjNlYmE0NDIgRGFuaWVsIE1hY2sgICAgICAgICAgICAgICAyMDEzLTA0LTEwIEA3OTcgIAlt dXNiX2hvc3RfcG9rZV9yb290X2h1YihtdXNiKTsKMWRlMDBkYWU4IERhdmlkIEJyb3duZWxsICAg ICAgICAgICAgMjAwOS0wNC0wMiAgNzk4ICAKYjk5ZDM2NTliIEJpbiBMaXUgICAgICAgICAgICAg ICAgICAgMjAxNi0wNi0zMCAgNzk5ICAJbXVzYl9kYmcobXVzYiwgIkNPTk5FQ1QgKCVzKSBkZXZj dGwgJTAyeCIsCmU0N2Q5MjU0NSBBbnRvaW5lIFRlbmFydCAgICAgICAgICAgIDIwMTQtMTAtMzAg IDgwMCAgCQkJdXNiX290Z19zdGF0ZV9zdHJpbmcobXVzYi0+eGNlaXYtPm90Zy0+c3RhdGUpLCBk ZXZjdGwpOwo1NTBhNzM3NWYgRmVsaXBlIEJhbGJpICAgICAgICAgICAgICAyMDA4LTA3LTI0ICA4 MDEgIH0KNTUwYTczNzVmIEZlbGlwZSBCYWxiaSAgICAgICAgICAgICAgMjAwOC0wNy0yNCAgODAy Ci0tLQowLURBWSBrZXJuZWwgdGVzdCBpbmZyYXN0cnVjdHVyZSAgICAgICAgICAgICAgICBPcGVu IFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpodHRwczovL2xpc3RzLjAxLm9yZy9waXBlcm1haWwv a2J1aWxkLWFsbCAgICAgICAgICAgICAgICAgICBJbnRlbCBDb3Jwb3JhdGlvbgotLQpUbyB1bnN1 YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgbGludXgt dXNiIiBpbgp0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9y ZwpNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9t by1pbmZvLmh0bWwK