linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: Johan Hovold <johan@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Felipe Balbi <balbi@kernel.org>,
	Alan Stern <stern@rowland.harvard.edu>, Bin Liu <b-liu@ti.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: [5/6] USB: renesas_usbhs: drop support for legacy phys
Date: Wed, 18 Apr 2018 10:42:09 +0200	[thread overview]
Message-ID: <20180418084209.GF9198@localhost> (raw)

On Wed, Apr 18, 2018 at 04:22:31AM +0000, Yoshihiro Shimoda wrote:
> Hi,
> 
> > From: Johan Hovold, Sent: Saturday, April 14, 2018 10:06 PM
> > 
> > Drop support for legacy phys which hasn't been used with a mainline
> > kernel since commit 9080b8dc761a ("ARM: OMAP2+: Remove legacy usb-host.c
> > platform init code"). Specifically, since that commit usb_get_phy_dev()
> > have always returned -ENODEV and consequently this code has not been
> > used.
> > 
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> > ---
> >  drivers/usb/renesas_usbhs/common.h |  1 -
> >  drivers/usb/renesas_usbhs/rcar2.c  | 29 -----------------------------
> >  2 files changed, 30 deletions(-)
> 
> Thank you for the patch!
> The drivers/usb/renesas_usbhs/mod_gadget.c still uses the legacy phy
> API (usb_get_phy()).
> Also this patch set doesn't drop the API. So, I think this subject
> should be changed.
> What do you think?

Good point, I'll try to rephrase it.

How about

	USB: renesas_usbhs: drop unused legacy-phy support

and then I amend the commit message with a note about the legacy API
still being used in gadget mode to bind the peripheral controller?

> Dropping usb_get_phy_dev() from this driver is good to me.

Thanks,
Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2018-04-18  8:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18  8:42 Johan Hovold [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-04-18  9:20 [5/6] USB: renesas_usbhs: drop support for legacy phys Johan Hovold
2018-04-18  8:50 Yoshihiro Shimoda
2018-04-18  4:22 Yoshihiro Shimoda
2018-04-14 13:06 Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180418084209.GF9198@localhost \
    --to=johan@kernel.org \
    --cc=b-liu@ti.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).