From: Johan Hovold <johan@kernel.org>
To: Lars Melin <larsm17@gmail.com>,
Giuseppe Lippolis <giu.lippolis@gmail.com>
Cc: linux-usb@vger.kernel.org
Subject: usb:serial:optrion: fix dwm-158 3g modem interface
Date: Mon, 23 Apr 2018 10:42:49 +0200 [thread overview]
Message-ID: <20180423084249.GQ9198@localhost> (raw)
On Mon, Apr 23, 2018 at 02:14:01PM +0700, Lars Melin wrote:
> On 4/23/2018 14:03, Giuseppe Lippolis wrote:
> > The dwm-158 interface 4 and 5 doesn't answer to the AT commands
> > and doesn't appears a option interface.
> > Tested on openwrt distribution (kernel 4.14 using the old blacklist
> > definitions).
> >
> > Signed-off-by: Giuseppe Lippolis <giu.lippolis@gmail.com>
> > ---
> > drivers/usb/serial/option.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> > index c3f252283ab9..f0c3612467a3 100644
> > --- a/drivers/usb/serial/option.c
> > +++ b/drivers/usb/serial/option.c
> > @@ -1911,7 +1911,8 @@ static const struct usb_device_id option_ids[] = {
> > { USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7d01, 0xff) }, /* D-Link DWM-156 (variant) */
> > { USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7d02, 0xff) },
> > { USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7d03, 0xff) },
> > - { USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7d04, 0xff) }, /* D-Link DWM-158 */
> > + { USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7d04, 0xff), /* D-Link DWM-158 */
> > + .driver_info = RSVD(4) | RSVD(5) },
> > { USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7d0e, 0xff) }, /* D-Link DWM-157 C1 */
> > { USB_DEVICE_INTERFACE_CLASS(0x2001, 0x7e19, 0xff), /* D-Link DWM-221 B1 */
> > .driver_info = RSVD(4) },
>
> Blacklisting interface 4 and 5 is correct because:
>
> MI_00 D-Link Mobile Broadband Device (cdc_ether)
> MI_02 D-Link HSPA+DataCard Diagnostics Interface (also ppp modem)
> MI_03 D-Link HSPA+DataCard NMEA Device
> MI_04 D-Link HSPA+DataCard Speech Port
> MI_05 D-Link HSPA+DataCard Debug Port
> MI_06 USB Mass Storage Device
Thanks to both of you. I added Lars's comment to the commit message
before applying.
Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2018-04-23 8:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 8:42 Johan Hovold [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-04-24 17:30 usb:serial:optrion: fix dwm-158 3g modem interface Johan Hovold
2018-04-24 17:28 Johan Hovold
2018-04-24 4:21 Dan Williams
2018-04-24 2:55 Lars Melin
2018-04-23 16:54 Dan Williams
2018-04-23 9:02 Johan Hovold
2018-04-23 8:58 Sergei Shtylyov
2018-04-23 7:14 Lars Melin
2018-04-23 7:03 Giuseppe Lippolis
2018-04-23 7:00 Giuseppe Lippolis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180423084249.GQ9198@localhost \
--to=johan@kernel.org \
--cc=giu.lippolis@gmail.com \
--cc=larsm17@gmail.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).