From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Johan Hovold <johan@kernel.org>
Cc: Andrey Konovalov <andreyknvl@google.com>, linux-usb@vger.kernel.org
Subject: USB: serial: visor: handle potential invalid device configuration
Date: Wed, 2 May 2018 04:12:14 -0700 [thread overview]
Message-ID: <20180502111214.GB22091@kroah.com> (raw)
On Wed, May 02, 2018 at 09:50:04AM +0200, Johan Hovold wrote:
> On Sun, Apr 29, 2018 at 05:41:55PM +0200, Greg Kroah-Hartman wrote:
> > If we get an invalid device configuration from a palm 3 type device, we
> > might incorrectly parse things, and we have the potential to crash in
> > "interesting" ways.
> >
> > Fix this up by verifying the size of the configuration passed to us by
> > the device, and only if it is correct, will we handle it.
> >
> > Reported-by: Andrey Konovalov <andreyknvl@google.com>
> > Reviewed-by: Andrey Konovalov <andreyknvl@google.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> > ---
> >
> > Here is my long-forgotten patch for the visor driver to resolve an issue
> > that Andrey found back in September of 2017. Sorry for the long delay.
> >
> > Johan, I incorporated your review comments of my original one-off patch
> > here as well.
>
> Thanks for the update. I've applied this for 4.17-rc now after adding a
> stable tag and a comment about this one also fixing a slab info leak
> (through that dev_info in the port loop below).
Ugh, I forgot about the stable tag, thanks for that!
greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2018-05-02 11:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 11:12 Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-05-02 7:50 USB: serial: visor: handle potential invalid device configuration Johan Hovold
2018-04-29 15:41 Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502111214.GB22091@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andreyknvl@google.com \
--cc=johan@kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).