linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Florian Zumbiehl <florz@florz.de>
Cc: Johan Hovold <johan@kernel.org>, linux-usb@vger.kernel.org
Subject: usbserial: pl2303 tx xon/xoff flow control
Date: Mon, 21 May 2018 10:45:36 +0200	[thread overview]
Message-ID: <20180521084536.GP30172@localhost> (raw)

On Sun, May 20, 2018 at 02:22:27AM +0200, Florian Zumbiehl wrote:

> Before I investigated how to implement this patch I just saw that s/w flow
> control "didn't work", but my assumption was that that was due to buffering
> latencies, not because the kernel just ignored the request. But then,
> chances are a software implementation indeed wouldn't work very well anyway
> for exactly that reason?!

Indeed, the deep queues might prevent a software implementation from
being very useful.

> > The line discipline implementation kicks in whenever IXON is set, and
> > can be used as a fallback for devices where automatic hardware and
> > software flow control cannot be enabled concurrently in hardware for
> > example.
> 
> Well, yeah, my guess would be that to actually make it work (well), one
> would need more than that? Like, implement rate control in software to keep
> the hardware buffers empty in order to achieve short reaction times? Which
> one would probably want to disable though when it's not needed in order to
> take advantage of the buffers?

Maybe, but chances are none of this is worth the added complexity. If
you need XON/XOFF you should get a device which supports it in hardware.

> > While non-hardware assisted usb serial XON/XOFF is currently broken in
> > that transmission would not be halted, the line discipline would still
> > swallow any escape characters.
> 
> Actually, that is required even for the pl2303, as it does not swallow the
> control characters itself.

Yeah, I noticed that too.

Thanks,
Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2018-05-21  8:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-21  8:45 Johan Hovold [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-05-18 13:16 usbserial: pl2303 tx xon/xoff flow control Johan Hovold
2018-05-18 13:09 Johan Hovold
2018-05-18  4:06 Florian Zumbiehl
2018-05-18  4:06 Florian Zumbiehl
2018-05-17  9:19 Johan Hovold
2018-05-17  8:29 Johan Hovold
2018-05-17  3:39 Florian Zumbiehl
2018-05-16 13:28 Johan Hovold
2018-05-14  3:15 Florian Zumbiehl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180521084536.GP30172@localhost \
    --to=johan@kernel.org \
    --cc=florz@florz.de \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).