From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [15/22] USB: dwc2: no need to check return value of debugfs_create functions From: Greg Kroah-Hartman Message-Id: <20180529153107.12791-15-gregkh@linuxfoundation.org> Date: Tue, 29 May 2018 17:31:00 +0200 To: linux-usb@vger.kernel.org Cc: Greg Kroah-Hartman , Minas Harutyunyan List-ID: V2hlbiBjYWxsaW5nIGRlYnVnZnMgZnVuY3Rpb25zLCB0aGVyZSBpcyBubyBuZWVkIHRvIGV2ZXIg Y2hlY2sgdGhlCnJldHVybiB2YWx1ZS4gIFRoZSBmdW5jdGlvbiBjYW4gd29yayBvciBub3QsIGJ1 dCB0aGUgY29kZSBsb2dpYyBzaG91bGQKbmV2ZXIgZG8gc29tZXRoaW5nIGRpZmZlcmVudCBiYXNl ZCBvbiB0aGlzLgoKQ2M6IE1pbmFzIEhhcnV0eXVueWFuIDxobWluYXNAc3lub3BzeXMuY29tPgpT aWduZWQtb2ZmLWJ5OiBHcmVnIEtyb2FoLUhhcnRtYW4gPGdyZWdraEBsaW51eGZvdW5kYXRpb24u b3JnPgotLS0KIGRyaXZlcnMvdXNiL2R3YzIvZGVidWdmcy5jIHwgNzggKysrKysrKystLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCsp LCA2MiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9kd2MyL2RlYnVnZnMu YyBiL2RyaXZlcnMvdXNiL2R3YzIvZGVidWdmcy5jCmluZGV4IDdlNjYxOGFkOWYyMS4uZDBiZGI3 OTk3NTU3IDEwMDY0NAotLS0gYS9kcml2ZXJzL3VzYi9kd2MyL2RlYnVnZnMuYworKysgYi9kcml2 ZXJzL3VzYi9kd2MyL2RlYnVnZnMuYwpAQCAtMjk0LDUyICsyOTQsMzAgQEAgREVGSU5FX1NIT1df QVRUUklCVVRFKGVwKTsKIHN0YXRpYyB2b2lkIGR3YzJfaHNvdGdfY3JlYXRlX2RlYnVnKHN0cnVj dCBkd2MyX2hzb3RnICpoc290ZykKIHsKIAlzdHJ1Y3QgZGVudHJ5ICpyb290OwotCXN0cnVjdCBk ZW50cnkgKmZpbGU7CiAJdW5zaWduZWQgaW50IGVwaWR4OwogCiAJcm9vdCA9IGhzb3RnLT5kZWJ1 Z19yb290OwogCiAJLyogY3JlYXRlIGdlbmVyYWwgc3RhdGUgZmlsZSAqLwotCi0JZmlsZSA9IGRl YnVnZnNfY3JlYXRlX2ZpbGUoInN0YXRlIiwgMDQ0NCwgcm9vdCwgaHNvdGcsICZzdGF0ZV9mb3Bz KTsKLQlpZiAoSVNfRVJSKGZpbGUpKQotCQlkZXZfZXJyKGhzb3RnLT5kZXYsICIlczogZmFpbGVk IHRvIGNyZWF0ZSBzdGF0ZVxuIiwgX19mdW5jX18pOwotCi0JZmlsZSA9IGRlYnVnZnNfY3JlYXRl X2ZpbGUoInRlc3Rtb2RlIiwgMDY0NCwgcm9vdCwgaHNvdGcsCi0JCQkJICAgJnRlc3Rtb2RlX2Zv cHMpOwotCWlmIChJU19FUlIoZmlsZSkpCi0JCWRldl9lcnIoaHNvdGctPmRldiwgIiVzOiBmYWls ZWQgdG8gY3JlYXRlIHRlc3Rtb2RlXG4iLAotCQkJX19mdW5jX18pOwotCi0JZmlsZSA9IGRlYnVn ZnNfY3JlYXRlX2ZpbGUoImZpZm8iLCAwNDQ0LCByb290LCBoc290ZywgJmZpZm9fZm9wcyk7Ci0J aWYgKElTX0VSUihmaWxlKSkKLQkJZGV2X2Vycihoc290Zy0+ZGV2LCAiJXM6IGZhaWxlZCB0byBj cmVhdGUgZmlmb1xuIiwgX19mdW5jX18pOworCWRlYnVnZnNfY3JlYXRlX2ZpbGUoInN0YXRlIiwg MDQ0NCwgcm9vdCwgaHNvdGcsICZzdGF0ZV9mb3BzKTsKKwlkZWJ1Z2ZzX2NyZWF0ZV9maWxlKCJ0 ZXN0bW9kZSIsIDA2NDQsIHJvb3QsIGhzb3RnLCAmdGVzdG1vZGVfZm9wcyk7CisJZGVidWdmc19j cmVhdGVfZmlsZSgiZmlmbyIsIDA0NDQsIHJvb3QsIGhzb3RnLCAmZmlmb19mb3BzKTsKIAogCS8q IENyZWF0ZSBvbmUgZmlsZSBmb3IgZWFjaCBvdXQgZW5kcG9pbnQgKi8KIAlmb3IgKGVwaWR4ID0g MDsgZXBpZHggPCBoc290Zy0+bnVtX29mX2VwczsgZXBpZHgrKykgewogCQlzdHJ1Y3QgZHdjMl9o c290Z19lcCAqZXA7CiAKIAkJZXAgPSBoc290Zy0+ZXBzX291dFtlcGlkeF07Ci0JCWlmIChlcCkg ewotCQkJZmlsZSA9IGRlYnVnZnNfY3JlYXRlX2ZpbGUoZXAtPm5hbWUsIDA0NDQsCi0JCQkJCQkg ICByb290LCBlcCwgJmVwX2ZvcHMpOwotCQkJaWYgKElTX0VSUihmaWxlKSkKLQkJCQlkZXZfZXJy KGhzb3RnLT5kZXYsICJmYWlsZWQgdG8gY3JlYXRlICVzIGRlYnVnIGZpbGVcbiIsCi0JCQkJCWVw LT5uYW1lKTsKLQkJfQorCQlpZiAoZXApCisJCQlkZWJ1Z2ZzX2NyZWF0ZV9maWxlKGVwLT5uYW1l LCAwNDQ0LCByb290LCBlcCwgJmVwX2ZvcHMpOwogCX0KIAkvKiBDcmVhdGUgb25lIGZpbGUgZm9y IGVhY2ggaW4gZW5kcG9pbnQuIEVQMCBpcyBoYW5kbGVkIHdpdGggb3V0IGVwcyAqLwogCWZvciAo ZXBpZHggPSAxOyBlcGlkeCA8IGhzb3RnLT5udW1fb2ZfZXBzOyBlcGlkeCsrKSB7CiAJCXN0cnVj dCBkd2MyX2hzb3RnX2VwICplcDsKIAogCQllcCA9IGhzb3RnLT5lcHNfaW5bZXBpZHhdOwotCQlp ZiAoZXApIHsKLQkJCWZpbGUgPSBkZWJ1Z2ZzX2NyZWF0ZV9maWxlKGVwLT5uYW1lLCAwNDQ0LAot CQkJCQkJICAgcm9vdCwgZXAsICZlcF9mb3BzKTsKLQkJCWlmIChJU19FUlIoZmlsZSkpCi0JCQkJ ZGV2X2Vycihoc290Zy0+ZGV2LCAiZmFpbGVkIHRvIGNyZWF0ZSAlcyBkZWJ1ZyBmaWxlXG4iLAot CQkJCQllcC0+bmFtZSk7Ci0JCX0KKwkJaWYgKGVwKQorCQkJZGVidWdmc19jcmVhdGVfZmlsZShl cC0+bmFtZSwgMDQ0NCwgcm9vdCwgZXAsICZlcF9mb3BzKTsKIAl9CiB9CiAjZWxzZQpAQCAtNzky LDMyICs3NzAsMTQgQEAgREVGSU5FX1NIT1dfQVRUUklCVVRFKGRyX21vZGUpOwogaW50IGR3YzJf ZGVidWdmc19pbml0KHN0cnVjdCBkd2MyX2hzb3RnICpoc290ZykKIHsKIAlpbnQJCQlyZXQ7Ci0J c3RydWN0IGRlbnRyeQkJKmZpbGU7CisJc3RydWN0IGRlbnRyeQkJKnJvb3Q7CiAKLQloc290Zy0+ ZGVidWdfcm9vdCA9IGRlYnVnZnNfY3JlYXRlX2RpcihkZXZfbmFtZShoc290Zy0+ZGV2KSwgTlVM TCk7Ci0JaWYgKCFoc290Zy0+ZGVidWdfcm9vdCkgewotCQlyZXQgPSAtRU5PTUVNOwotCQlnb3Rv IGVycjA7Ci0JfQorCXJvb3QgPSBkZWJ1Z2ZzX2NyZWF0ZV9kaXIoZGV2X25hbWUoaHNvdGctPmRl diksIE5VTEwpOworCWhzb3RnLT5kZWJ1Z19yb290ID0gcm9vdDsKIAotCWZpbGUgPSBkZWJ1Z2Zz X2NyZWF0ZV9maWxlKCJwYXJhbXMiLCAwNDQ0LAotCQkJCSAgIGhzb3RnLT5kZWJ1Z19yb290LAot CQkJCSAgIGhzb3RnLCAmcGFyYW1zX2ZvcHMpOwotCWlmIChJU19FUlIoZmlsZSkpCi0JCWRldl9l cnIoaHNvdGctPmRldiwgIiVzOiBmYWlsZWQgdG8gY3JlYXRlIHBhcmFtc1xuIiwgX19mdW5jX18p OwotCi0JZmlsZSA9IGRlYnVnZnNfY3JlYXRlX2ZpbGUoImh3X3BhcmFtcyIsIDA0NDQsCi0JCQkJ ICAgaHNvdGctPmRlYnVnX3Jvb3QsCi0JCQkJICAgaHNvdGcsICZod19wYXJhbXNfZm9wcyk7Ci0J aWYgKElTX0VSUihmaWxlKSkKLQkJZGV2X2Vycihoc290Zy0+ZGV2LCAiJXM6IGZhaWxlZCB0byBj cmVhdGUgaHdfcGFyYW1zXG4iLAotCQkJX19mdW5jX18pOwotCi0JZmlsZSA9IGRlYnVnZnNfY3Jl YXRlX2ZpbGUoImRyX21vZGUiLCAwNDQ0LAotCQkJCSAgIGhzb3RnLT5kZWJ1Z19yb290LAotCQkJ CSAgIGhzb3RnLCAmZHJfbW9kZV9mb3BzKTsKLQlpZiAoSVNfRVJSKGZpbGUpKQotCQlkZXZfZXJy KGhzb3RnLT5kZXYsICIlczogZmFpbGVkIHRvIGNyZWF0ZSBkcl9tb2RlXG4iLCBfX2Z1bmNfXyk7 CisJZGVidWdmc19jcmVhdGVfZmlsZSgicGFyYW1zIiwgMDQ0NCwgcm9vdCwgaHNvdGcsICZwYXJh bXNfZm9wcyk7CisJZGVidWdmc19jcmVhdGVfZmlsZSgiaHdfcGFyYW1zIiwgMDQ0NCwgcm9vdCwg aHNvdGcsICZod19wYXJhbXNfZm9wcyk7CisJZGVidWdmc19jcmVhdGVfZmlsZSgiZHJfbW9kZSIs IDA0NDQsIHJvb3QsIGhzb3RnLCAmZHJfbW9kZV9mb3BzKTsKIAogCS8qIEFkZCBnYWRnZXQgZGVi dWdmcyBub2RlcyAqLwogCWR3YzJfaHNvdGdfY3JlYXRlX2RlYnVnKGhzb3RnKTsKQEAgLTgyNiwy NCArNzg2LDE4IEBAIGludCBkd2MyX2RlYnVnZnNfaW5pdChzdHJ1Y3QgZHdjMl9oc290ZyAqaHNv dGcpCiAJCQkJCQkJCUdGUF9LRVJORUwpOwogCWlmICghaHNvdGctPnJlZ3NldCkgewogCQlyZXQg PSAtRU5PTUVNOwotCQlnb3RvIGVycjE7CisJCWdvdG8gZXJyOwogCX0KIAogCWhzb3RnLT5yZWdz ZXQtPnJlZ3MgPSBkd2MyX3JlZ3M7CiAJaHNvdGctPnJlZ3NldC0+bnJlZ3MgPSBBUlJBWV9TSVpF KGR3YzJfcmVncyk7CiAJaHNvdGctPnJlZ3NldC0+YmFzZSA9IGhzb3RnLT5yZWdzOwogCi0JZmls ZSA9IGRlYnVnZnNfY3JlYXRlX3JlZ3NldDMyKCJyZWdkdW1wIiwgMDQ0NCwgaHNvdGctPmRlYnVn X3Jvb3QsCi0JCQkJICAgICAgIGhzb3RnLT5yZWdzZXQpOwotCWlmICghZmlsZSkgewotCQlyZXQg PSAtRU5PTUVNOwotCQlnb3RvIGVycjE7Ci0JfQorCWRlYnVnZnNfY3JlYXRlX3JlZ3NldDMyKCJy ZWdkdW1wIiwgMDQ0NCwgcm9vdCwgaHNvdGctPnJlZ3NldCk7CiAKIAlyZXR1cm4gMDsKLWVycjE6 CitlcnI6CiAJZGVidWdmc19yZW1vdmVfcmVjdXJzaXZlKGhzb3RnLT5kZWJ1Z19yb290KTsKLWVy cjA6CiAJcmV0dXJuIHJldDsKIH0KIAo=