From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [05/22] USB: mon: no need to check return value of debugfs_create functions From: Greg Kroah-Hartman Message-Id: <20180529153107.12791-5-gregkh@linuxfoundation.org> Date: Tue, 29 May 2018 17:30:50 +0200 To: linux-usb@vger.kernel.org Cc: Greg Kroah-Hartman , Pete Zaitcev , Philippe Ombredanne , Fredrik Noring , Kate Stewart List-ID: V2hlbiBjYWxsaW5nIGRlYnVnZnMgZnVuY3Rpb25zLCB0aGVyZSBpcyBubyBuZWVkIHRvIGV2ZXIg Y2hlY2sgdGhlCnJldHVybiB2YWx1ZS4gIFRoZSBmdW5jdGlvbiBjYW4gd29yayBvciBub3QsIGJ1 dCB0aGUgY29kZSBsb2dpYyBzaG91bGQKbmV2ZXIgZG8gc29tZXRoaW5nIGRpZmZlcmVudCBiYXNl ZCBvbiB0aGlzLgoKV2UgZG8gbmVlZCB0byBzYXZlIHRoZSBkZW50cmllcyBmb3IgdGhlc2UgZmls ZXMsIHNvIGtlZXAgdGhlbSBhcm91bmQsCmJ1dCBubyBuZWVkIHRvIGNoZWNrIGlmIHRoZXkgYXJl ICJ2YWxpZCIgb3Igbm90LCBhcyB0aGUgY29kZSB3b3JrcyBqdXN0CmFzIHdlbGwgZWl0aGVyIHdh eS4KCkNjOiBQZXRlIFphaXRjZXYgPHphaXRjZXZAa290b3JpLnphaXRjZXYudXM+CkNjOiBQaGls aXBwZSBPbWJyZWRhbm5lIDxwb21icmVkYW5uZUBuZXhiLmNvbT4KQ2M6IEZyZWRyaWsgTm9yaW5n IDxub3JpbmdAbm9jcmV3Lm9yZz4KQ2M6IEthdGUgU3Rld2FydCA8a3N0ZXdhcnRAbGludXhmb3Vu ZGF0aW9uLm9yZz4KU2lnbmVkLW9mZi1ieTogR3JlZyBLcm9haC1IYXJ0bWFuIDxncmVna2hAbGlu dXhmb3VuZGF0aW9uLm9yZz4KLS0tCiBkcml2ZXJzL3VzYi9tb24vbW9uX3RleHQuYyB8IDM3ICsr KysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA3IGlu c2VydGlvbnMoKyksIDMwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL21v bi9tb25fdGV4dC5jIGIvZHJpdmVycy91c2IvbW9uL21vbl90ZXh0LmMKaW5kZXggOTg0ZjdlMTJh NmE1Li5iYzVlY2Q1ZmY1NjUgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvdXNiL21vbi9tb25fdGV4dC5j CisrKyBiL2RyaXZlcnMvdXNiL21vbi9tb25fdGV4dC5jCkBAIC03MDAsNyArNzAwLDYgQEAgc3Rh dGljIGNvbnN0IHN0cnVjdCBmaWxlX29wZXJhdGlvbnMgbW9uX2ZvcHNfdGV4dF91ID0gewogCiBp bnQgbW9uX3RleHRfYWRkKHN0cnVjdCBtb25fYnVzICptYnVzLCBjb25zdCBzdHJ1Y3QgdXNiX2J1 cyAqdWJ1cykKIHsKLQlzdHJ1Y3QgZGVudHJ5ICpkOwogCWVudW0geyBOQU1FU1ogPSAxMCB9Owog CWNoYXIgbmFtZVtOQU1FU1pdOwogCWludCBidXNudW0gPSB1YnVzPyB1YnVzLT5idXNudW06IDA7 CkBAIC03MTMsNDIgKzcxMiwzMiBAQCBpbnQgbW9uX3RleHRfYWRkKHN0cnVjdCBtb25fYnVzICpt YnVzLCBjb25zdCBzdHJ1Y3QgdXNiX2J1cyAqdWJ1cykKIAkJcmMgPSBzbnByaW50ZihuYW1lLCBO QU1FU1osICIlZHQiLCBidXNudW0pOwogCQlpZiAocmMgPD0gMCB8fCByYyA+PSBOQU1FU1opCiAJ CQlnb3RvIGVycl9wcmludF90OwotCQlkID0gZGVidWdmc19jcmVhdGVfZmlsZShuYW1lLCAwNjAw LCBtb25fZGlyLCBtYnVzLAorCQltYnVzLT5kZW50X3QgPSBkZWJ1Z2ZzX2NyZWF0ZV9maWxlKG5h bWUsIDA2MDAsIG1vbl9kaXIsIG1idXMsCiAJCQkJCQkJICAgICAmbW9uX2ZvcHNfdGV4dF90KTsK LQkJaWYgKGQgPT0gTlVMTCkKLQkJCWdvdG8gZXJyX2NyZWF0ZV90OwotCQltYnVzLT5kZW50X3Qg PSBkOwogCX0KIAogCXJjID0gc25wcmludGYobmFtZSwgTkFNRVNaLCAiJWR1IiwgYnVzbnVtKTsK IAlpZiAocmMgPD0gMCB8fCByYyA+PSBOQU1FU1opCiAJCWdvdG8gZXJyX3ByaW50X3U7Ci0JZCA9 IGRlYnVnZnNfY3JlYXRlX2ZpbGUobmFtZSwgMDYwMCwgbW9uX2RpciwgbWJ1cywgJm1vbl9mb3Bz X3RleHRfdSk7Ci0JaWYgKGQgPT0gTlVMTCkKLQkJZ290byBlcnJfY3JlYXRlX3U7Ci0JbWJ1cy0+ ZGVudF91ID0gZDsKKwltYnVzLT5kZW50X3UgPSBkZWJ1Z2ZzX2NyZWF0ZV9maWxlKG5hbWUsIDA2 MDAsIG1vbl9kaXIsIG1idXMsCisJCQkJCSAgICZtb25fZm9wc190ZXh0X3UpOwogCiAJcmMgPSBz bnByaW50ZihuYW1lLCBOQU1FU1osICIlZHMiLCBidXNudW0pOwogCWlmIChyYyA8PSAwIHx8IHJj ID49IE5BTUVTWikKIAkJZ290byBlcnJfcHJpbnRfczsKLQlkID0gZGVidWdmc19jcmVhdGVfZmls ZShuYW1lLCAwNjAwLCBtb25fZGlyLCBtYnVzLCAmbW9uX2ZvcHNfc3RhdCk7Ci0JaWYgKGQgPT0g TlVMTCkKLQkJZ290byBlcnJfY3JlYXRlX3M7Ci0JbWJ1cy0+ZGVudF9zID0gZDsKKwltYnVzLT5k ZW50X3MgPSBkZWJ1Z2ZzX2NyZWF0ZV9maWxlKG5hbWUsIDA2MDAsIG1vbl9kaXIsIG1idXMsCisJ CQkJCSAgICZtb25fZm9wc19zdGF0KTsKIAogCXJldHVybiAxOwogCi1lcnJfY3JlYXRlX3M6CiBl cnJfcHJpbnRfczoKIAlkZWJ1Z2ZzX3JlbW92ZShtYnVzLT5kZW50X3UpOwogCW1idXMtPmRlbnRf dSA9IE5VTEw7Ci1lcnJfY3JlYXRlX3U6CiBlcnJfcHJpbnRfdToKIAlpZiAodWJ1cyAhPSBOVUxM KSB7CiAJCWRlYnVnZnNfcmVtb3ZlKG1idXMtPmRlbnRfdCk7CiAJCW1idXMtPmRlbnRfdCA9IE5V TEw7CiAJfQotZXJyX2NyZWF0ZV90OgogZXJyX3ByaW50X3Q6CiAJcmV0dXJuIDA7CiB9CkBAIC03 NTYsOCArNzQ1LDcgQEAgaW50IG1vbl90ZXh0X2FkZChzdHJ1Y3QgbW9uX2J1cyAqbWJ1cywgY29u c3Qgc3RydWN0IHVzYl9idXMgKnVidXMpCiB2b2lkIG1vbl90ZXh0X2RlbChzdHJ1Y3QgbW9uX2J1 cyAqbWJ1cykKIHsKIAlkZWJ1Z2ZzX3JlbW92ZShtYnVzLT5kZW50X3UpOwotCWlmIChtYnVzLT5k ZW50X3QgIT0gTlVMTCkKLQkJZGVidWdmc19yZW1vdmUobWJ1cy0+ZGVudF90KTsKKwlkZWJ1Z2Zz X3JlbW92ZShtYnVzLT5kZW50X3QpOwogCWRlYnVnZnNfcmVtb3ZlKG1idXMtPmRlbnRfcyk7CiB9 CiAKQEAgLTc3NSwxOCArNzYzLDcgQEAgc3RhdGljIHZvaWQgbW9uX3RleHRfY3Rvcih2b2lkICpt ZW0pCiAKIGludCBfX2luaXQgbW9uX3RleHRfaW5pdCh2b2lkKQogewotCXN0cnVjdCBkZW50cnkg Km1vbmRpcjsKLQotCW1vbmRpciA9IGRlYnVnZnNfY3JlYXRlX2RpcigidXNibW9uIiwgdXNiX2Rl YnVnX3Jvb3QpOwotCWlmIChJU19FUlIobW9uZGlyKSkgewotCQkvKiBkZWJ1Z2ZzIG5vdCBhdmFp bGFibGUsIGJ1dCB3ZSBjYW4gdXNlIHVzYm1vbiB3aXRob3V0IGl0ICovCi0JCXJldHVybiAwOwot CX0KLQlpZiAobW9uZGlyID09IE5VTEwpIHsKLQkJcHJpbnRrKEtFUk5fTk9USUNFIFRBRyAiOiB1 bmFibGUgdG8gY3JlYXRlIHVzYm1vbiBkaXJlY3RvcnlcbiIpOwotCQlyZXR1cm4gLUVOT01FTTsK LQl9Ci0JbW9uX2RpciA9IG1vbmRpcjsKKwltb25fZGlyID0gZGVidWdmc19jcmVhdGVfZGlyKCJ1 c2Jtb24iLCB1c2JfZGVidWdfcm9vdCk7CiAJcmV0dXJuIDA7CiB9CiAK