From: Thierry Reding <thierry.reding@gmail.com>
To: gengdongjiu <gengdongjiu@huawei.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
mathias.nyman@intel.com, jonathanh@nvidia.com,
linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: usb: xhci: remove the code build warning
Date: Tue, 5 Jun 2018 11:06:06 +0200 [thread overview]
Message-ID: <20180605090606.GA20649@ulmo> (raw)
On Tue, Jun 05, 2018 at 04:54:17PM +0800, gengdongjiu wrote:
>
>
> On 2018/6/5 16:40, Greg KH wrote:
> > On Wed, Jun 06, 2018 at 12:35:00AM +0800, Dongjiu Geng wrote:
> >> Initialize the 'err' variate to remove the build warning,
> >> the warning is shown as below:
> >>
> >> drivers/usb/host/xhci-tegra.c: In function ‘tegra_xusb_mbox_thread’:
> >> drivers/usb/host/xhci-tegra.c:552:6: warning: ‘err’ may be used uninitialized in this function [-Wuninitialized]
> >> drivers/usb/host/xhci-tegra.c:482:6: note: ‘err’ was declared here
> >>
> >> Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com>
> >> ---
> >
> > Any hint as to what commit caused this warning to show up?
>
> It seems below commit:
>
> commit e84fce0f8837496a48d11086829bdbe170358b7a
> Author: Thierry Reding <treding@nvidia.com>
> Date: Thu Feb 11 18:10:48 2016 +0100
>
> usb: xhci: Add NVIDIA Tegra XUSB controller driver
>
> Add support for the on-chip XUSB controller present on Tegra SoCs. This
> controller, when loaded with external firmware, exposes an interface
> compliant with xHCI. This driver loads the firmware, starts the
> controller, and is able to service host-specific messages sent by the
> controller's firmware.
>
> The controller also supports USB device mode as well as powergating
> of the SuperSpeed and host-controller logic when not in use, but
> support for these is not yet implemented.
>
> Based on work by:
> Ajay Gupta <ajayg@nvidia.com>
> Bharath Yadav <byadav@nvidia.com>
> Andrew Bresticker <abrestic@chromium.org>
>
> Cc: Mathias Nyman <mathias.nyman@intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
I've never seen this warning before. It's also a false positive in that
technically the mailbox message will always have at least one bit set in
"mask". However, I don't see how the compiler could know about it, given
that the data comes from an external source, so I think this makes sense
as a hint to the compiler. So:
Acked-by: Thierry Reding <treding@nvidia.com>
Can you provide more detail on what exact version of which compiler you
used that triggered this? I wonder why it's never presented itself with
the compiler that I use.
Thierry
next reply other threads:[~2018-06-05 9:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 9:06 Thierry Reding [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-06-05 16:35 usb: xhci: remove the code build warning Dongjiu Geng
2018-06-05 9:12 Dongjiu Geng
2018-06-05 8:54 Dongjiu Geng
2018-06-05 8:40 Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180605090606.GA20649@ulmo \
--to=thierry.reding@gmail.com \
--cc=gengdongjiu@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).