linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ming Lei <ming.lei@redhat.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	USB list <linux-usb@vger.kernel.org>,
	Kernel development list <linux-kernel@vger.kernel.org>
Subject: usb: don't offload isochronous urb completions to ksoftirq
Date: Thu, 14 Jun 2018 18:35:46 -0400	[thread overview]
Message-ID: <20180614183546.7e04024c@gandalf.local.home> (raw)

On Thu, 14 Jun 2018 18:23:11 -0400 (EDT)
Mikulas Patocka <mpatocka@redhat.com> wrote:

> I don't think it's so easy. The kernel 2.4 and below did this. And the 
> problem was that if there's a storm of network packets, the softirq code 
> would cause lockup of the whole machine. In order to not lockup the 
> machine - somewhere in the 2.4 cycle - the ksoftirqd thread was 
> introduced.
> 
> If you have CONFIG_PREEMPT_RT_FULL and you call softirqs in the interrupt 
> thread, you could only stall the interrupt thread. If you do the same 
> thing without CONFIG_PREEMPT_RT_FULL, you stall the whole CPU.
> 

Note, PREEMPT_RT also uses ksoftirqd too. Although we may set it to RT
prio 1. It is triggered if the softirq itself raises a softirq of the
same kind, and then the work is passed off to the ksoftirqd.

Causing the interrupt thread to stall (or by going into a loop of
softirqs) is likely to lock up the CPU on RT too, as interrupt threads
are usually run at priority 50, which will keep normal threads from
running on that CPU.

-- Steve
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2018-06-14 22:35 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-14 22:35 Steven Rostedt [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-06-15 21:13 usb: don't offload isochronous urb completions to ksoftirq Steven Rostedt
2018-06-15 21:05 Mikulas Patocka
2018-06-15 20:54 Alan Stern
2018-06-15 17:40 Sebastian Andrzej Siewior
2018-06-15 17:34 Steven Rostedt
2018-06-15 17:28 Thomas Gleixner
2018-06-15 17:17 Alan Stern
2018-06-15 16:46 Steven Rostedt
2018-06-15 16:41 Mikulas Patocka
2018-06-14 22:23 Mikulas Patocka
2018-06-13 22:31 Steven Rostedt
2018-06-13 19:30 Mikulas Patocka
2018-06-13 18:54 Alan Stern
2018-06-13 16:35 Mikulas Patocka
2018-06-13 14:13 Alan Stern
2018-06-13 13:57 Mikulas Patocka
2018-06-12 20:06 Alan Stern
2018-06-12 19:03 Mikulas Patocka
2018-06-12 18:50 Mikulas Patocka
2018-06-12 18:44 Alan Stern
2018-06-12 17:52 Greg Kroah-Hartman
2018-06-12 17:19 Mikulas Patocka
2018-06-12 16:38 Alan Stern
2018-06-12 16:03 Mikulas Patocka
2018-06-12 15:11 Alan Stern
2018-06-12 14:44 Mikulas Patocka
2018-06-12 14:38 Alan Stern
2018-06-12 14:29 Mikulas Patocka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180614183546.7e04024c@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=mpatocka@redhat.com \
    --cc=stern@rowland.harvard.edu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).