From: Johan Hovold <johan@kernel.org>
To: Felipe Balbi <balbi@kernel.org>
Cc: Johan Hovold <johan@kernel.org>, Roger Quadros <rogerq@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org
Subject: usb: dwc3: of-simple: fix use-after-free on remove
Date: Mon, 18 Jun 2018 10:34:22 +0200 [thread overview]
Message-ID: <20180618083422.GK32411@localhost> (raw)
On Mon, Jun 18, 2018 at 11:15:41AM +0300, Felipe Balbi wrote:
> I don't use this glue layer, actually. As long as there are no
> regressions, you can change it to your heart's content. I still it's
> best to start with pm runtime blocked and let userspace decide what and
> when should have pm runtime enabled.
I don't use it either, I just noticed the use-after-free in remove()
(and that probe was returning with a positive runtime PM usage count).
I suggest merging this fix for 4.18-rc, and then Roger can rework the
driver so that it works also on OMAP.
Thanks,
Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2018-06-18 8:34 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 8:34 Johan Hovold [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-06-21 15:15 usb: dwc3: of-simple: fix use-after-free on remove Alan Stern
2018-06-21 10:11 Johan Hovold
2018-06-21 9:52 Johan Hovold
2018-06-21 8:27 Johan Hovold
2018-06-21 8:17 Roger Quadros
2018-06-20 22:55 Rafael J. Wysocki
2018-06-20 22:32 Rafael J. Wysocki
2018-06-20 15:46 Johan Hovold
2018-06-20 12:54 Rafael J. Wysocki
2018-06-20 12:23 Johan Hovold
2018-06-20 12:17 Rafael J. Wysocki
2018-06-20 11:05 Felipe Balbi
2018-06-20 9:54 Rafael J. Wysocki
2018-06-20 9:27 Felipe Balbi
2018-06-20 9:16 Tony Lindgren
2018-06-20 4:34 Tony Lindgren
2018-06-19 12:10 Tero Kristo
2018-06-19 8:18 Felipe Balbi
2018-06-18 14:32 Roger Quadros
2018-06-18 12:21 Felipe Balbi
2018-06-18 11:11 Roger Quadros
2018-06-18 9:51 Felipe Balbi
2018-06-18 9:47 Johan Hovold
2018-06-18 9:33 Felipe Balbi
2018-06-18 8:15 Felipe Balbi
2018-06-13 10:59 Johan Hovold
2018-06-13 9:39 Felipe Balbi
2018-06-13 8:34 Roger Quadros
2018-06-13 8:05 Felipe Balbi
2018-06-13 7:49 Roger Quadros
2018-05-31 14:58 Johan Hovold
2018-05-31 14:45 Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180618083422.GK32411@localhost \
--to=johan@kernel.org \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=rogerq@ti.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).