From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: linux-media@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-usb@vger.kernel.org, tglx@linutronix.de,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Sean Young <sean@mess.org>
Subject: [22/27] media: ttusbir: use usb_fill_int_urb()
Date: Wed, 20 Jun 2018 13:01:00 +0200 [thread overview]
Message-ID: <20180620110105.19955-23-bigeasy@linutronix.de> (raw)
Using usb_fill_int_urb() helps to find code which initializes an
URB. A grep for members of the struct (like ->complete) reveal lots
of other things, too.
Cc: Sean Young <sean@mess.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
drivers/media/rc/ttusbir.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/media/rc/ttusbir.c b/drivers/media/rc/ttusbir.c
index aafea3c5170b..6a7c9b50ff5a 100644
--- a/drivers/media/rc/ttusbir.c
+++ b/drivers/media/rc/ttusbir.c
@@ -257,10 +257,6 @@ static int ttusbir_probe(struct usb_interface *intf,
goto out;
}
- urb->dev = tt->udev;
- urb->context = tt;
- urb->pipe = usb_rcvisocpipe(tt->udev, tt->iso_in_endp);
- urb->interval = 1;
buffer = usb_alloc_coherent(tt->udev, 128, GFP_KERNEL,
&urb->transfer_dma);
if (!buffer) {
@@ -268,11 +264,11 @@ static int ttusbir_probe(struct usb_interface *intf,
ret = -ENOMEM;
goto out;
}
+ usb_fill_int_urb(urb, tt->udev,
+ usb_rcvisocpipe(tt->udev, tt->iso_in_endp),
+ buffer, 128, ttusbir_urb_complete, tt, 1);
urb->transfer_flags = URB_NO_TRANSFER_DMA_MAP | URB_ISO_ASAP;
- urb->transfer_buffer = buffer;
- urb->complete = ttusbir_urb_complete;
urb->number_of_packets = 8;
- urb->transfer_buffer_length = 128;
for (j = 0; j < 8; j++) {
urb->iso_frame_desc[j].offset = j * 16;
next reply other threads:[~2018-06-20 11:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 11:01 Sebastian Andrzej Siewior [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-06-20 20:50 [22/27] media: ttusbir: use usb_fill_int_urb() Sean Young
2018-06-21 7:37 Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620110105.19955-23-bigeasy@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sean@mess.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).