From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: dwc3: of-simple: fix use-after-free on remove From: Johan Hovold Message-Id: <20180620154641.GT32411@localhost> Date: Wed, 20 Jun 2018 17:46:41 +0200 To: "Rafael J. Wysocki" Cc: Johan Hovold , Tony Lindgren , Felipe Balbi , Roger Quadros , Tero Kristo , Greg Kroah-Hartman , Alan Stern , linux-usb@vger.kernel.org, "Nori, Sekhar" , Grygorii Strashko , Nishanth Menon , linux-pm@vger.kernel.org List-ID: T24gV2VkLCBKdW4gMjAsIDIwMTggYXQgMDI6NTQ6MTBQTSArMDIwMCwgUmFmYWVsIEouIFd5c29j a2kgd3JvdGU6Cj4gT24gV2VkbmVzZGF5LCBKdW5lIDIwLCAyMDE4IDI6MjM6NDYgUE0gQ0VTVCBK b2hhbiBIb3ZvbGQgd3JvdGU6Cj4gPiBPbiBXZWQsIEp1biAyMCwgMjAxOCBhdCAwMjoxNjo1OUFN IC0wNzAwLCBUb255IExpbmRncmVuIHdyb3RlOgo+ID4gPiBIaSwKPiA+ID4gCj4gPiA+IEFkZGlu ZyBSYWZhZWwgYW5kIGxpbnV4LXBtIHRvIENjIGFzIHdlbGwuCj4gPiA+IAo+ID4gPiAqIEZlbGlw ZSBCYWxiaSA8YmFsYmlAa2VybmVsLm9yZz4gWzE4MDYxOSAwMToyM106Cj4gPiA+ID4gVGhpcyBp cyBhIGRpcmVjdCBjb25zZXF1ZW5jZSBvZiBub3QgcGF5aW5nIGF0dGVudGlvbiB0byB0aGUgb3Jk ZXIgb2YKPiA+ID4gPiB0aGluZ3MuIElmIGRyaXZlciB3ZXJlIHRvIGFzc3VtZSB0aGF0IHBtX2Rv bWFpbi0+YWN0aXZhdGUoKSB3b3VsZCBkbyB0aGUKPiA+ID4gPiByaWdodCB0aGluZyBmb3IgdGhl IGRldmljZSAtLSBtZWFuaW5nIHRoYXQgcHJvYmUgd291bGQgcnVuIHdpdGggYW4KPiA+ID4gPiBh Y3RpdmUgZGV2aWNlIC0tLCB0aGVuIHdlIHdvdWxkbid0IG5lZWQgdGhhdCBwbV9ydW50aW1lX2dl dCgpIGNhbGwgb24KPiA+ID4gPiBwcm9iZSBhdCBhbGwuIFJhdGhlciB3ZSB3b3VsZCBmb2xsb3cg dGhlIHNlcXVlbmNlOgo+ID4gPiA+IAo+ID4gPiA+IAlwbV9ydW50aW1lX2ZvcmJpZCgpCj4gPiA+ ID4gCXBtX3J1bnRpbWVfc2V0X2FjdGl2ZSgpCj4gPiA+ID4gCXBtX3J1bnRpbWVfZW5hYmxlKCkK PiA+ID4gPiAKPiA+ID4gPiAJLyogZG8geW91ciBwcm9iZSByb3V0aW5lICovCj4gPiA+ID4gCj4g PiA+ID4gCXBtX3J1bnRpbWVfcHV0X25vaWRsZSgpCj4gPiA+ID4gCj4gPiA+ID4gVGhlbiB5b3Ug cmVtb3ZlIHlvdSB3b3VsZCBuZWVkIHRvIGNhbGwgcG1fcnVudGltZV9nZXRfbm9yZXN1bWUoKSB0 bwo+ID4gPiA+IGJhbGFuY2Ugb3V0IHRoZSBwbV9ydW50aW1lX3B1dF9ub2lkbGUoKSB0aGVyZS4K PiA+IAo+ID4gPiA+IChJZiB5b3UgbmVlZCB0byBrbm93IHdoeSB0aGUgcG1fcnVudGltZV9wdXRf bm9pZGxlKCksIHJlbWVtYmVyIHRoYXQKPiA+ID4gPiBwbV9ydW50aW1lX3NldF9hY3RpdmUoKSBp bmNyZW1lbnRzIHRoZSB1c2FnZSBjb3VudGVyLCBzbwo+ID4gPiA+IHBtX3J1bnRpbWVfcHV0X25v aWRsZSBpcyBiYXNpY2FsbHkgYWxsb3dpbmcgcG1fcnVudGltZSB0byBoYXBwZW4gYXMgc29vbgo+ ID4gPiA+IGFzIHVzZXJzcGFjZSB3cml0ZXMgImF1dG8iIHRvIC9zeXMvLi4uLi9wb3dlci9jb250 cm9sKQo+ID4gCj4gPiBUaGF0J3Mgbm90IGNvcnJlY3Q7IHBtX3J1bnRpbWVfc2V0X2FjdGl2ZSgp IG9ubHkgaW5jcmVtZW50cyB0aGUgdXNhZ2UKPiA+IGNvdW50ZXIgb2YgYSBwYXJlbnQgKHVuZGVy IHNvbWUgY2lyY3Vtc3RhbmNlcyksIHNvIHVubGVzcyB5b3UgaGF2ZSBidXMKPiA+IGNvZGUgaW5j cmVtZW50aW5nIHRoZSB1c2FnZSBjb3VudGVyIGJlZm9yZSBwcm9iZSwgdGhlIGFib3ZlCj4gPiBw bV9ydW50aW1lX3B1dF9ub2lkbGUoKSB3b3VsZCBhY3R1YWxseSBpbnRyb2R1Y2UgYW4gaW1iYWxh bmNlLgo+IAo+IE5vLCBpdCB3b3VsZG4ndC4gIEl0IGJhbGFuY2VzIHRoZSBpbmNyZW1lbnRhdGlv biBpbiBwbV9ydW50aW1lX2ZvcmJpZCgpLgoKUmlnaHQsIGJ1dCBldmVuIGlmIHlvdSB0YWtlIHRo ZSB3aG9sZSBzZXF1ZW5jZSwgd2hpY2ggaW5jbHVkZWQKcG1fcnVudGltZV9mb3JiaWQoKSwgY29u c2lkZXIgd2hhdCBoYXBwZW5zIHdoZW4gcG1fcnVudGltZV9hbGxvdygpIGlzCmxhdGVyIGNhbGxl ZCB0aHJvdWdoIHN5c2ZzIChzZWUgYmVsb3cpLgoKPiA+IEFuZCBub3RlIHRoYXQgdGhhdCdzIGFs c28gdGhlIGNhc2UgZXZlbiBpZiB5b3UgbWVhbnQgdG8gc2F5IHRoYXQKPiA+ICpwbV9ydW50aW1l X2ZvcmJpZCgpKiBpbmNyZW1lbnRzIHRoZSB1c2FnZSBjb3VudGVyICh3aGljaCBpdCBkb2VzKS4K PiAKPiBXaHkgaXMgaXQ/Cj4gCj4gU3VyZWx5LCBhZnRlcgo+IAo+IHBtX3J1bnRpbWVfZm9yYmlk KGRldik7Cj4gcG1fcnVudGltZV9wdXRfbm9pZGxlKGRldik7Cj4gCj4gdGhlIHJ1bnRpbWUgUE0g dXNhZ2UgY291bnRlciBvZiBkZXYgd2lsbCBiZSB0aGUgc2FtZSBhcyBiZWZvcmUsIHdvbid0IGl0 PwoKU3VyZSwgYnV0IHRoZSBpbWJhbGFuY2UsIG9yIHJhdGhlciBpbmNvbnNpc3RlbnQgc3RhdGUs IGhhcyBhbHJlYWR5IGJlZW4KaW50cm9kdWNlZC4KCkNvbnNpZGVyIHRoZSBmb2xsb3dpbmcgc2Vx dWVuY2Ugb2YgZXZlbnRzOgoKCQkJCQl1c2FnZSBjb3VudAoJCQkJCTAKcHJvYmUoKQoJcG1fcnVu dGltZV9mb3JiaWQoKQkJMQoJcG1fcnVudGltZV9zZXRfYWN0aXZlKCkKCXBtX3J1bnRpbWVfZW5h YmxlKCkJCQoJcG1fcnVudGltZV9wdXRfbm9pZGxlKCkJCTAKCkhlcmUgbm90aGluZyBpcyBwcmV2 ZW50aW5nIHRoZSBkZXZpY2UgZnJvbSBydW50aW1lIHN1c3BlbmRpbmcsIGRlc3BpdGUKcnVudGlt ZSBQTSBiZWluZyBmb3JiaWRkZW4uIEluIGZhY3QsIGl0IHdpbGwgdHlwaWNhbGx5IGJlIHN1c3Bl bmRlZCBkdWUKdG8gdGhlIHBtX3JlcXVlc3RfaWRsZSgpIGluIGRyaXZlcl9wcm9iZV9kZXZpY2Uo KS4gSWYgbGF0ZXIgd2UgaGF2ZToKCmVjaG8gYXV0byA+IHBvd2VyL2NvbnRyb2wKCXBtX3J1bnRp bWVfYWxsb3coKQkJLTEKCnRoZW4gdGhlIGRldmljZSByZW1haW5zIHN1c3BlbmRlZCwgYnV0IHdl IGdldCBhIG5lZ2F0aXZlIHVzYWdlIGNvdW50LgpUaGlzIGRvZXMgbm90IHNlZW0gdG8gcGxheSB3 ZWxsIHdpdGggbmVpdGhlciBydW50aW1lIHBtIChjb25zaWRlciBhCnN5bmNocm9ub3VzIGdldCBm b2xsb3dlZCBieSBhIHB1dCwgd2hpY2ggd2lsbCBmYWlsIHRvIGFnYWluIHN1c3BlbmQgdGhlCmRl dmljZSkgb3IsIGZvciBleGFtcGxlLCBzeXN0ZW0gc3VzcGVuZCwgd2hpY2ggdHJpZXMgdG8gcHJl dmVudCBydW50aW1lCnBtIGJ5IGluY3JlbWVudGluZyB0aGUgdXNhZ2UgY291bnQuCgpBbmQgaWYg cnVudGltZSBwbSBpcyBsYXRlciBhZ2FpbiBmb3JiaWRkZW46CgplY2hvIG9uID4gcG93ZXIvY29u dHJvbAoJcG1fcnVudGltZV9mb3JiaWQoKQkJMAoKdGhlbiB0aGUgZGV2aWNlIHdpbGwgbm90IGJl IHJlc3VtZWQuCgpKb2hhbgotLS0KVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQg dGhlIGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4LXVzYiIgaW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdl IHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0 cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sCg==