From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: USB list <linux-usb@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kbuild test robot <lkp@intel.com>,
ShuFan Lee <shufan_lee@richtek.com>,
Guenter Roeck <linux@roeck-us.net>,
kbuild-all@01.org
Subject: staging/typec: fix tcpci_rt1711h build errors
Date: Thu, 21 Jun 2018 12:39:43 +0300 [thread overview]
Message-ID: <20180621093943.GE2847@kuha.fi.intel.com> (raw)
On Wed, Jun 20, 2018 at 05:05:42PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix Kconfig warning and build errors in staging/typec/rt1711h.c.
> The driver uses I2C interfaces so it should depend on I2C.
>
> WARNING: unmet direct dependencies detected for TYPEC_TCPCI
> Depends on [m]: STAGING [=y] && TYPEC_TCPM [=y] && I2C [=m]
> Selected by [y]:
> - TYPEC_RT1711H [=y] && STAGING [=y] && TYPEC_TCPM [=y]
>
> and then:
> drivers/staging/typec/tcpci.o: In function `tcpci_probe':
> ../drivers/staging/typec/tcpci.c:536: undefined reference to `__devm_regmap_init_i2c'
> drivers/staging/typec/tcpci.o: In function `tcpci_i2c_driver_init':
> ../drivers/staging/typec/tcpci.c:593: undefined reference to `i2c_register_driver'
> drivers/staging/typec/tcpci.o: In function `tcpci_i2c_driver_exit':
> ../drivers/staging/typec/tcpci.c:593: undefined reference to `i2c_del_driver'
> drivers/staging/typec/tcpci_rt1711h.o: In function `rt1711h_check_revision':
> ../drivers/staging/typec/tcpci_rt1711h.c:218: undefined reference to `i2c_smbus_read_word_data'
> ../drivers/staging/typec/tcpci_rt1711h.c:225: undefined reference to `i2c_smbus_read_word_data'
> drivers/staging/typec/tcpci_rt1711h.o: In function `rt1711h_probe':
> ../drivers/staging/typec/tcpci_rt1711h.c:251: undefined reference to `__devm_regmap_init_i2c'
> drivers/staging/typec/tcpci_rt1711h.o: In function `rt1711h_i2c_driver_init':
> ../drivers/staging/typec/tcpci_rt1711h.c:308: undefined reference to `i2c_register_driver'
> drivers/staging/typec/tcpci_rt1711h.o: In function `rt1711h_i2c_driver_exit':
> ../drivers/staging/typec/tcpci_rt1711h.c:308: undefined reference to `i2c_del_driver'
>
> Fixes: ce08eaeb6388 ("staging: typec: rt1711h typec chip driver")
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: ShuFan Lee <shufan_lee@richtek.com>
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: kbuild-all@01.org
Revieved-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/staging/typec/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- lnx-418-rc1.orig/drivers/staging/typec/Kconfig
> +++ lnx-418-rc1/drivers/staging/typec/Kconfig
> @@ -11,6 +11,7 @@ config TYPEC_TCPCI
>
> config TYPEC_RT1711H
> tristate "Richtek RT1711H Type-C chip driver"
> + depends on I2C
> select TYPEC_TCPCI
> help
> Richtek RT1711H Type-C chip driver that works with
>
Thanks,
next reply other threads:[~2018-06-21 9:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 9:39 Heikki Krogerus [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-06-21 13:05 staging/typec: fix tcpci_rt1711h build errors Guenter Roeck
2018-06-21 0:05 Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180621093943.GE2847@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkp@intel.com \
--cc=rdunlap@infradead.org \
--cc=shufan_lee@richtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).