From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Paul Menzel <pmenzel+linux-usb@molgen.mpg.de>,
Mario Limonciello <mario.limonciello@dell.com>,
linux-usb@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: [3/3] usb: typec: ucsi: Fix for incorrect status data issue
Date: Mon, 25 Jun 2018 20:37:25 +0800 [thread overview]
Message-ID: <20180625123725.GA9040@kroah.com> (raw)
On Thu, Jun 21, 2018 at 04:43:19PM +0300, Heikki Krogerus wrote:
> According to UCSI Specification, Connector Change Event only
> means a change in the Connector Status and Operation Mode
> fields of the STATUS data structure. So any other change
> should create another event.
>
> Unfortunately on some platforms the firmware acting as PPM
> (platform policy manager - usually embedded controller
> firmware) still does not report any other status changes if
> there is a connector change event. So if the connector power
> or data role was changed when a device was plugged to the
> connector, the driver does not get any indication about
> that. The port will show wrong roles if that happens.
>
> To fix the issue, always checking the data and power role
> together with a connector change event.
>
> Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface")
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
No stable kernel marking for this? odd...
greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2018-06-25 12:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 12:37 Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-06-26 8:09 [3/3] usb: typec: ucsi: Fix for incorrect status data issue Heikki Krogerus
2018-06-25 14:54 Greg Kroah-Hartman
2018-06-25 14:48 Heikki Krogerus
2018-06-21 13:43 Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180625123725.GA9040@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=pmenzel+linux-usb@molgen.mpg.de \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).