From: Johan Hovold <johan@kernel.org>
To: Aleksander Morgado <aleksander@aleksander.es>
Cc: "Johan Hovold" <johan@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, "Bjørn Mork" <bjorn@mork.no>
Subject: usb: serial: qcserial: add support for the Dell DW5821e module
Date: Tue, 26 Jun 2018 14:01:04 +0200 [thread overview]
Message-ID: <20180626120104.GQ26803@localhost> (raw)
> > So this doesn't really match the Sierra layout in qcserial, where the
> > QMI interface is documented as interface 8 (but perhaps we have other
> > examples of that already).
> >
> > Do you know what these serial ports are used for?
>
> You know what, I kind of missed that. This Dell device is not based on
> Sierra Wireless, so using the Sierra layout is not a good idea. Let me
> try to confirm with the manufacturer the purpose of each interface.
Sounds good.
> > Just based on the above, perhaps using option and matching on the vendor
> > class, while blacklisting interface 1 would be more appropriate?
>
> Being a Qualcomm based chipset, I believe qcserial would be more appropriate.
> I'll send an updated patch, including usb-devices output, once I have
> an explanation for all questions.
Note that we have other qualcomm based devices being handled by option
already. The qcserial driver was intended for a special subset of Gobi
modems with a particular interface layout and firmware loading
requirements. So unless your device falls in any of those categories,
option may still be preferred.
Thanks,
Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2018-06-26 12:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 12:01 Johan Hovold [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-06-26 12:05 usb: serial: qcserial: add support for the Dell DW5821e module Bjørn Mork
2018-06-26 11:59 Aleksander Morgado
2018-06-26 11:55 Aleksander Morgado
2018-06-26 9:55 Johan Hovold
2018-06-26 9:43 Johan Hovold
2018-06-26 8:49 Bjørn Mork
2018-06-26 8:29 Oliver Neukum
2018-06-26 7:44 Bjørn Mork
2018-06-26 7:40 Bjørn Mork
2018-06-26 7:32 Aleksander Morgado
2018-06-26 6:09 Johan Hovold
2018-06-23 21:24 Aleksander Morgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180626120104.GQ26803@localhost \
--to=johan@kernel.org \
--cc=aleksander@aleksander.es \
--cc=bjorn@mork.no \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).