* USB: serial: digi_acceleport: rename tty flag variable
@ 2018-06-27 6:00 Johan Hovold
0 siblings, 0 replies; 3+ messages in thread
From: Johan Hovold @ 2018-06-27 6:00 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Johan Hovold, linux-usb, Sebastian Andrzej Siewior, John Ogness
On Tue, Jun 26, 2018 at 10:12:28PM +0800, Greg Kroah-Hartman wrote:
> On Tue, Jun 26, 2018 at 03:43:13PM +0200, Johan Hovold wrote:
> > Add a "tty_" prefix to the tty "flag" variable to avoid any future
> > mixups with the recently added irq-mask "flags" one.
> >
> > Signed-off-by: Johan Hovold <johan@kernel.org>
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Thanks for reviewing, now applied.
Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* USB: serial: digi_acceleport: rename tty flag variable
@ 2018-06-26 14:12 Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2018-06-26 14:12 UTC (permalink / raw)
To: Johan Hovold; +Cc: linux-usb, Sebastian Andrzej Siewior, John Ogness
On Tue, Jun 26, 2018 at 03:43:13PM +0200, Johan Hovold wrote:
> Add a "tty_" prefix to the tty "flag" variable to avoid any future
> mixups with the recently added irq-mask "flags" one.
>
> Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* USB: serial: digi_acceleport: rename tty flag variable
@ 2018-06-26 13:43 Johan Hovold
0 siblings, 0 replies; 3+ messages in thread
From: Johan Hovold @ 2018-06-26 13:43 UTC (permalink / raw)
To: Johan Hovold
Cc: Greg Kroah-Hartman, linux-usb, Sebastian Andrzej Siewior,
John Ogness
Add a "tty_" prefix to the tty "flag" variable to avoid any future
mixups with the recently added irq-mask "flags" one.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/usb/serial/digi_acceleport.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/serial/digi_acceleport.c b/drivers/usb/serial/digi_acceleport.c
index ae512fed08af..e7f244cf2c07 100644
--- a/drivers/usb/serial/digi_acceleport.c
+++ b/drivers/usb/serial/digi_acceleport.c
@@ -1387,7 +1387,7 @@ static int digi_read_inb_callback(struct urb *urb)
int len;
int port_status;
unsigned char *data;
- int flag, throttled;
+ int tty_flag, throttled;
/* short/multiple packet check */
if (urb->actual_length < 2) {
@@ -1423,7 +1423,7 @@ static int digi_read_inb_callback(struct urb *urb)
data = &buf[3];
/* get flag from port_status */
- flag = 0;
+ tty_flag = 0;
/* overrun is special, not associated with a char */
if (port_status & DIGI_OVERRUN_ERROR)
@@ -1432,17 +1432,17 @@ static int digi_read_inb_callback(struct urb *urb)
/* break takes precedence over parity, */
/* which takes precedence over framing errors */
if (port_status & DIGI_BREAK_ERROR)
- flag = TTY_BREAK;
+ tty_flag = TTY_BREAK;
else if (port_status & DIGI_PARITY_ERROR)
- flag = TTY_PARITY;
+ tty_flag = TTY_PARITY;
else if (port_status & DIGI_FRAMING_ERROR)
- flag = TTY_FRAME;
+ tty_flag = TTY_FRAME;
/* data length is len-1 (one byte of len is port_status) */
--len;
if (len > 0) {
tty_insert_flip_string_fixed_flag(&port->port, data,
- flag, len);
+ tty_flag, len);
tty_flip_buffer_push(&port->port);
}
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-27 6:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-27 6:00 USB: serial: digi_acceleport: rename tty flag variable Johan Hovold
-- strict thread matches above, loose matches on Subject: below --
2018-06-26 14:12 Greg Kroah-Hartman
2018-06-26 13:43 Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).