From: Shawn Guo <shawnguo@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Peter Chen <Peter.Chen@nxp.com>,
USB list <linux-usb@vger.kernel.org>,
Andrey Smirnov <andrew.smirnov@gmail.com>,
Lucas Stach <l.stach@pengutronix.de>,
Sebastian Reichel <sebastian.reichel@collabora.co.uk>,
NXP Linux Team <linux-imx@nxp.com>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>
Subject: [v2] USB: chipidea: Do not hang when CONFIG_USB_CHIPIDEA_ULPI is not selected
Date: Tue, 3 Jul 2018 20:38:26 +0800 [thread overview]
Message-ID: <20180703123825.GR4348@dragon> (raw)
On Tue, Jul 03, 2018 at 07:52:07AM -0300, Fabio Estevam wrote:
> Hi Shawn,
>
> On Tue, Jul 3, 2018 at 12:40 AM, Shawn Guo <shawnguo@kernel.org> wrote:
>
> > We can have the options in defconfig, but they can still be turned off
> > for whatever reason and we get the hang. Really, missing a user
> > selectable option in defconfig shouldn't result in a system hang.
>
> Yes, 100% agree and this is exactly what this USB patch is all about :-)
>
> The whole point of this USB patch is not to let the the system to hang
> when the defconfig options are turned off.
>
> It will warn the user that CONFIG_USB_CHIPIDEA_ULPI needs to be
> selected, will propagate an error, but at least the system will not
> hang.
>
> The user will certainly notice the big warning which says "Select
> CONFIG_USB_CHIPIDEA_ULPI in order to use ULPI mode"
>
> Please check the original patch of this thread:
> https://patchwork.kernel.org/patch/10486371/
I'm still not convinced this is the best way to go. But that's USB
maintainer's call. I will just apply defconfig patches which shouldn't
hurt anyway.
Shawn
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2018-07-03 12:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 12:38 Shawn Guo [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-07-04 13:11 [v2] USB: chipidea: Do not hang when CONFIG_USB_CHIPIDEA_ULPI is not selected Fabio Estevam
2018-07-04 8:24 Peter Chen
2018-07-03 10:52 Fabio Estevam
2018-07-03 3:40 Shawn Guo
2018-07-03 2:22 Fabio Estevam
2018-07-03 2:06 Shawn Guo
2018-07-03 2:00 Fabio Estevam
2018-07-03 1:48 Shawn Guo
2018-07-02 11:52 Fabio Estevam
2018-07-02 3:08 Peter Chen
2018-06-27 4:10 Andrey Smirnov
2018-06-26 11:26 Fabio Estevam
2018-06-26 2:51 Peter Chen
2018-06-25 14:25 Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180703123825.GR4348@dragon \
--to=shawnguo@kernel.org \
--cc=Peter.Chen@nxp.com \
--cc=andrew.smirnov@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=sebastian.reichel@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox