From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pawel Laszczak <pawell@cadence.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Felipe Balbi <balbi@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Lukasz Tyrala <ltyrala@cadence.com>,
Alan Douglas <adouglas@cadence.com>
Subject: [02/31] usb: usbssp: Added some decoding functions.
Date: Thu, 12 Jul 2018 08:35:06 +0200 [thread overview]
Message-ID: <20180712063506.GA25007@kroah.com> (raw)
On Thu, Jul 12, 2018 at 06:28:33AM +0000, Pawel Laszczak wrote:
> > > This patch add additional functions that converts some fields to string.
> > >
> > > For example function usbssp_trb_comp_code_string take completion c ode
> > > value and return string describing completion code.
> >
> > Odd line-wrapping :(
> Do you mean additional space character between "c" and "ode"
It wrapped lines at that point for me, yes.
> > And why do you want a string for these things? Who cares about them?
> It will be used in next version of driver. I have plan to add gadget-debugfs.c file.
> At this moment this functions can be useful during debugging driver if someone want to display
> some debug information.
>
> Should I remove this function ?
If no one is using it now, yes, it does not need to be there, right? We
don't have dead code around for no reason, otherwise someone will come
along and remove it :)
thanks,
greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2018-07-12 6:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 6:35 Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-09-11 9:01 [02/31] usb: usbssp: Added some decoding functions Pawel Laszczak
2018-09-11 8:12 Greg Kroah-Hartman
2018-09-11 5:48 Felipe Balbi
2018-09-10 18:18 Greg Kroah-Hartman
2018-07-19 17:57 Pawel Laszczak
2018-07-12 17:07 Greg Kroah-Hartman
2018-07-12 16:43 Pawel Laszczak
2018-07-12 6:28 Pawel Laszczak
2018-07-12 6:10 Greg Kroah-Hartman
2018-07-12 5:46 Pawel Laszczak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180712063506.GA25007@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=adouglas@cadence.com \
--cc=balbi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ltyrala@cadence.com \
--cc=pawell@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).