linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* usb: dwc3: call set incr burst type func()
@ 2018-07-23  3:34 Pengbo Mu
  0 siblings, 0 replies; 12+ messages in thread
From: Pengbo Mu @ 2018-07-23  3:34 UTC (permalink / raw)
  To: Felipe Balbi, Greg Kroah-Hartman
  Cc: linux-kernel, linux-usb, ran.wang_1, pengbo.mu

Call dwc3_set_incr_burst_type() in dwc3_core_init().

Signed-off-by: Pengbo Mu <pengbo.mu@nxp.com>
---
Changes in v1:
 - add the calling of dwc3_set_incr_burst_type.
---
 drivers/usb/dwc3/core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 29df9e8..21e4931 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -932,6 +932,8 @@ static int dwc3_core_init(struct dwc3 *dwc)
 	/* Adjust Frame Length */
 	dwc3_frame_length_adjustment(dwc);
 
+	dwc3_set_incr_burst_type(dwc);
+
 	usb_phy_set_suspend(dwc->usb2_phy, 0);
 	usb_phy_set_suspend(dwc->usb3_phy, 0);
 	ret = phy_power_on(dwc->usb2_generic_phy);

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* usb: dwc3: call set incr burst type func()
@ 2018-07-23  5:16 Greg Kroah-Hartman
  0 siblings, 0 replies; 12+ messages in thread
From: Greg Kroah-Hartman @ 2018-07-23  5:16 UTC (permalink / raw)
  To: Pengbo Mu; +Cc: Felipe Balbi, linux-kernel, linux-usb, ran.wang_1

On Mon, Jul 23, 2018 at 11:34:13AM +0800, Pengbo Mu wrote:
> Call dwc3_set_incr_burst_type() in dwc3_core_init().
> 

That says what you did, not why you are doing this.

Please fix up.

greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 12+ messages in thread

* usb: dwc3: call set incr burst type func()
@ 2018-07-23  6:37 Pengbo Mu
  0 siblings, 0 replies; 12+ messages in thread
From: Pengbo Mu @ 2018-07-23  6:37 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Felipe Balbi, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org, Ran Wang

Hi Greg,

This patch should be tied with https://patchwork.kernel.org/patch/10539535/.
After sent four patches, I found I was missing this call.
Thanks for your advice. I will fix it immediately!

Pengbo Mu
-----Original Message-----
From: Greg Kroah-Hartman [mailto:gregkh@linuxfoundation.org] 
Sent: 2018年7月23日 13:16
To: Pengbo Mu <pengbo.mu@nxp.com>
Cc: Felipe Balbi <balbi@kernel.org>; linux-kernel@vger.kernel.org; linux-usb@vger.kernel.org; Ran Wang <ran.wang_1@nxp.com>
Subject: Re: [PATCH] usb: dwc3: call set incr burst type func()

On Mon, Jul 23, 2018 at 11:34:13AM +0800, Pengbo Mu wrote:
> Call dwc3_set_incr_burst_type() in dwc3_core_init().
> 

That says what you did, not why you are doing this.

Please fix up.

greg k-h

^ permalink raw reply	[flat|nested] 12+ messages in thread

* usb: dwc3: call set incr burst type func()
@ 2018-07-23  6:40 Pengbo Mu
  0 siblings, 0 replies; 12+ messages in thread
From: Pengbo Mu @ 2018-07-23  6:40 UTC (permalink / raw)
  To: Felipe Balbi, Greg Kroah-Hartman
  Cc: linux-kernel, linux-usb, ran.wang_1, pengbo.mu

Calling dwc3_set_incr_burst_type() in dwc3_core_init().
This function enabled the undefined length INCR burst type and
set INCRx. Different platform may has the different burst size
type. In order to get best performance, we need to tune the burst
size to one special value, instead of the default value.

Signed-off-by: Pengbo Mu <pengbo.mu@nxp.com>
---
Changes in v1:
 - add the calling of dwc3_set_incr_burst_type.
---
 drivers/usb/dwc3/core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 29df9e8..21e4931 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -932,6 +932,8 @@ static int dwc3_core_init(struct dwc3 *dwc)
 	/* Adjust Frame Length */
 	dwc3_frame_length_adjustment(dwc);
 
+	dwc3_set_incr_burst_type(dwc);
+
 	usb_phy_set_suspend(dwc->usb2_phy, 0);
 	usb_phy_set_suspend(dwc->usb3_phy, 0);
 	ret = phy_power_on(dwc->usb2_generic_phy);

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* usb: dwc3: call set incr burst type func()
@ 2018-07-23  6:59 Greg Kroah-Hartman
  0 siblings, 0 replies; 12+ messages in thread
From: Greg Kroah-Hartman @ 2018-07-23  6:59 UTC (permalink / raw)
  To: Pengbo Mu
  Cc: Felipe Balbi, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org, Ran Wang

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Mon, Jul 23, 2018 at 06:37:13AM +0000, Pengbo Mu wrote:
> Hi Greg,
> 
> This patch should be tied with https://patchwork.kernel.org/patch/10539535/.
> After sent four patches, I found I was missing this call.
> Thanks for your advice. I will fix it immediately!

Please send the series properly, with this one as part of it, otherwise
people will think it it separate and stand-alone.

thanks,

greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 12+ messages in thread

* usb: dwc3: call set incr burst type func()
@ 2018-07-23  7:00 Greg Kroah-Hartman
  0 siblings, 0 replies; 12+ messages in thread
From: Greg Kroah-Hartman @ 2018-07-23  7:00 UTC (permalink / raw)
  To: Pengbo Mu; +Cc: Felipe Balbi, linux-kernel, linux-usb, ran.wang_1

On Mon, Jul 23, 2018 at 02:40:57PM +0800, Pengbo Mu wrote:
> Calling dwc3_set_incr_burst_type() in dwc3_core_init().
> This function enabled the undefined length INCR burst type and
> set INCRx. Different platform may has the different burst size
> type. In order to get best performance, we need to tune the burst
> size to one special value, instead of the default value.
> 
> Signed-off-by: Pengbo Mu <pengbo.mu@nxp.com>
> ---
> Changes in v1:
>  - add the calling of dwc3_set_incr_burst_type.

This isn't the changelog :(  You also didn't version the patch in the
[PATCH] area :(

Please put this as part of the other series properly.

thanks,

greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 12+ messages in thread

* usb: dwc3: call set incr burst type func()
@ 2018-07-23  7:05 kbuild test robot
  0 siblings, 0 replies; 12+ messages in thread
From: kbuild test robot @ 2018-07-23  7:05 UTC (permalink / raw)
  To: Pengbo Mu
  Cc: kbuild-all, Felipe Balbi, Greg Kroah-Hartman, linux-kernel,
	linux-usb, ran.wang_1

Hi Pengbo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on balbi-usb/next]
[also build test ERROR on v4.18-rc6 next-20180720]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Pengbo-Mu/usb-dwc3-call-set-incr-burst-type-func/20180723-132027
base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: i386-randconfig-s1-201829 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/usb/dwc3/core.c: In function 'dwc3_core_init':
>> drivers/usb/dwc3/core.c:843:2: error: implicit declaration of function 'dwc3_set_incr_burst_type' [-Werror=implicit-function-declaration]
     dwc3_set_incr_burst_type(dwc);
     ^~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/dwc3_set_incr_burst_type +843 drivers/usb/dwc3/core.c

   780	
   781	/**
   782	 * dwc3_core_init - Low-level initialization of DWC3 Core
   783	 * @dwc: Pointer to our controller context structure
   784	 *
   785	 * Returns 0 on success otherwise negative errno.
   786	 */
   787	static int dwc3_core_init(struct dwc3 *dwc)
   788	{
   789		u32			reg;
   790		int			ret;
   791	
   792		if (!dwc3_core_is_valid(dwc)) {
   793			dev_err(dwc->dev, "this is not a DesignWare USB3 DRD Core\n");
   794			ret = -ENODEV;
   795			goto err0;
   796		}
   797	
   798		/*
   799		 * Write Linux Version Code to our GUID register so it's easy to figure
   800		 * out which kernel version a bug was found.
   801		 */
   802		dwc3_writel(dwc->regs, DWC3_GUID, LINUX_VERSION_CODE);
   803	
   804		/* Handle USB2.0-only core configuration */
   805		if (DWC3_GHWPARAMS3_SSPHY_IFC(dwc->hwparams.hwparams3) ==
   806				DWC3_GHWPARAMS3_SSPHY_IFC_DIS) {
   807			if (dwc->maximum_speed == USB_SPEED_SUPER)
   808				dwc->maximum_speed = USB_SPEED_HIGH;
   809		}
   810	
   811		ret = dwc3_phy_setup(dwc);
   812		if (ret)
   813			goto err0;
   814	
   815		if (!dwc->ulpi_ready) {
   816			ret = dwc3_core_ulpi_init(dwc);
   817			if (ret)
   818				goto err0;
   819			dwc->ulpi_ready = true;
   820		}
   821	
   822		if (!dwc->phys_ready) {
   823			ret = dwc3_core_get_phy(dwc);
   824			if (ret)
   825				goto err0a;
   826			dwc->phys_ready = true;
   827		}
   828	
   829		ret = dwc3_core_soft_reset(dwc);
   830		if (ret)
   831			goto err0a;
   832	
   833		dwc3_core_setup_global_control(dwc);
   834		dwc3_core_num_eps(dwc);
   835	
   836		ret = dwc3_setup_scratch_buffers(dwc);
   837		if (ret)
   838			goto err1;
   839	
   840		/* Adjust Frame Length */
   841		dwc3_frame_length_adjustment(dwc);
   842	
 > 843		dwc3_set_incr_burst_type(dwc);
   844	
   845		usb_phy_set_suspend(dwc->usb2_phy, 0);
   846		usb_phy_set_suspend(dwc->usb3_phy, 0);
   847		ret = phy_power_on(dwc->usb2_generic_phy);
   848		if (ret < 0)
   849			goto err2;
   850	
   851		ret = phy_power_on(dwc->usb3_generic_phy);
   852		if (ret < 0)
   853			goto err3;
   854	
   855		ret = dwc3_event_buffers_setup(dwc);
   856		if (ret) {
   857			dev_err(dwc->dev, "failed to setup event buffers\n");
   858			goto err4;
   859		}
   860	
   861		/*
   862		 * ENDXFER polling is available on version 3.10a and later of
   863		 * the DWC_usb3 controller. It is NOT available in the
   864		 * DWC_usb31 controller.
   865		 */
   866		if (!dwc3_is_usb31(dwc) && dwc->revision >= DWC3_REVISION_310A) {
   867			reg = dwc3_readl(dwc->regs, DWC3_GUCTL2);
   868			reg |= DWC3_GUCTL2_RST_ACTBITLATER;
   869			dwc3_writel(dwc->regs, DWC3_GUCTL2, reg);
   870		}
   871	
   872		if (dwc->revision >= DWC3_REVISION_250A) {
   873			reg = dwc3_readl(dwc->regs, DWC3_GUCTL1);
   874	
   875			/*
   876			 * Enable hardware control of sending remote wakeup
   877			 * in HS when the device is in the L1 state.
   878			 */
   879			if (dwc->revision >= DWC3_REVISION_290A)
   880				reg |= DWC3_GUCTL1_DEV_L1_EXIT_BY_HW;
   881	
   882			if (dwc->dis_tx_ipgap_linecheck_quirk)
   883				reg |= DWC3_GUCTL1_TX_IPGAP_LINECHECK_DIS;
   884	
   885			dwc3_writel(dwc->regs, DWC3_GUCTL1, reg);
   886		}
   887	
   888		/*
   889		 * Must config both number of packets and max burst settings to enable
   890		 * RX and/or TX threshold.
   891		 */
   892		if (dwc3_is_usb31(dwc) && dwc->dr_mode == USB_DR_MODE_HOST) {
   893			u8 rx_thr_num = dwc->rx_thr_num_pkt_prd;
   894			u8 rx_maxburst = dwc->rx_max_burst_prd;
   895			u8 tx_thr_num = dwc->tx_thr_num_pkt_prd;
   896			u8 tx_maxburst = dwc->tx_max_burst_prd;
   897	
   898			if (rx_thr_num && rx_maxburst) {
   899				reg = dwc3_readl(dwc->regs, DWC3_GRXTHRCFG);
   900				reg |= DWC31_RXTHRNUMPKTSEL_PRD;
   901	
   902				reg &= ~DWC31_RXTHRNUMPKT_PRD(~0);
   903				reg |= DWC31_RXTHRNUMPKT_PRD(rx_thr_num);
   904	
   905				reg &= ~DWC31_MAXRXBURSTSIZE_PRD(~0);
   906				reg |= DWC31_MAXRXBURSTSIZE_PRD(rx_maxburst);
   907	
   908				dwc3_writel(dwc->regs, DWC3_GRXTHRCFG, reg);
   909			}
   910	
   911			if (tx_thr_num && tx_maxburst) {
   912				reg = dwc3_readl(dwc->regs, DWC3_GTXTHRCFG);
   913				reg |= DWC31_TXTHRNUMPKTSEL_PRD;
   914	
   915				reg &= ~DWC31_TXTHRNUMPKT_PRD(~0);
   916				reg |= DWC31_TXTHRNUMPKT_PRD(tx_thr_num);
   917	
   918				reg &= ~DWC31_MAXTXBURSTSIZE_PRD(~0);
   919				reg |= DWC31_MAXTXBURSTSIZE_PRD(tx_maxburst);
   920	
   921				dwc3_writel(dwc->regs, DWC3_GTXTHRCFG, reg);
   922			}
   923		}
   924	
   925		return 0;
   926	
   927	err4:
   928		phy_power_off(dwc->usb3_generic_phy);
   929	
   930	err3:
   931		phy_power_off(dwc->usb2_generic_phy);
   932	
   933	err2:
   934		usb_phy_set_suspend(dwc->usb2_phy, 1);
   935		usb_phy_set_suspend(dwc->usb3_phy, 1);
   936	
   937	err1:
   938		usb_phy_shutdown(dwc->usb2_phy);
   939		usb_phy_shutdown(dwc->usb3_phy);
   940		phy_exit(dwc->usb2_generic_phy);
   941		phy_exit(dwc->usb3_generic_phy);
   942	
   943	err0a:
   944		dwc3_ulpi_exit(dwc);
   945	
   946	err0:
   947		return ret;
   948	}
   949
---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 12+ messages in thread

* usb: dwc3: call set incr burst type func()
@ 2018-07-23  7:10 kbuild test robot
  0 siblings, 0 replies; 12+ messages in thread
From: kbuild test robot @ 2018-07-23  7:10 UTC (permalink / raw)
  To: Pengbo Mu
  Cc: kbuild-all, Felipe Balbi, Greg Kroah-Hartman, linux-kernel,
	linux-usb, ran.wang_1

Hi Pengbo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on balbi-usb/next]
[also build test ERROR on v4.18-rc6 next-20180720]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Pengbo-Mu/usb-dwc3-call-set-incr-burst-type-func/20180723-132027
base:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: x86_64-randconfig-x018-201829 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/usb//dwc3/core.c: In function 'dwc3_core_init':
>> drivers/usb//dwc3/core.c:843:2: error: implicit declaration of function 'dwc3_set_incr_burst_type'; did you mean 'dwc3_set_prtcap'? [-Werror=implicit-function-declaration]
     dwc3_set_incr_burst_type(dwc);
     ^~~~~~~~~~~~~~~~~~~~~~~~
     dwc3_set_prtcap
   cc1: some warnings being treated as errors

vim +843 drivers/usb//dwc3/core.c

   780	
   781	/**
   782	 * dwc3_core_init - Low-level initialization of DWC3 Core
   783	 * @dwc: Pointer to our controller context structure
   784	 *
   785	 * Returns 0 on success otherwise negative errno.
   786	 */
   787	static int dwc3_core_init(struct dwc3 *dwc)
   788	{
   789		u32			reg;
   790		int			ret;
   791	
   792		if (!dwc3_core_is_valid(dwc)) {
   793			dev_err(dwc->dev, "this is not a DesignWare USB3 DRD Core\n");
   794			ret = -ENODEV;
   795			goto err0;
   796		}
   797	
   798		/*
   799		 * Write Linux Version Code to our GUID register so it's easy to figure
   800		 * out which kernel version a bug was found.
   801		 */
   802		dwc3_writel(dwc->regs, DWC3_GUID, LINUX_VERSION_CODE);
   803	
   804		/* Handle USB2.0-only core configuration */
   805		if (DWC3_GHWPARAMS3_SSPHY_IFC(dwc->hwparams.hwparams3) ==
   806				DWC3_GHWPARAMS3_SSPHY_IFC_DIS) {
   807			if (dwc->maximum_speed == USB_SPEED_SUPER)
   808				dwc->maximum_speed = USB_SPEED_HIGH;
   809		}
   810	
   811		ret = dwc3_phy_setup(dwc);
   812		if (ret)
   813			goto err0;
   814	
   815		if (!dwc->ulpi_ready) {
   816			ret = dwc3_core_ulpi_init(dwc);
   817			if (ret)
   818				goto err0;
   819			dwc->ulpi_ready = true;
   820		}
   821	
   822		if (!dwc->phys_ready) {
   823			ret = dwc3_core_get_phy(dwc);
   824			if (ret)
   825				goto err0a;
   826			dwc->phys_ready = true;
   827		}
   828	
   829		ret = dwc3_core_soft_reset(dwc);
   830		if (ret)
   831			goto err0a;
   832	
   833		dwc3_core_setup_global_control(dwc);
   834		dwc3_core_num_eps(dwc);
   835	
   836		ret = dwc3_setup_scratch_buffers(dwc);
   837		if (ret)
   838			goto err1;
   839	
   840		/* Adjust Frame Length */
   841		dwc3_frame_length_adjustment(dwc);
   842	
 > 843		dwc3_set_incr_burst_type(dwc);
   844	
   845		usb_phy_set_suspend(dwc->usb2_phy, 0);
   846		usb_phy_set_suspend(dwc->usb3_phy, 0);
   847		ret = phy_power_on(dwc->usb2_generic_phy);
   848		if (ret < 0)
   849			goto err2;
   850	
   851		ret = phy_power_on(dwc->usb3_generic_phy);
   852		if (ret < 0)
   853			goto err3;
   854	
   855		ret = dwc3_event_buffers_setup(dwc);
   856		if (ret) {
   857			dev_err(dwc->dev, "failed to setup event buffers\n");
   858			goto err4;
   859		}
   860	
   861		/*
   862		 * ENDXFER polling is available on version 3.10a and later of
   863		 * the DWC_usb3 controller. It is NOT available in the
   864		 * DWC_usb31 controller.
   865		 */
   866		if (!dwc3_is_usb31(dwc) && dwc->revision >= DWC3_REVISION_310A) {
   867			reg = dwc3_readl(dwc->regs, DWC3_GUCTL2);
   868			reg |= DWC3_GUCTL2_RST_ACTBITLATER;
   869			dwc3_writel(dwc->regs, DWC3_GUCTL2, reg);
   870		}
   871	
   872		if (dwc->revision >= DWC3_REVISION_250A) {
   873			reg = dwc3_readl(dwc->regs, DWC3_GUCTL1);
   874	
   875			/*
   876			 * Enable hardware control of sending remote wakeup
   877			 * in HS when the device is in the L1 state.
   878			 */
   879			if (dwc->revision >= DWC3_REVISION_290A)
   880				reg |= DWC3_GUCTL1_DEV_L1_EXIT_BY_HW;
   881	
   882			if (dwc->dis_tx_ipgap_linecheck_quirk)
   883				reg |= DWC3_GUCTL1_TX_IPGAP_LINECHECK_DIS;
   884	
   885			dwc3_writel(dwc->regs, DWC3_GUCTL1, reg);
   886		}
   887	
   888		/*
   889		 * Must config both number of packets and max burst settings to enable
   890		 * RX and/or TX threshold.
   891		 */
   892		if (dwc3_is_usb31(dwc) && dwc->dr_mode == USB_DR_MODE_HOST) {
   893			u8 rx_thr_num = dwc->rx_thr_num_pkt_prd;
   894			u8 rx_maxburst = dwc->rx_max_burst_prd;
   895			u8 tx_thr_num = dwc->tx_thr_num_pkt_prd;
   896			u8 tx_maxburst = dwc->tx_max_burst_prd;
   897	
   898			if (rx_thr_num && rx_maxburst) {
   899				reg = dwc3_readl(dwc->regs, DWC3_GRXTHRCFG);
   900				reg |= DWC31_RXTHRNUMPKTSEL_PRD;
   901	
   902				reg &= ~DWC31_RXTHRNUMPKT_PRD(~0);
   903				reg |= DWC31_RXTHRNUMPKT_PRD(rx_thr_num);
   904	
   905				reg &= ~DWC31_MAXRXBURSTSIZE_PRD(~0);
   906				reg |= DWC31_MAXRXBURSTSIZE_PRD(rx_maxburst);
   907	
   908				dwc3_writel(dwc->regs, DWC3_GRXTHRCFG, reg);
   909			}
   910	
   911			if (tx_thr_num && tx_maxburst) {
   912				reg = dwc3_readl(dwc->regs, DWC3_GTXTHRCFG);
   913				reg |= DWC31_TXTHRNUMPKTSEL_PRD;
   914	
   915				reg &= ~DWC31_TXTHRNUMPKT_PRD(~0);
   916				reg |= DWC31_TXTHRNUMPKT_PRD(tx_thr_num);
   917	
   918				reg &= ~DWC31_MAXTXBURSTSIZE_PRD(~0);
   919				reg |= DWC31_MAXTXBURSTSIZE_PRD(tx_maxburst);
   920	
   921				dwc3_writel(dwc->regs, DWC3_GTXTHRCFG, reg);
   922			}
   923		}
   924	
   925		return 0;
   926	
   927	err4:
   928		phy_power_off(dwc->usb3_generic_phy);
   929	
   930	err3:
   931		phy_power_off(dwc->usb2_generic_phy);
   932	
   933	err2:
   934		usb_phy_set_suspend(dwc->usb2_phy, 1);
   935		usb_phy_set_suspend(dwc->usb3_phy, 1);
   936	
   937	err1:
   938		usb_phy_shutdown(dwc->usb2_phy);
   939		usb_phy_shutdown(dwc->usb3_phy);
   940		phy_exit(dwc->usb2_generic_phy);
   941		phy_exit(dwc->usb3_generic_phy);
   942	
   943	err0a:
   944		dwc3_ulpi_exit(dwc);
   945	
   946	err0:
   947		return ret;
   948	}
   949
---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 12+ messages in thread

* usb: dwc3: call set incr burst type func()
@ 2018-07-23  7:48 Pengbo Mu
  0 siblings, 0 replies; 12+ messages in thread
From: Pengbo Mu @ 2018-07-23  7:48 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Felipe Balbi, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org, Ran Wang

I have realized this will cause confusion.
Will remake it !

Thanks,
Pengbo Mu
-----Original Message-----
From: Greg Kroah-Hartman [mailto:gregkh@linuxfoundation.org] 
Sent: 2018年7月23日 15:00
To: Pengbo Mu <pengbo.mu@nxp.com>
Cc: Felipe Balbi <balbi@kernel.org>; linux-kernel@vger.kernel.org; linux-usb@vger.kernel.org; Ran Wang <ran.wang_1@nxp.com>
Subject: Re: [PATCH] usb: dwc3: call set incr burst type func()

On Mon, Jul 23, 2018 at 02:40:57PM +0800, Pengbo Mu wrote:
> Calling dwc3_set_incr_burst_type() in dwc3_core_init().
> This function enabled the undefined length INCR burst type and set 
> INCRx. Different platform may has the different burst size type. In 
> order to get best performance, we need to tune the burst size to one 
> special value, instead of the default value.
> 
> Signed-off-by: Pengbo Mu <pengbo.mu@nxp.com>
> ---
> Changes in v1:
>  - add the calling of dwc3_set_incr_burst_type.

This isn't the changelog :(  You also didn't version the patch in the [PATCH] area :(

Please put this as part of the other series properly.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 12+ messages in thread

* usb: dwc3: call set incr burst type func()
@ 2018-07-23  9:29 Pengbo Mu
  0 siblings, 0 replies; 12+ messages in thread
From: Pengbo Mu @ 2018-07-23  9:29 UTC (permalink / raw)
  To: kbuild test robot
  Cc: kbuild-all@01.org, Felipe Balbi, Greg Kroah-Hartman,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Ran Wang

SGksDQoNClRoZSBmb2xsb3dpbmcgaXMgbXkgY29tcGlsZSByZXN1bHQ6DQogIC4uLg0KICBMRCBb
TV0gIHNvdW5kL3NvYy9jb2RlY3Mvc25kLXNvYy1hazQ2MTMua28NCiAgTEQgW01dICBzb3VuZC9z
b2MvZ2VuZXJpYy9zbmQtc29jLWF1ZGlvLWdyYXBoLWNhcmQua28NCiAgTEQgW01dICBzb3VuZC9z
b2MvZ2VuZXJpYy9zbmQtc29jLXNpbXBsZS1jYXJkLXV0aWxzLmtvDQogIExEIFtNXSAgc291bmQv
c29jL2dlbmVyaWMvc25kLXNvYy1zaW1wbGUtY2FyZC5rbw0KICBMRCBbTV0gIHNvdW5kL3NvYy9z
aC9yY2FyL3NuZC1zb2MtcmNhci5rbw0KcmV0OjANClRoZXNlIHBhdGNoZXMgYXJlIGJhc2VkIG9u
IG1haW5saW5lICwgYW5kIG15IHZlcnNpb24gaXMgbGludXgtNC4xOC1yYzUuIExhc3Qgd2VlayAs
IEkgcHVsbGVkIG15IHVwc3RyZWFtIGJyYW5jaCB0byB0aGUgbGF0ZXN0Lg0KSSBkaWRuJ3Qgc2Vl
IGVycm9yIGxvZyBpbiB0aGlzIHZlcnNpb24uDQpCeSB0aGUgd2F5ICwgdGhpcyBpcyBteSBnaXQg
dHJlZSAtLS0gZ2l0Oi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L2dy
ZWdraC91c2IuZ2l0IC4NClBsZWFzZSB0ZWxsIG1lIHdoaWNoIHRyZWUgY291bGQgc3VpdGFibHkg
ZGV2ZWxvcCBwYXRjaCBmb3IgdXBzdHJlYW0uDQoNClRoYW5rcywNClBlbmdibyBNdQ0KIA0KLS0t
LS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IGtidWlsZCB0ZXN0IHJvYm90IFttYWlsdG86
bGtwQGludGVsLmNvbV0gDQpTZW50OiAyMDE4xOo31MIyM8jVIDE1OjA1DQpUbzogUGVuZ2JvIE11
IDxwZW5nYm8ubXVAbnhwLmNvbT4NCkNjOiBrYnVpbGQtYWxsQDAxLm9yZzsgRmVsaXBlIEJhbGJp
IDxiYWxiaUBrZXJuZWwub3JnPjsgR3JlZyBLcm9haC1IYXJ0bWFuIDxncmVna2hAbGludXhmb3Vu
ZGF0aW9uLm9yZz47IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LXVzYkB2Z2Vy
Lmtlcm5lbC5vcmc7IFJhbiBXYW5nIDxyYW4ud2FuZ18xQG54cC5jb20+OyBQZW5nYm8gTXUgPHBl
bmdiby5tdUBueHAuY29tPg0KU3ViamVjdDogUmU6IFtQQVRDSF0gdXNiOiBkd2MzOiBjYWxsIHNl
dCBpbmNyIGJ1cnN0IHR5cGUgZnVuYygpDQoNCkhpIFBlbmdibywNCg0KVGhhbmsgeW91IGZvciB0
aGUgcGF0Y2ghIFlldCBzb21ldGhpbmcgdG8gaW1wcm92ZToNCg0KW2F1dG8gYnVpbGQgdGVzdCBF
UlJPUiBvbiBiYWxiaS11c2IvbmV4dF0NClthbHNvIGJ1aWxkIHRlc3QgRVJST1Igb24gdjQuMTgt
cmM2IG5leHQtMjAxODA3MjBdDQpbaWYgeW91ciBwYXRjaCBpcyBhcHBsaWVkIHRvIHRoZSB3cm9u
ZyBnaXQgdHJlZSwgcGxlYXNlIGRyb3AgdXMgYSBub3RlIHRvIGhlbHAgaW1wcm92ZSB0aGUgc3lz
dGVtXQ0KDQp1cmw6ICAgIGh0dHBzOi8vZW1lYTAxLnNhZmVsaW5rcy5wcm90ZWN0aW9uLm91dGxv
b2suY29tLz91cmw9aHR0cHMlM0ElMkYlMkZnaXRodWIuY29tJTJGMGRheS1jaSUyRmxpbnV4JTJG
Y29tbWl0cyUyRlBlbmdiby1NdSUyRnVzYi1kd2MzLWNhbGwtc2V0LWluY3ItYnVyc3QtdHlwZS1m
dW5jJTJGMjAxODA3MjMtMTMyMDI3JmFtcDtkYXRhPTAyJTdDMDElN0NwZW5nYm8ubXUlNDBueHAu
Y29tJTdDZTMwOTRiNjExMTEzNGUzN2VkYzYwOGQ1ZjA2YWQ1NDElN0M2ODZlYTFkM2JjMmI0YzZm
YTkyY2Q5OWM1YzMwMTYzNSU3QzAlN0MwJTdDNjM2Njc5MjY3MjU4MTE2MzA4JmFtcDtzZGF0YT04
NFhmT0dUNFYxdXJXczJGJTJCU0hhRVpaV3Y0VGtsNXJSOUZnVWMyalNXN2MlM0QmYW1wO3Jlc2Vy
dmVkPTANCmJhc2U6ICAgaHR0cHM6Ly9lbWVhMDEuc2FmZWxpbmtzLnByb3RlY3Rpb24ub3V0bG9v
ay5jb20vP3VybD1odHRwcyUzQSUyRiUyRmdpdC5rZXJuZWwub3JnJTJGcHViJTJGc2NtJTJGbGlu
dXglMkZrZXJuZWwlMkZnaXQlMkZiYWxiaSUyRnVzYi5naXQmYW1wO2RhdGE9MDIlN0MwMSU3Q3Bl
bmdiby5tdSU0MG54cC5jb20lN0NlMzA5NGI2MTExMTM0ZTM3ZWRjNjA4ZDVmMDZhZDU0MSU3QzY4
NmVhMWQzYmMyYjRjNmZhOTJjZDk5YzVjMzAxNjM1JTdDMCU3QzAlN0M2MzY2NzkyNjcyNTgxMTYz
MDgmYW1wO3NkYXRhPVI4TE96elZVRnpsYkVaN3RrTk9vRSUyRko4UGppMEc2dWtiQ3VpbGN0T1FN
dyUzRCZhbXA7cmVzZXJ2ZWQ9MCBuZXh0DQpjb25maWc6IGkzODYtcmFuZGNvbmZpZy1zMS0yMDE4
MjkgKGF0dGFjaGVkIGFzIC5jb25maWcpDQpjb21waWxlcjogZ2NjLTYgKERlYmlhbiA2LjQuMC05
KSA2LjQuMCAyMDE3MTAyNg0KcmVwcm9kdWNlOg0KICAgICAgICAjIHNhdmUgdGhlIGF0dGFjaGVk
IC5jb25maWcgdG8gbGludXggYnVpbGQgdHJlZQ0KICAgICAgICBtYWtlIEFSQ0g9aTM4NiANCg0K
QWxsIGVycm9ycyAobmV3IG9uZXMgcHJlZml4ZWQgYnkgPj4pOg0KDQogICBkcml2ZXJzL3VzYi9k
d2MzL2NvcmUuYzogSW4gZnVuY3Rpb24gJ2R3YzNfY29yZV9pbml0JzoNCj4+IGRyaXZlcnMvdXNi
L2R3YzMvY29yZS5jOjg0MzoyOiBlcnJvcjogaW1wbGljaXQgZGVjbGFyYXRpb24gb2YgZnVuY3Rp
b24gJ2R3YzNfc2V0X2luY3JfYnVyc3RfdHlwZScgWy1XZXJyb3I9aW1wbGljaXQtZnVuY3Rpb24t
ZGVjbGFyYXRpb25dDQogICAgIGR3YzNfc2V0X2luY3JfYnVyc3RfdHlwZShkd2MpOw0KICAgICBe
fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn4NCiAgIGNjMTogc29tZSB3YXJuaW5ncyBiZWluZyB0cmVh
dGVkIGFzIGVycm9ycw0KDQp2aW0gKy9kd2MzX3NldF9pbmNyX2J1cnN0X3R5cGUgKzg0MyBkcml2
ZXJzL3VzYi9kd2MzL2NvcmUuYw0KDQogICA3ODAJDQogICA3ODEJLyoqDQogICA3ODIJICogZHdj
M19jb3JlX2luaXQgLSBMb3ctbGV2ZWwgaW5pdGlhbGl6YXRpb24gb2YgRFdDMyBDb3JlDQogICA3
ODMJICogQGR3YzogUG9pbnRlciB0byBvdXIgY29udHJvbGxlciBjb250ZXh0IHN0cnVjdHVyZQ0K
ICAgNzg0CSAqDQogICA3ODUJICogUmV0dXJucyAwIG9uIHN1Y2Nlc3Mgb3RoZXJ3aXNlIG5lZ2F0
aXZlIGVycm5vLg0KICAgNzg2CSAqLw0KICAgNzg3CXN0YXRpYyBpbnQgZHdjM19jb3JlX2luaXQo
c3RydWN0IGR3YzMgKmR3YykNCiAgIDc4OAl7DQogICA3ODkJCXUzMgkJCXJlZzsNCiAgIDc5MAkJ
aW50CQkJcmV0Ow0KICAgNzkxCQ0KICAgNzkyCQlpZiAoIWR3YzNfY29yZV9pc192YWxpZChkd2Mp
KSB7DQogICA3OTMJCQlkZXZfZXJyKGR3Yy0+ZGV2LCAidGhpcyBpcyBub3QgYSBEZXNpZ25XYXJl
IFVTQjMgRFJEIENvcmVcbiIpOw0KICAgNzk0CQkJcmV0ID0gLUVOT0RFVjsNCiAgIDc5NQkJCWdv
dG8gZXJyMDsNCiAgIDc5NgkJfQ0KICAgNzk3CQ0KICAgNzk4CQkvKg0KICAgNzk5CQkgKiBXcml0
ZSBMaW51eCBWZXJzaW9uIENvZGUgdG8gb3VyIEdVSUQgcmVnaXN0ZXIgc28gaXQncyBlYXN5IHRv
IGZpZ3VyZQ0KICAgODAwCQkgKiBvdXQgd2hpY2gga2VybmVsIHZlcnNpb24gYSBidWcgd2FzIGZv
dW5kLg0KICAgODAxCQkgKi8NCiAgIDgwMgkJZHdjM193cml0ZWwoZHdjLT5yZWdzLCBEV0MzX0dV
SUQsIExJTlVYX1ZFUlNJT05fQ09ERSk7DQogICA4MDMJDQogICA4MDQJCS8qIEhhbmRsZSBVU0Iy
LjAtb25seSBjb3JlIGNvbmZpZ3VyYXRpb24gKi8NCiAgIDgwNQkJaWYgKERXQzNfR0hXUEFSQU1T
M19TU1BIWV9JRkMoZHdjLT5od3BhcmFtcy5od3BhcmFtczMpID09DQogICA4MDYJCQkJRFdDM19H
SFdQQVJBTVMzX1NTUEhZX0lGQ19ESVMpIHsNCiAgIDgwNwkJCWlmIChkd2MtPm1heGltdW1fc3Bl
ZWQgPT0gVVNCX1NQRUVEX1NVUEVSKQ0KICAgODA4CQkJCWR3Yy0+bWF4aW11bV9zcGVlZCA9IFVT
Ql9TUEVFRF9ISUdIOw0KICAgODA5CQl9DQogICA4MTAJDQogICA4MTEJCXJldCA9IGR3YzNfcGh5
X3NldHVwKGR3Yyk7DQogICA4MTIJCWlmIChyZXQpDQogICA4MTMJCQlnb3RvIGVycjA7DQogICA4
MTQJDQogICA4MTUJCWlmICghZHdjLT51bHBpX3JlYWR5KSB7DQogICA4MTYJCQlyZXQgPSBkd2Mz
X2NvcmVfdWxwaV9pbml0KGR3Yyk7DQogICA4MTcJCQlpZiAocmV0KQ0KICAgODE4CQkJCWdvdG8g
ZXJyMDsNCiAgIDgxOQkJCWR3Yy0+dWxwaV9yZWFkeSA9IHRydWU7DQogICA4MjAJCX0NCiAgIDgy
MQkNCiAgIDgyMgkJaWYgKCFkd2MtPnBoeXNfcmVhZHkpIHsNCiAgIDgyMwkJCXJldCA9IGR3YzNf
Y29yZV9nZXRfcGh5KGR3Yyk7DQogICA4MjQJCQlpZiAocmV0KQ0KICAgODI1CQkJCWdvdG8gZXJy
MGE7DQogICA4MjYJCQlkd2MtPnBoeXNfcmVhZHkgPSB0cnVlOw0KICAgODI3CQl9DQogICA4MjgJ
DQogICA4MjkJCXJldCA9IGR3YzNfY29yZV9zb2Z0X3Jlc2V0KGR3Yyk7DQogICA4MzAJCWlmIChy
ZXQpDQogICA4MzEJCQlnb3RvIGVycjBhOw0KICAgODMyCQ0KICAgODMzCQlkd2MzX2NvcmVfc2V0
dXBfZ2xvYmFsX2NvbnRyb2woZHdjKTsNCiAgIDgzNAkJZHdjM19jb3JlX251bV9lcHMoZHdjKTsN
CiAgIDgzNQkNCiAgIDgzNgkJcmV0ID0gZHdjM19zZXR1cF9zY3JhdGNoX2J1ZmZlcnMoZHdjKTsN
CiAgIDgzNwkJaWYgKHJldCkNCiAgIDgzOAkJCWdvdG8gZXJyMTsNCiAgIDgzOQkNCiAgIDg0MAkJ
LyogQWRqdXN0IEZyYW1lIExlbmd0aCAqLw0KICAgODQxCQlkd2MzX2ZyYW1lX2xlbmd0aF9hZGp1
c3RtZW50KGR3Yyk7DQogICA4NDIJDQogPiA4NDMJCWR3YzNfc2V0X2luY3JfYnVyc3RfdHlwZShk
d2MpOw0KICAgODQ0CQ0KICAgODQ1CQl1c2JfcGh5X3NldF9zdXNwZW5kKGR3Yy0+dXNiMl9waHks
IDApOw0KICAgODQ2CQl1c2JfcGh5X3NldF9zdXNwZW5kKGR3Yy0+dXNiM19waHksIDApOw0KICAg
ODQ3CQlyZXQgPSBwaHlfcG93ZXJfb24oZHdjLT51c2IyX2dlbmVyaWNfcGh5KTsNCiAgIDg0OAkJ
aWYgKHJldCA8IDApDQogICA4NDkJCQlnb3RvIGVycjI7DQogICA4NTAJDQogICA4NTEJCXJldCA9
IHBoeV9wb3dlcl9vbihkd2MtPnVzYjNfZ2VuZXJpY19waHkpOw0KICAgODUyCQlpZiAocmV0IDwg
MCkNCiAgIDg1MwkJCWdvdG8gZXJyMzsNCiAgIDg1NAkNCiAgIDg1NQkJcmV0ID0gZHdjM19ldmVu
dF9idWZmZXJzX3NldHVwKGR3Yyk7DQogICA4NTYJCWlmIChyZXQpIHsNCiAgIDg1NwkJCWRldl9l
cnIoZHdjLT5kZXYsICJmYWlsZWQgdG8gc2V0dXAgZXZlbnQgYnVmZmVyc1xuIik7DQogICA4NTgJ
CQlnb3RvIGVycjQ7DQogICA4NTkJCX0NCiAgIDg2MAkNCiAgIDg2MQkJLyoNCiAgIDg2MgkJICog
RU5EWEZFUiBwb2xsaW5nIGlzIGF2YWlsYWJsZSBvbiB2ZXJzaW9uIDMuMTBhIGFuZCBsYXRlciBv
Zg0KICAgODYzCQkgKiB0aGUgRFdDX3VzYjMgY29udHJvbGxlci4gSXQgaXMgTk9UIGF2YWlsYWJs
ZSBpbiB0aGUNCiAgIDg2NAkJICogRFdDX3VzYjMxIGNvbnRyb2xsZXIuDQogICA4NjUJCSAqLw0K
ICAgODY2CQlpZiAoIWR3YzNfaXNfdXNiMzEoZHdjKSAmJiBkd2MtPnJldmlzaW9uID49IERXQzNf
UkVWSVNJT05fMzEwQSkgew0KICAgODY3CQkJcmVnID0gZHdjM19yZWFkbChkd2MtPnJlZ3MsIERX
QzNfR1VDVEwyKTsNCiAgIDg2OAkJCXJlZyB8PSBEV0MzX0dVQ1RMMl9SU1RfQUNUQklUTEFURVI7
DQogICA4NjkJCQlkd2MzX3dyaXRlbChkd2MtPnJlZ3MsIERXQzNfR1VDVEwyLCByZWcpOw0KICAg
ODcwCQl9DQogICA4NzEJDQogICA4NzIJCWlmIChkd2MtPnJldmlzaW9uID49IERXQzNfUkVWSVNJ
T05fMjUwQSkgew0KICAgODczCQkJcmVnID0gZHdjM19yZWFkbChkd2MtPnJlZ3MsIERXQzNfR1VD
VEwxKTsNCiAgIDg3NAkNCiAgIDg3NQkJCS8qDQogICA4NzYJCQkgKiBFbmFibGUgaGFyZHdhcmUg
Y29udHJvbCBvZiBzZW5kaW5nIHJlbW90ZSB3YWtldXANCiAgIDg3NwkJCSAqIGluIEhTIHdoZW4g
dGhlIGRldmljZSBpcyBpbiB0aGUgTDEgc3RhdGUuDQogICA4NzgJCQkgKi8NCiAgIDg3OQkJCWlm
IChkd2MtPnJldmlzaW9uID49IERXQzNfUkVWSVNJT05fMjkwQSkNCiAgIDg4MAkJCQlyZWcgfD0g
RFdDM19HVUNUTDFfREVWX0wxX0VYSVRfQllfSFc7DQogICA4ODEJDQogICA4ODIJCQlpZiAoZHdj
LT5kaXNfdHhfaXBnYXBfbGluZWNoZWNrX3F1aXJrKQ0KICAgODgzCQkJCXJlZyB8PSBEV0MzX0dV
Q1RMMV9UWF9JUEdBUF9MSU5FQ0hFQ0tfRElTOw0KICAgODg0CQ0KICAgODg1CQkJZHdjM193cml0
ZWwoZHdjLT5yZWdzLCBEV0MzX0dVQ1RMMSwgcmVnKTsNCiAgIDg4NgkJfQ0KICAgODg3CQ0KICAg
ODg4CQkvKg0KICAgODg5CQkgKiBNdXN0IGNvbmZpZyBib3RoIG51bWJlciBvZiBwYWNrZXRzIGFu
ZCBtYXggYnVyc3Qgc2V0dGluZ3MgdG8gZW5hYmxlDQogICA4OTAJCSAqIFJYIGFuZC9vciBUWCB0
aHJlc2hvbGQuDQogICA4OTEJCSAqLw0KICAgODkyCQlpZiAoZHdjM19pc191c2IzMShkd2MpICYm
IGR3Yy0+ZHJfbW9kZSA9PSBVU0JfRFJfTU9ERV9IT1NUKSB7DQogICA4OTMJCQl1OCByeF90aHJf
bnVtID0gZHdjLT5yeF90aHJfbnVtX3BrdF9wcmQ7DQogICA4OTQJCQl1OCByeF9tYXhidXJzdCA9
IGR3Yy0+cnhfbWF4X2J1cnN0X3ByZDsNCiAgIDg5NQkJCXU4IHR4X3Rocl9udW0gPSBkd2MtPnR4
X3Rocl9udW1fcGt0X3ByZDsNCiAgIDg5NgkJCXU4IHR4X21heGJ1cnN0ID0gZHdjLT50eF9tYXhf
YnVyc3RfcHJkOw0KICAgODk3CQ0KICAgODk4CQkJaWYgKHJ4X3Rocl9udW0gJiYgcnhfbWF4YnVy
c3QpIHsNCiAgIDg5OQkJCQlyZWcgPSBkd2MzX3JlYWRsKGR3Yy0+cmVncywgRFdDM19HUlhUSFJD
RkcpOw0KICAgOTAwCQkJCXJlZyB8PSBEV0MzMV9SWFRIUk5VTVBLVFNFTF9QUkQ7DQogICA5MDEJ
DQogICA5MDIJCQkJcmVnICY9IH5EV0MzMV9SWFRIUk5VTVBLVF9QUkQofjApOw0KICAgOTAzCQkJ
CXJlZyB8PSBEV0MzMV9SWFRIUk5VTVBLVF9QUkQocnhfdGhyX251bSk7DQogICA5MDQJDQogICA5
MDUJCQkJcmVnICY9IH5EV0MzMV9NQVhSWEJVUlNUU0laRV9QUkQofjApOw0KICAgOTA2CQkJCXJl
ZyB8PSBEV0MzMV9NQVhSWEJVUlNUU0laRV9QUkQocnhfbWF4YnVyc3QpOw0KICAgOTA3CQ0KICAg
OTA4CQkJCWR3YzNfd3JpdGVsKGR3Yy0+cmVncywgRFdDM19HUlhUSFJDRkcsIHJlZyk7DQogICA5
MDkJCQl9DQogICA5MTAJDQogICA5MTEJCQlpZiAodHhfdGhyX251bSAmJiB0eF9tYXhidXJzdCkg
ew0KICAgOTEyCQkJCXJlZyA9IGR3YzNfcmVhZGwoZHdjLT5yZWdzLCBEV0MzX0dUWFRIUkNGRyk7
DQogICA5MTMJCQkJcmVnIHw9IERXQzMxX1RYVEhSTlVNUEtUU0VMX1BSRDsNCiAgIDkxNAkNCiAg
IDkxNQkJCQlyZWcgJj0gfkRXQzMxX1RYVEhSTlVNUEtUX1BSRCh+MCk7DQogICA5MTYJCQkJcmVn
IHw9IERXQzMxX1RYVEhSTlVNUEtUX1BSRCh0eF90aHJfbnVtKTsNCiAgIDkxNwkNCiAgIDkxOAkJ
CQlyZWcgJj0gfkRXQzMxX01BWFRYQlVSU1RTSVpFX1BSRCh+MCk7DQogICA5MTkJCQkJcmVnIHw9
IERXQzMxX01BWFRYQlVSU1RTSVpFX1BSRCh0eF9tYXhidXJzdCk7DQogICA5MjAJDQogICA5MjEJ
CQkJZHdjM193cml0ZWwoZHdjLT5yZWdzLCBEV0MzX0dUWFRIUkNGRywgcmVnKTsNCiAgIDkyMgkJ
CX0NCiAgIDkyMwkJfQ0KICAgOTI0CQ0KICAgOTI1CQlyZXR1cm4gMDsNCiAgIDkyNgkNCiAgIDky
NwllcnI0Og0KICAgOTI4CQlwaHlfcG93ZXJfb2ZmKGR3Yy0+dXNiM19nZW5lcmljX3BoeSk7DQog
ICA5MjkJDQogICA5MzAJZXJyMzoNCiAgIDkzMQkJcGh5X3Bvd2VyX29mZihkd2MtPnVzYjJfZ2Vu
ZXJpY19waHkpOw0KICAgOTMyCQ0KICAgOTMzCWVycjI6DQogICA5MzQJCXVzYl9waHlfc2V0X3N1
c3BlbmQoZHdjLT51c2IyX3BoeSwgMSk7DQogICA5MzUJCXVzYl9waHlfc2V0X3N1c3BlbmQoZHdj
LT51c2IzX3BoeSwgMSk7DQogICA5MzYJDQogICA5MzcJZXJyMToNCiAgIDkzOAkJdXNiX3BoeV9z
aHV0ZG93bihkd2MtPnVzYjJfcGh5KTsNCiAgIDkzOQkJdXNiX3BoeV9zaHV0ZG93bihkd2MtPnVz
YjNfcGh5KTsNCiAgIDk0MAkJcGh5X2V4aXQoZHdjLT51c2IyX2dlbmVyaWNfcGh5KTsNCiAgIDk0
MQkJcGh5X2V4aXQoZHdjLT51c2IzX2dlbmVyaWNfcGh5KTsNCiAgIDk0MgkNCiAgIDk0MwllcnIw
YToNCiAgIDk0NAkJZHdjM191bHBpX2V4aXQoZHdjKTsNCiAgIDk0NQkNCiAgIDk0NgllcnIwOg0K
ICAgOTQ3CQlyZXR1cm4gcmV0Ow0KICAgOTQ4CX0NCiAgIDk0OQkNCg0KLS0tDQowLURBWSBrZXJu
ZWwgdGVzdCBpbmZyYXN0cnVjdHVyZSAgICAgICAgICAgICAgICBPcGVuIFNvdXJjZSBUZWNobm9s
b2d5IENlbnRlcg0KaHR0cHM6Ly9lbWVhMDEuc2FmZWxpbmtzLnByb3RlY3Rpb24ub3V0bG9vay5j
b20vP3VybD1odHRwcyUzQSUyRiUyRmxpc3RzLjAxLm9yZyUyRnBpcGVybWFpbCUyRmtidWlsZC1h
bGwmYW1wO2RhdGE9MDIlN0MwMSU3Q3Blbmdiby5tdSU0MG54cC5jb20lN0NlMzA5NGI2MTExMTM0
ZTM3ZWRjNjA4ZDVmMDZhZDU0MSU3QzY4NmVhMWQzYmMyYjRjNmZhOTJjZDk5YzVjMzAxNjM1JTdD
MCU3QzAlN0M2MzY2NzkyNjcyNTgxMTYzMDgmYW1wO3NkYXRhPUs2ZUw1dmlmaHQyJTJGa1JIYVcw
c0ZJSnRQUEJuN1Z2UWNZY2xjWTdaN0VTVSUzRCZhbXA7cmVzZXJ2ZWQ9MCAgICAgICAgICAgICAg
ICAgICBJbnRlbCBDb3Jwb3JhdGlvbg0K
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 12+ messages in thread

* usb: dwc3: call set incr burst type func()
@ 2018-07-23 10:03 Felipe Balbi
  0 siblings, 0 replies; 12+ messages in thread
From: Felipe Balbi @ 2018-07-23 10:03 UTC (permalink / raw)
  To: Pengbo Mu, kbuild test robot
  Cc: kbuild-all@01.org, Greg Kroah-Hartman,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Ran Wang

Hi,

(no top-posting)

Pengbo Mu <pengbo.mu@nxp.com> writes:
> Hi,
>
> The following is my compile result:
>   ...
>   LD [M]  sound/soc/codecs/snd-soc-ak4613.ko
>   LD [M]  sound/soc/generic/snd-soc-audio-graph-card.ko
>   LD [M]  sound/soc/generic/snd-soc-simple-card-utils.ko
>   LD [M]  sound/soc/generic/snd-soc-simple-card.ko
>   LD [M]  sound/soc/sh/rcar/snd-soc-rcar.ko
> ret:0
> These patches are based on mainline , and my version is linux-4.18-rc5. Last week , I pulled my upstream branch to the latest.
> I didn't see error log in this version.
> By the way , this is my git tree --- git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git .
> Please tell me which tree could suitably develop patch for upstream.

this is a result of you sending this patch outside of the series it
belongs to. Just resend the full series and things should be okay. Also,
as Greg already mentioned, please write changelogs that explain WHY the
change was made.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* usb: dwc3: call set incr burst type func()
@ 2018-07-23 10:35 Pengbo Mu
  0 siblings, 0 replies; 12+ messages in thread
From: Pengbo Mu @ 2018-07-23 10:35 UTC (permalink / raw)
  To: Felipe Balbi, kbuild test robot
  Cc: kbuild-all@01.org, Greg Kroah-Hartman,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Ran Wang

Roger that.
I have sent the full series. Please review.

Thanks,
Pengbo
-----Original Message-----
From: Felipe Balbi [mailto:balbi@kernel.org] 
Sent: 2018年7月23日 18:04
To: Pengbo Mu <pengbo.mu@nxp.com>; kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org; Greg Kroah-Hartman <gregkh@linuxfoundation.org>; linux-kernel@vger.kernel.org; linux-usb@vger.kernel.org; Ran Wang <ran.wang_1@nxp.com>
Subject: RE: [PATCH] usb: dwc3: call set incr burst type func()


Hi,

(no top-posting)

Pengbo Mu <pengbo.mu@nxp.com> writes:
> Hi,
>
> The following is my compile result:
>   ...
>   LD [M]  sound/soc/codecs/snd-soc-ak4613.ko
>   LD [M]  sound/soc/generic/snd-soc-audio-graph-card.ko
>   LD [M]  sound/soc/generic/snd-soc-simple-card-utils.ko
>   LD [M]  sound/soc/generic/snd-soc-simple-card.ko
>   LD [M]  sound/soc/sh/rcar/snd-soc-rcar.ko
> ret:0
> These patches are based on mainline , and my version is linux-4.18-rc5. Last week , I pulled my upstream branch to the latest.
> I didn't see error log in this version.
> By the way , this is my git tree --- git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git .
> Please tell me which tree could suitably develop patch for upstream.

this is a result of you sending this patch outside of the series it belongs to. Just resend the full series and things should be okay. Also, as Greg already mentioned, please write changelogs that explain WHY the change was made.

--
balbi

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2018-07-23 10:35 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-23  5:16 usb: dwc3: call set incr burst type func() Greg Kroah-Hartman
  -- strict thread matches above, loose matches on Subject: below --
2018-07-23 10:35 Pengbo Mu
2018-07-23 10:03 Felipe Balbi
2018-07-23  9:29 Pengbo Mu
2018-07-23  7:48 Pengbo Mu
2018-07-23  7:10 kbuild test robot
2018-07-23  7:05 kbuild test robot
2018-07-23  7:00 Greg Kroah-Hartman
2018-07-23  6:59 Greg Kroah-Hartman
2018-07-23  6:40 Pengbo Mu
2018-07-23  6:37 Pengbo Mu
2018-07-23  3:34 Pengbo Mu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).