* [REPOST,1/4] usb: dwc2: Turn on uframe_sched on "bcm" platforms
@ 2018-07-26 20:07 Doug Anderson
0 siblings, 0 replies; 2+ messages in thread
From: Doug Anderson @ 2018-07-26 20:07 UTC (permalink / raw)
To: balbi, hminas, gregkh
Cc: stefan.wahren, grigor.tovmasyan, Bruno Herrera, Zhangfei Gao,
john.stultz, Stephen Warren, Jerome Brunet, Douglas Anderson,
linux-usb, linux-kernel
There's no reason to have the uframe scheduler off on dwc2. Running
with uframe_sched = False is equivalent to saying "I don't want to run
the correct code, I want to run the old and incorrect code".
The uframe scheduler has been off on Broadcom since commit
58b179dcf28c ("staging: dwc2: disable uframe_sched on the bcm2835").
Since then there have been many many improvements, notably the commit
9f9f09b048f5 ("usb: dwc2: host: Totally redo the microframe
scheduler")
Presumably if everyone is good w/ the uframe_sched turned back on we
can kill all the old and crufty non-uframe sched code.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
---
drivers/usb/dwc2/params.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index af075d4da895..14b8742e62fa 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -47,7 +47,6 @@ static void dwc2_set_bcm_params(struct dwc2_hsotg *hsotg)
p->max_transfer_size = 65535;
p->max_packet_count = 511;
p->ahbcfg = 0x10;
- p->uframe_sched = false;
}
static void dwc2_set_his_params(struct dwc2_hsotg *hsotg)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [REPOST,1/4] usb: dwc2: Turn on uframe_sched on "bcm" platforms
@ 2018-07-27 11:09 Minas Harutyunyan
0 siblings, 0 replies; 2+ messages in thread
From: Minas Harutyunyan @ 2018-07-27 11:09 UTC (permalink / raw)
To: Douglas Anderson, balbi@kernel.org,
Minas.Harutyunyan@synopsys.com, gregkh@linuxfoundation.org
Cc: stefan.wahren@i2se.com, grigor.tovmasyan@synopsys.com,
Bruno Herrera, Zhangfei Gao, john.stultz@linaro.org,
Stephen Warren, Jerome Brunet, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
On 7/27/2018 12:08 AM, Douglas Anderson wrote:
> There's no reason to have the uframe scheduler off on dwc2. Running
> with uframe_sched = False is equivalent to saying "I don't want to run
> the correct code, I want to run the old and incorrect code".
>
> The uframe scheduler has been off on Broadcom since commit
> 58b179dcf28c ("staging: dwc2: disable uframe_sched on the bcm2835").
> Since then there have been many many improvements, notably the commit
> 9f9f09b048f5 ("usb: dwc2: host: Totally redo the microframe
> scheduler")
>
> Presumably if everyone is good w/ the uframe_sched turned back on we
> can kill all the old and crufty non-uframe sched code.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
Acked-by: Minas Harutyunyan <hminas@synopsys.com>
> ---
>
> drivers/usb/dwc2/params.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index af075d4da895..14b8742e62fa 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -47,7 +47,6 @@ static void dwc2_set_bcm_params(struct dwc2_hsotg *hsotg)
> p->max_transfer_size = 65535;
> p->max_packet_count = 511;
> p->ahbcfg = 0x10;
> - p->uframe_sched = false;
> }
>
> static void dwc2_set_his_params(struct dwc2_hsotg *hsotg)
>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-27 11:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-26 20:07 [REPOST,1/4] usb: dwc2: Turn on uframe_sched on "bcm" platforms Doug Anderson
-- strict thread matches above, loose matches on Subject: below --
2018-07-27 11:09 Minas Harutyunyan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).