From: Vincent Pelletier <plr.vincent@gmail.com>
To: Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Roger Quadros <rogerq@ti.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Sam Protsenko <semen.protsenko@linaro.org>,
linux-usb@vger.kernel.org, Praneeth Bajjuri <praneeth@ti.com>,
"He, Bo" <bo.he@intel.com>, "Bai, Jie A" <jie.a.bai@intel.com>
Subject: usb: gadget: ffs: Fix BUG when userland exits with submitted AIO transfers
Date: Wed, 1 Aug 2018 15:03:55 +0000 [thread overview]
Message-ID: <20180801150338.017e39c1@gmail.com> (raw)
Hello,
Bo He, CC'ed, found a regression introduced in my patch, discussed in
this thread, and submitted a patch:
Subject: [PATCH] fix panic at pwq_activate_delayed_work.
Date: Wed, 1 Aug 2018 10:14:38 +0000
Message-ID: <CD6925E8781EFD4D8E11882D20FC406D529834D2@SHSMSX104.ccr.corp.intel.com>
On Fri, 29 Jun 2018 09:32:43 +0300, Felipe Balbi
<felipe.balbi@linux.intel.com> wrote:
> Hmm, that's what I remember, but we don't have that documented and dwc3
> has a sleep in its dequeue, which I need to remove for other reasons
> anyway.
Given the above comment from Felipe, I expected my patch would be
dropped in favour of making dwc3 not sleep in dequeue, as it seems to
be the actual root cause.
Should my patch be reverted ? It adds complexity which, I believe,
becomes superfluous if dequeue does not sleep anywhere.
Or maybe non-sleeping dequeue is not there yet, and a solution right now
(later revertable) is better, in which case my change would be worth
fixing ?
next reply other threads:[~2018-08-01 15:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 15:03 Vincent Pelletier [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-01-17 16:29 usb: gadget: ffs: Fix BUG when userland exits with submitted AIO transfers Evan Green
2019-01-16 23:56 Evan Green
2018-10-23 14:22 Lars-Peter Clausen
2018-10-23 12:20 Lars-Peter Clausen
2018-09-27 2:31 He, Bo
2018-09-25 12:46 Vincent Pelletier
2018-08-02 14:23 Vincent Pelletier
2018-08-02 0:45 He, Bo
2018-06-29 6:32 Felipe Balbi
2018-06-21 15:30 Alan Stern
2018-06-21 11:10 Roger Quadros
2018-06-21 10:52 Lars-Peter Clausen
2018-06-21 8:29 Roger Quadros
2018-06-19 13:20 Sam Protsenko
2018-06-14 13:23 Sam Protsenko
2018-06-13 11:05 Vincent Pelletier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801150338.017e39c1@gmail.com \
--to=plr.vincent@gmail.com \
--cc=bo.he@intel.com \
--cc=felipe.balbi@linux.intel.com \
--cc=jie.a.bai@intel.com \
--cc=lars@metafoo.de \
--cc=linux-usb@vger.kernel.org \
--cc=praneeth@ti.com \
--cc=rogerq@ti.com \
--cc=semen.protsenko@linaro.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).