* [2/2] usb storage: remove inherited SCSI dependency for USB_STORAGE subentries
@ 2018-08-08 22:01 Vladimir Zapolskiy
0 siblings, 0 replies; 6+ messages in thread
From: Vladimir Zapolskiy @ 2018-08-08 22:01 UTC (permalink / raw)
To: Alan Stern, Greg Kroah-Hartman; +Cc: linux-usb, usb-storage
Because USB_STORAGE build symbol strictly depends on SCSI build
symbol, there is no need to specify it again for USB_UAS and
USB_STORAGE_ENE_UB6250 build options.
In addition USB_STORAGE_ENE_UB6250 entry description repeats a note
about SCSI dependency from the parent USB_STORAGE entry description,
hence the change removes this duplication.
Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
---
drivers/usb/storage/Kconfig | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/usb/storage/Kconfig b/drivers/usb/storage/Kconfig
index 0aef832d3be6..7db5b28fbf0c 100644
--- a/drivers/usb/storage/Kconfig
+++ b/drivers/usb/storage/Kconfig
@@ -176,21 +176,15 @@ config USB_STORAGE_CYPRESS_ATACB
config USB_STORAGE_ENE_UB6250
tristate "USB ENE card reader support"
- depends on SCSI
---help---
Say Y here if you wish to control a ENE SD/MS Card reader.
Note that this driver does not support SM cards.
- This option depends on 'SCSI' support being enabled, but you
- probably also need 'SCSI device support: SCSI disk support'
- (BLK_DEV_SD) for most USB storage devices.
-
To compile this driver as a module, choose M here: the
module will be called ums-eneub6250.
config USB_UAS
tristate "USB Attached SCSI"
- depends on SCSI
help
The USB Attached SCSI protocol is supported by some USB
storage devices. It permits higher performance by supporting
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [2/2] usb storage: remove inherited SCSI dependency for USB_STORAGE subentries
@ 2018-08-09 7:38 Oliver Neukum
0 siblings, 0 replies; 6+ messages in thread
From: Oliver Neukum @ 2018-08-09 7:38 UTC (permalink / raw)
To: Vladimir Zapolskiy, Greg Kroah-Hartman, Alan Stern; +Cc: usb-storage, linux-usb
On Do, 2018-08-09 at 01:01 +0300, Vladimir Zapolskiy wrote:
> Because USB_STORAGE build symbol strictly depends on SCSI build
> symbol, there is no need to specify it again for USB_UAS and
> USB_STORAGE_ENE_UB6250 build options.
[..]
> config USB_UAS
> tristate "USB Attached SCSI"
> - depends on SCSI
> help
> The USB Attached SCSI protocol is supported by some USB
> storage devices. It permits higher performance by supporting
Hi,
I am sorry, but this is wrong. You can build and use UAS without
old style storage support. I do not recommend that you do so,
but in theory it is possible.
And UAS very much depends on storage.
Regards
Oliver
Nacked-by: Oliver Neukum <oneukum@suse.com>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* [2/2] usb storage: remove inherited SCSI dependency for USB_STORAGE subentries
@ 2018-08-09 7:50 Vladimir Zapolskiy
0 siblings, 0 replies; 6+ messages in thread
From: Vladimir Zapolskiy @ 2018-08-09 7:50 UTC (permalink / raw)
To: Oliver Neukum, Greg Kroah-Hartman, Alan Stern; +Cc: usb-storage, linux-usb
Hi Oliver,
On 08/09/2018 10:38 AM, Oliver Neukum wrote:
> On Do, 2018-08-09 at 01:01 +0300, Vladimir Zapolskiy wrote:
>> Because USB_STORAGE build symbol strictly depends on SCSI build
>> symbol, there is no need to specify it again for USB_UAS and
>> USB_STORAGE_ENE_UB6250 build options.
>
> [..]
>
>> config USB_UAS
>> tristate "USB Attached SCSI"
>> - depends on SCSI
>> help
>> The USB Attached SCSI protocol is supported by some USB
>> storage devices. It permits higher performance by supporting
>
> Hi,
>
> I am sorry, but this is wrong. You can build and use UAS without
can you please elaborate what is wrong exactly.
The change is non-functional.
---
Best wishes,
Vladimir
> old style storage support. I do not recommend that you do so,
> but in theory it is possible.
> And UAS very much depends on storage.
>
> Regards
> Oliver
>
> Nacked-by: Oliver Neukum <oneukum@suse.com>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* [2/2] usb storage: remove inherited SCSI dependency for USB_STORAGE subentries
@ 2018-08-09 8:23 Oliver Neukum
0 siblings, 0 replies; 6+ messages in thread
From: Oliver Neukum @ 2018-08-09 8:23 UTC (permalink / raw)
To: Vladimir Zapolskiy, Greg Kroah-Hartman, Alan Stern; +Cc: usb-storage, linux-usb
On Do, 2018-08-09 at 10:50 +0300, Vladimir Zapolskiy wrote:
> Hi Oliver,
>
> On 08/09/2018 10:38 AM, Oliver Neukum wrote:
> > On Do, 2018-08-09 at 01:01 +0300, Vladimir Zapolskiy wrote:
> > > Because USB_STORAGE build symbol strictly depends on SCSI build
> > > symbol, there is no need to specify it again for USB_UAS and
> > > USB_STORAGE_ENE_UB6250 build options.
> >
> > [..]
> >
> > > config USB_UAS
> > > tristate "USB Attached SCSI"
> > > - depends on SCSI
> > > help
> > > The USB Attached SCSI protocol is supported by some USB
> > > storage devices. It permits higher performance by supporting
> >
> > Hi,
> >
> > I am sorry, but this is wrong. You can build and use UAS without
>
> can you please elaborate what is wrong exactly.
>
> The change is non-functional.
Hi,
as far as I can tell you are introducing an implicit dependency
of CONFIG_USB_UAS on CONFIG_USB_STORAGE.
Now, firstly implicit references are bad anyway, secondly
in this case it is wrong. Uas works without usb-storage.
Regards
Oliver
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* [2/2] usb storage: remove inherited SCSI dependency for USB_STORAGE subentries
@ 2018-08-09 9:21 Greg Kroah-Hartman
0 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2018-08-09 9:21 UTC (permalink / raw)
To: Oliver Neukum; +Cc: Vladimir Zapolskiy, Alan Stern, usb-storage, linux-usb
On Thu, Aug 09, 2018 at 09:38:40AM +0200, Oliver Neukum wrote:
> On Do, 2018-08-09 at 01:01 +0300, Vladimir Zapolskiy wrote:
> > Because USB_STORAGE build symbol strictly depends on SCSI build
> > symbol, there is no need to specify it again for USB_UAS and
> > USB_STORAGE_ENE_UB6250 build options.
>
> [..]
>
> > config USB_UAS
> > tristate "USB Attached SCSI"
> > - depends on SCSI
> > help
> > The USB Attached SCSI protocol is supported by some USB
> > storage devices. It permits higher performance by supporting
>
> Hi,
>
> I am sorry, but this is wrong. You can build and use UAS without
> old style storage support. I do not recommend that you do so,
> but in theory it is possible.
> And UAS very much depends on storage.
But today UAS depends on SCSI and USB_STORAGE, so if this is true, it's
not very obvious :)
thanks,
greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* [2/2] usb storage: remove inherited SCSI dependency for USB_STORAGE subentries
@ 2018-08-09 9:27 Oliver Neukum
0 siblings, 0 replies; 6+ messages in thread
From: Oliver Neukum @ 2018-08-09 9:27 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: usb-storage, Vladimir Zapolskiy, Alan Stern, linux-usb
On Do, 2018-08-09 at 11:21 +0200, Greg Kroah-Hartman wrote:
> On Thu, Aug 09, 2018 at 09:38:40AM +0200, Oliver Neukum wrote:
> > On Do, 2018-08-09 at 01:01 +0300, Vladimir Zapolskiy wrote:
> > > Because USB_STORAGE build symbol strictly depends on SCSI build
> > > symbol, there is no need to specify it again for USB_UAS and
> > > USB_STORAGE_ENE_UB6250 build options.
> >
> > [..]
> >
> > > config USB_UAS
> > > tristate "USB Attached SCSI"
> > > - depends on SCSI
> > > help
> > > The USB Attached SCSI protocol is supported by some USB
> > > storage devices. It permits higher performance by supporting
> >
> > Hi,
> >
> > I am sorry, but this is wrong. You can build and use UAS without
> > old style storage support. I do not recommend that you do so,
> > but in theory it is possible.
> > And UAS very much depends on storage.
>
> But today UAS depends on SCSI and USB_STORAGE, so if this is true, it's
> not very obvious :)
Hi,
yes, this is an issue. Nevertheless UAS depends on SCSI and this
dependency better stay.
Regards
Oliver
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-08-09 9:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-08 22:01 [2/2] usb storage: remove inherited SCSI dependency for USB_STORAGE subentries Vladimir Zapolskiy
-- strict thread matches above, loose matches on Subject: below --
2018-08-09 7:38 Oliver Neukum
2018-08-09 7:50 Vladimir Zapolskiy
2018-08-09 8:23 Oliver Neukum
2018-08-09 9:21 Greg Kroah-Hartman
2018-08-09 9:27 Oliver Neukum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).