From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tom Todd <thomas.m.a.todd@gmail.com>
Cc: joe@perches.com, stern@rowland.harvard.edu,
dan.carpenter@oracle.com, arvind.yadav.cs@gmail.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [v2] USB: core: devio: Restructured proc_ioctl for readability
Date: Mon, 13 Aug 2018 08:34:55 +0200 [thread overview]
Message-ID: <20180813063455.GA29496@kroah.com> (raw)
On Sun, Aug 12, 2018 at 11:26:54PM +0100, Tom Todd wrote:
> On, Sun, 12 Aug 2018 11:34:59 -0700 Joe Perches wrote:
> >On Sun, 2018-08-12 at 19:06 +0100, Tom Todd wrote:
> >> Fixed a code styling issue
> >while it's OK to fix style only issues, it's much better
> >to reorganize the code for reader clarity.
>
> Ok, thank you, I've taken your suggestions and created the a new version
>
> Restructured method proc_ioctl for readability and fixed code style
> errors.
Please always be very specific as to exactly what code style issues you
are fixing. And never do more than one type of fix at a time, otherwise
it is hard to review, and you can cause errors to be added, like you did
here :(
Please do not start working on code cleanups in any other area of the
kernel other than drivers/staging/ as that is what that is for. To do
so in other areas of the kernel causes more work for maintainers.
thanks,
greg k-h
next reply other threads:[~2018-08-13 6:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 6:34 Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-08-13 18:22 [v2] USB: core: devio: Restructured proc_ioctl for readability Tom Todd
2018-08-12 22:46 Alan Stern
2018-08-12 22:26 Tom Todd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180813063455.GA29496@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arvind.yadav.cs@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=thomas.m.a.todd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).